Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12 ATRT subtyping (11/N) #332

Merged
merged 193 commits into from
Apr 29, 2023
Merged

v12 ATRT subtyping (11/N) #332

merged 193 commits into from
Apr 29, 2023

Conversation

jharenza
Copy link
Member

@jharenza jharenza commented Mar 2, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

This PR reruns ATRT subtyping. This module is solely based on methylation.

What was your approach?

Minor code changes to format the ATRT subtypes and pull the new methylation column names.
Major code changes to reformat output to one specimen per line.

What GitHub issue does your pull request address?

v12 subtyping and d3b-center/ticket-tracker-OPC#505

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Updated code

Is there anything that you want to discuss further?

No

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

Results table:
N tumors subtyped:

# A tibble: 4 x 2
  molecular_subtype          n
  <chr>                  <int>
1 ATRT, MYC                 20
2 ATRT, SHH                 22
3 ATRT, To be classified    57
4 ATRT, TYR                 11

What is your summary of the results?

This module is solely based on methylation.

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza changed the title v12 ATRT subtyping v12 ATRT subtyping (11/N) Mar 2, 2023
Copy link
Collaborator

@sangeetashukla sangeetashukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is sound, the results are justified. Approving.

Copy link

@atlas4213 atlas4213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code logic looks good to me and the module ran correctly

@jharenza jharenza merged commit 719ab9b into v12-hgg Apr 29, 2023
@jharenza jharenza deleted the v12-atrt branch April 29, 2023 11:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants