V12 pathology (13/N) #335
Merged
V12 pathology (13/N) #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzgeng
approved these changes
Mar 14, 2023
added 6 commits
March 20, 2023 00:57
ewafula
approved these changes
Mar 27, 2023
v12 CI subset files (16/N)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
What was your approach?
This PR updates compile subtyping results.
What GitHub issue does your pull request address?
I added new subtypes and renamed some old (eg HGG, G35 now DHG, G35) to comply with WHO 2021 nomenclature.
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Currently, EPN SP SE B will not have an integrated dx because I requested a change in #324 to make this generally SP SE instead, but I have handled all code updates here so once rerun, we should be good. Any changes to LGG subtypes in #333 will also be auto-changed. Hopefully no code changes will be needed in the future when we rerun with the new data, but worth checking that all subtypes are being captured.
Noticed no "Ganglioneuroma" for NBL being subtyped - commented over in #330 to check this.
Is there anything that you want to discuss further?
Just double check code changes. Mostly semantic.
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
compiled subtype tables.
Reproducibility Checklist
Documentation Checklist
READMEand it is up to date.analyses/README.mdand the entry is up to date.