Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V12 NBL subtyping (9/N) #330

Merged
merged 248 commits into from
Apr 29, 2023
Merged

V12 NBL subtyping (9/N) #330

merged 248 commits into from
Apr 29, 2023

Conversation

jharenza
Copy link
Member

@jharenza jharenza commented Mar 2, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

This PR runs NBL subtyping for v12.

What was your approach?

Rerun module, no code changes.
UPDATE: just kidding. I threw in an arrange() to sort the output files so we can better track changes in future PRs.

What GitHub issue does your pull request address?

v12 data release.

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Changes seem to be expression and CN changes. CN changes seem to be data previously missing but now in v12.

Is there anything that you want to discuss further?

Does this look right?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

NBL subtype table

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza requested review from rjcorb and zzgeng March 2, 2023 02:47
@jharenza jharenza requested review from sangeetashukla and removed request for zzgeng March 2, 2023 18:35
Copy link

@rjcorb rjcorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Ubuntu and others added 27 commits April 26, 2023 01:34
@jharenza jharenza merged commit 4315f4e into v12-neuro Apr 29, 2023
@jharenza jharenza deleted the v12-nbl branch April 29, 2023 15:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants