-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v12 epn subtyping (3/N) #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code for spinal subtyping in lines 74-76 of 03-summary.Rmd
needs to be changed to:
EPN_final <- EPN_final %>%
mutate(subgroup = ifelse(disease_group == "spinal" & grepl("amplification", consensus_focal_CN_MYCN), "EPN, SP-MYCN",
ifelse(disease_group == "spinal", "EPN, SP", subgroup)))
the current ifelse
statement that specifies consensus_focal_CN_MYCN == "amplification"
is the cause of NAs
in the final subgroup column. This was probably an oversight on my part when I added the spinal classification a few months ago! Otherwise, everything looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works fine and logic is solid. Approving!
@ewafula and @rjcorb : looking at these results, I think we should update the logic for spinal ependymoma: If spinal and MYCN amp --> Saying this because as I am reviewing WHO 2021, the SP subtype is grade 3, while MPE (myxopapillary, also can be in spine) is grade I and I don't want us to mis-classify those up to SP. Can you make that change? |
v12 CI subset files (16/N)
V12 neurocytoma (8/N)
V12 chordoma (5/N)
Purpose/implementation Section
Purpose/implementation Section
What scientific question is your analysis addressing?
This PR runs EPN subtyping for v12
What was your approach?
Made the following changes:
EPN, To be classified
).What GitHub issue does your pull request address?
Part of the v12 release
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Please review scripts 01, 02, and 03 in detail to check if they capture everything accurately and logic is correct.
Is there anything that you want to discuss further?
NA
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
Updates EPN subgroups table output.
What is your summary of the results?
612 EPN bs ids (DNA = =212, RNA == 193, and Methly = = 207)
230 patients
398 tumors subtyped:
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.