Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V12 ews (6/N) #327

Merged
merged 305 commits into from
Apr 29, 2023
Merged

V12 ews (6/N) #327

merged 305 commits into from
Apr 29, 2023

Conversation

jharenza
Copy link
Member

@jharenza jharenza commented Mar 1, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

This PR runs V12 EWS.

What was your approach?

Rerun and updated code to include methylation results. Note: only for PBTA and DGD.

What GitHub issue does your pull request address?

v12 release

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Please double check logic.

Is there anything that you want to discuss further?

This module uses EWS diagnosis or EWSR1 canonical fusions to find EWS diagnoses. I also added methylation subtype of EWS to this.

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

Table of subtypes.

What is your summary of the results?

88 bs_ids subtyped as EWS
Two of these are not EWS diagnoses and need further review with pathology.

BS_ER9RMSVG - this sample has MB diagnosis. It was To be classified via MB subtyping.
BS_SRW0DH5G - this sample has Cranio diagnosis. It was To be classified via Cranio subtyping.
These may be mis-diagnoses. Will need to confirm with pathology.

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza changed the base branch from dev to v12-chordoma March 1, 2023 03:36
@ewafula ewafula requested a review from atlas4213 March 1, 2023 17:09
Copy link
Collaborator

@sangeetashukla sangeetashukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script logic looks consistent, and I agree the two samples listed in the PR need further investigation.

Copy link

@zzgeng zzgeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code works well and logic is sound.

Copy link

@atlas4213 atlas4213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me and I see all the correct info in the output file

Ubuntu and others added 27 commits April 26, 2023 01:54
@jharenza jharenza merged commit ee0aec1 into v12-chordoma Apr 29, 2023
@jharenza jharenza deleted the v12-ews branch April 29, 2023 22:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants