-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V12 ews (6/N) #327
V12 ews (6/N) #327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script logic looks consistent, and I agree the two samples listed in the PR need further investigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code works well and logic is sound.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me and I see all the correct info in the output file
v12 CI subset files (16/N)
V12 neurocytoma (8/N)
Purpose/implementation Section
What scientific question is your analysis addressing?
This PR runs V12 EWS.
What was your approach?
Rerun and updated code to include methylation results. Note: only for PBTA and DGD.
What GitHub issue does your pull request address?
v12 release
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Please double check logic.
Is there anything that you want to discuss further?
This module uses EWS diagnosis or EWSR1 canonical fusions to find EWS diagnoses. I also added methylation subtype of EWS to this.
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
Table of subtypes.
What is your summary of the results?
88 bs_ids subtyped as EWS
Two of these are not EWS diagnoses and need further review with pathology.
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.