-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V12 neurocytoma (8/N) #329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks consistent, and the results are justified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code works fine and logic is sound.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good and the results I got were the same
committed suggestion Co-authored-by: Jo Lynne Rokita <jharenza@gmail.com>
…analysis into v12-hgg
v12 CI subset files (16/N)
Purpose/implementation Section
What scientific question is your analysis addressing?
This PR adds neurocytoma subtyping, which is based only on primary site.
What was your approach?
I also added methylation results to the final table.
What GitHub issue does your pull request address?
v12 data release
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Logic, all samples there?
Is there anything that you want to discuss further?
No
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
Table of subtypes
What is your summary of the results?
17 bs_ids, 6 tumors subtyped
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.