Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V12 neurocytoma (8/N) #329

Merged
merged 264 commits into from
Apr 29, 2023
Merged

V12 neurocytoma (8/N) #329

merged 264 commits into from
Apr 29, 2023

Conversation

jharenza
Copy link
Member

@jharenza jharenza commented Mar 2, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

This PR adds neurocytoma subtyping, which is based only on primary site.

What was your approach?

I also added methylation results to the final table.

What GitHub issue does your pull request address?

v12 data release

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Logic, all samples there?

Is there anything that you want to discuss further?

No

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

Table of subtypes

What is your summary of the results?

17 bs_ids, 6 tumors subtyped

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza changed the base branch from dev to v12-emb March 2, 2023 02:24
Copy link
Collaborator

@sangeetashukla sangeetashukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks consistent, and the results are justified.

Copy link

@zzgeng zzgeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works fine and logic is sound.

Copy link

@atlas4213 atlas4213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and the results I got were the same

Ubuntu and others added 27 commits April 26, 2023 01:34
@jharenza jharenza merged commit e5d69d1 into v12-emb Apr 29, 2023
@jharenza jharenza deleted the v12-neuro branch April 29, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants