Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v12 cranio subtyping (4/N) #325

Merged
merged 343 commits into from
Apr 30, 2023
Merged

Add v12 cranio subtyping (4/N) #325

merged 343 commits into from
Apr 30, 2023

Conversation

jharenza
Copy link
Member

Purpose/implementation Section

What scientific question is your analysis addressing?

This PR adds v12 craniopharyngioma subtyping.

What was your approach?

Adds v12 cranio subtyping. Used DNA variants to determine ADAM or PAP types and if NA or To be classified, used high confidence methylation.

What GitHub issue does your pull request address?

v12 release

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

script logic

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

yes

Results

What types of results are included (e.g., table, figure)?

molecular subtype table

What is your summary of the results?

302 samples: 213 CRANIO, ADAM and 89 To be classified
102 tumors

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza changed the base branch from dev to v12-epn February 28, 2023 21:27
@jharenza
Copy link
Member Author

jharenza commented Mar 2, 2023

@zzgeng @sangeetashukla ready for re-review!

Copy link
Collaborator

@sangeetashukla sangeetashukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jharenza Now it looks all good to me. Approving.

Copy link

@zzgeng zzgeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code works well and logic is consistent.

Ubuntu and others added 27 commits April 26, 2023 02:02
@jharenza jharenza merged commit ffbbb9f into v12-epn Apr 30, 2023
@jharenza jharenza deleted the v12-cranio branch April 30, 2023 05:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants