Fixes [AB#1449967](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1449967)

#57648 fixed a race condition in computing the host analyzer references, but introduced a leak in _hostAnalyzerStateMap, wherein each new solution opened ends up creating a new entry in this map, even though the underlying set of host analyzer references doesn't change. This is due to the fact that each new SolutionState instance creates a new instance of HostDiagnosticAnalyzers, whose constructor creates a new map from analyzer references ID to the analyzer reference. This map is used as part of the key for _hostAnalyzerStateMap, leading to the leak.

This change fixes the leak by using the underlying list of host analyzer references as part of the key for _hostAnalyzerStateMap, which is reference equals across all solution instances opened in the VS session. Verified manually that after this fix, repeatedly opening and closing a solution in VS no longer leads to unbounded growth of _hostAnalyzerStateMap.

…_line_error

Inline Diagnostics Multi-Line Error Bug

This type functions correctly whether or not it is explicitly disposed.

…es as well

Remove unnecessary assertion that CancellationSeries is disposed

Add initial test for inline diagnostics tagger

Update underline-reassigned-variable to understand suppressed variables as well

…ceTransform.cs

While adjusting this code in the required-members branch I noticed the parameter is unused by the error message, so I did a small refactoring in main to clean that up.

 into convertNSWork

Remove weak-refs to the compilation (without generated docs) in the compilation tracker.

Update 'convert namespace' to only 'dedent' file contents, not format them.

Fix leak in _hostAnalyzerStateMap

…olution-as-default-for-vscode

…ntax

…tart of build

Fixes [AB#1424584](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1424584)

The primary issue is that the lingering compiler warning CS0169 from prior solution snapshot is reported in `Index.razor`, which is an Additional document, not a regular source document. Existing code in clearing build diagnostics at start of a build was only clearing diagnostics with location in source documents. Doing the same for additional documents fixes this issue.

Fixes #46785
Fixes #57983

Fix MakeFieldReadonly false positive for ref assignments

[main] Update dependencies from dotnet/arcade

Clear prior build errors for additional and analyzer config docs at s…

Improve support for TestWorkspace with source generated files

…223.1 (#58471)

[main] Update dependencies from dotnet/arcade

Fixes #53192
Currently, work coordinator only enqueues source document IDs for project analysis work items. This means we don't analyze the additional documents, which can now report standalone diagnostics through RegisterAdditionalFileAction. This PR fixes this by enqueuing project's additional document IDs and analyzer config document IDs.

Fixes #56317
#42408 handled bailing out reporting unused params for methods that only have a throw operation in its body. It missed a case where the throw might be wrapped within a conversion wrapped within a return operation, which happens when the method returns a non-void type.

Enqueue additional and analyzer config documents in WorkCoordinator

Fix unused param (IDE0060) false positive