-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip-ci][Maps][File upload] Geojson indexing and styling docs #41394
[skip-ci][Maps][File upload] Geojson indexing and styling docs #41394
Conversation
Pinging @elastic/kibana-docs |
Pinging @elastic/kibana-gis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This is a blog post more than it is reference documentation for the UX. It overlaps significantly with the getting-started doc we already have, and it contains a lot of duplicate information (e.g. setting the layer-names for all the layers. That works for a tutorial, less so for technical reference).
Maybe we can call this page Integrated example
or something along those lines. @gchaps are there other examples in Kibana where the docs show a fully worked-out example of using an app end2end? I think Timelion might have.
The "import geojson" functionality needs its own page imho, stripped from the rest of this post. That can be short, but reference docs benefit of being short and to the point. It can then link to this page for users who want more a "tutorial" style of reading through the docs.
I agree with @thomasneirynck
Happy to help with this or doing an edit. |
@gchaps Thanks for the feedback! I've made the following updates:
I left the final section mostly intact because it covers some detail on adding heatmaps that we just don't dive into in our other docs. Happy to revisit this though! |
@aaronjcaldwell Two things to fix to get the docs to build
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments. Otherwise LGTM.
…ic#41394) * Mostly complete, first pass on file upload getting started * More edits. Add supporting images * Change name to 'indexing' * Review feedback * Update integrated example text per review feedback * Rename integrated example -> data tutorial * Add back accidentally deleted Select Source image file * Review feedback * Review feedback * Move tutorial before troubleshooting * Review feedback
…ic#41394) * Mostly complete, first pass on file upload getting started * More edits. Add supporting images * Change name to 'indexing' * Review feedback * Update integrated example text per review feedback * Rename integrated example -> data tutorial * Add back accidentally deleted Select Source image file * Review feedback * Review feedback * Move tutorial before troubleshooting * Review feedback
…ic#41394) * Mostly complete, first pass on file upload getting started * More edits. Add supporting images * Change name to 'indexing' * Review feedback * Update integrated example text per review feedback * Rename integrated example -> data tutorial * Add back accidentally deleted Select Source image file * Review feedback * Review feedback * Move tutorial before troubleshooting * Review feedback
* master: (33 commits) [easy] Exclude __examples__ from coverage (elastic#45556) [DOCS] Update CCR links (elastic#44012) Use unique junit report filenames again (elastic#45897) [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856) New visualization editor Lens (elastic#36437) Sort using unix timestamp value (elastic#43162) [APM] Use POST instead of implicit GET (elastic#45903) [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274) skip flaky test (elastic#45884) set IS_PIPELINE_JOB in intake jobs (elastic#45850) [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759) [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879) [DOCS] Changes name to host (elastic#45798) [ML] Add population job wizard test (elastic#45765) [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394) remove setTimeoue for state change (elastic#45853) [Graph] Restructure folders and add readme (elastic#45782) [ML] Enhance job id error message (elastic#45349) [SIEM] Do not update state component when they did unmount (elastic#45847) [i18n] sync from 7.4 latest translations (elastic#45823) ...
… (#45898) * Mostly complete, first pass on file upload getting started * More edits. Add supporting images * Change name to 'indexing' * Review feedback * Update integrated example text per review feedback * Rename integrated example -> data tutorial * Add back accidentally deleted Select Source image file * Review feedback * Review feedback * Move tutorial before troubleshooting * Review feedback
… (#45899) * Mostly complete, first pass on file upload getting started * More edits. Add supporting images * Change name to 'indexing' * Review feedback * Update integrated example text per review feedback * Rename integrated example -> data tutorial * Add back accidentally deleted Select Source image file * Review feedback * Review feedback * Move tutorial before troubleshooting * Review feedback
… (#45900) * Mostly complete, first pass on file upload getting started * More edits. Add supporting images * Change name to 'indexing' * Review feedback * Update integrated example text per review feedback * Rename integrated example -> data tutorial * Add back accidentally deleted Select Source image file * Review feedback * Review feedback * Move tutorial before troubleshooting * Review feedback
[skip ci]
This PR adds a new section to the maps docs
Indexing & Styling GeoJSON Data
. It covers: