-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ftr/savedObjects] add simple saved object api client to ftr services #45856
Merged
spalger
merged 12 commits into
elastic:master
from
spalger:implement/ftr-saved-objects-api
Sep 17, 2019
Merged
[ftr/savedObjects] add simple saved object api client to ftr services #45856
spalger
merged 12 commits into
elastic:master
from
spalger:implement/ftr-saved-objects-api
Sep 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
Team label for Operations Team
test_ui_functional
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.4.0
v7.5.0
labels
Sep 17, 2019
Pinging @elastic/kibana-operations |
cuff-links
approved these changes
Sep 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 Build Failed |
This reverts commit 7e9a7f8.
spalger
force-pushed
the
implement/ftr-saved-objects-api
branch
from
September 17, 2019 17:24
760ba21
to
d752fd0
Compare
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 17, 2019
…tic#45856) * [ftr/savedObjects] add simple saved object api client to ftr services * fix typo * use consistent spacing * fix types and TS-ify the rest of kibanaServer service * expose server urls with better API * tweak status api response types * fix http body param name * second arg to axios post is the post data * use standardized error handling behavior * Revert "use standardized error handling behavior" This reverts commit 7e9a7f8. * revert unnecessary changes
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 17, 2019
…tic#45856) * [ftr/savedObjects] add simple saved object api client to ftr services * fix typo * use consistent spacing * fix types and TS-ify the rest of kibanaServer service * expose server urls with better API * tweak status api response types * fix http body param name * second arg to axios post is the post data * use standardized error handling behavior * Revert "use standardized error handling behavior" This reverts commit 7e9a7f8. * revert unnecessary changes
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Sep 17, 2019
* master: (33 commits) [easy] Exclude __examples__ from coverage (elastic#45556) [DOCS] Update CCR links (elastic#44012) Use unique junit report filenames again (elastic#45897) [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856) New visualization editor Lens (elastic#36437) Sort using unix timestamp value (elastic#43162) [APM] Use POST instead of implicit GET (elastic#45903) [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274) skip flaky test (elastic#45884) set IS_PIPELINE_JOB in intake jobs (elastic#45850) [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759) [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879) [DOCS] Changes name to host (elastic#45798) [ML] Add population job wizard test (elastic#45765) [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394) remove setTimeoue for state change (elastic#45853) [Graph] Restructure folders and add readme (elastic#45782) [ML] Enhance job id error message (elastic#45349) [SIEM] Do not update state component when they did unmount (elastic#45847) [i18n] sync from 7.4 latest translations (elastic#45823) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
test_ui_functional
v7.4.0
v7.5.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to aid in users interacting directly with the saved objects api from the functional tests, this extension of the kibanaServer service exposes get/create/update/delete methods for the saved objects API.