Fix disappearing test results in pipelines #45897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
v8.0.0
release_note:skip
jbudz
approved these changes
Sep 17, 2019
💚 Build Succeeded |
|
Just kicked off a couple of re-runs to see if they have consistent test numbers: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/74/ |
|
19,296 tests all 3 builds, which makes 9 consistent builds altogether. |
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Sep 17, 2019
Fix disappearing test results in pipelines
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Sep 17, 2019
Fix disappearing test results in pipelines
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Sep 17, 2019
Fix disappearing test results in pipelines
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Sep 17, 2019
Fix disappearing test results in pipelines
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Sep 17, 2019
* master: (33 commits) [easy] Exclude __examples__ from coverage (elastic#45556) [DOCS] Update CCR links (elastic#44012) Use unique junit report filenames again (elastic#45897) [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856) New visualization editor Lens (elastic#36437) Sort using unix timestamp value (elastic#43162) [APM] Use POST instead of implicit GET (elastic#45903) [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274) skip flaky test (elastic#45884) set IS_PIPELINE_JOB in intake jobs (elastic#45850) [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759) [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879) [DOCS] Changes name to host (elastic#45798) [ML] Add population job wizard test (elastic#45765) [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394) remove setTimeoue for state change (elastic#45853) [Graph] Restructure folders and add readme (elastic#45782) [ML] Enhance job id error message (elastic#45349) [SIEM] Do not update state component when they did unmount (elastic#45847) [i18n] sync from 7.4 latest translations (elastic#45823) ...
brianseeders
added a commit
that referenced
this pull request
Sep 18, 2019
brianseeders
added a commit
that referenced
this pull request
Sep 18, 2019
brianseeders
added a commit
that referenced
this pull request
Sep 18, 2019
brianseeders
added a commit
that referenced
this pull request
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45828
@spalger noticed that a test was missing from the Jenkins test result page for a build. Upon further investigation, an entire ciGroup was missing, and the number of tests changed every build by 100-200, with random suites dropping in and out.
The junit results files were being uploaded to GCS correctly, and the files contained all of the test results, so it seemed to be a problem with Jenkins processing the files.
There seems to be a bug in the junit plugin, possibly related to test result files having the same filename (even if they are in unique directories). The plugin does a lot to try to detect and drop "old" test results from previous runs, and to merge tests that have the same filename in some cases. The theory is that some of the results are dropping out.
I ran this branch on a local Jenkins 6 times, and it had the same number of test results every time.