[Uptime] Fix/issue 48 integration popup closes after refresh #45759
Conversation
shahzad31
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime |
💔 Build Failed |
There was a problem hiding this comment.
LGTM - had a few subjective comments/nit things. Aliasing the provider name is the only suggested change I'm really attached to.
Functionally this works really well!
I have subsequent refresh requests with the popover still open, so excellent work there.
This is a really clean implementation of Redux and was a great refresher for me. I think we should have an ongoing initiative to extract additional UI state as opportunities present themselves.
x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/monitor_list.tsx
Show resolved
Hide resolved
| import { rootReducer } from './reducers'; | ||
| import { rootSaga } from './sagas'; | ||
|
|
||
| const composeEnhancers = window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || compose; |
There was a problem hiding this comment.
This is something I'm unfamiliar with, so I'm sorry if this question is a little basic, but this means that __REDUX_DEVTOOLS_EXTENSION_COMPOSE__ will be undefined on window for non-dev builds? It seems like this is the recommended way to configure compose per the advanced store setup.
There was a problem hiding this comment.
Well it's checking if browser has redux dev tools extension installed, it will use compose available from extension if it is available, otherwise just compose.
...cy/plugins/uptime/public/components/functional/monitor_list/monitor_list_actions_popover.tsx
Outdated
Show resolved
Hide resolved
💔 Build Failed |
💚 Build Succeeded |
shahzad31
deleted the
fix/issue-48-integration-popup-closes-after-refresh
branch
* master: (33 commits) [easy] Exclude __examples__ from coverage (elastic#45556) [DOCS] Update CCR links (elastic#44012) Use unique junit report filenames again (elastic#45897) [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856) New visualization editor Lens (elastic#36437) Sort using unix timestamp value (elastic#43162) [APM] Use POST instead of implicit GET (elastic#45903) [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274) skip flaky test (elastic#45884) set IS_PIPELINE_JOB in intake jobs (elastic#45850) [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759) [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879) [DOCS] Changes name to host (elastic#45798) [ML] Add population job wizard test (elastic#45765) [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394) remove setTimeoue for state change (elastic#45853) [Graph] Restructure folders and add readme (elastic#45782) [ML] Enhance job id error message (elastic#45349) [SIEM] Do not update state component when they did unmount (elastic#45847) [i18n] sync from 7.4 latest translations (elastic#45823) ...
…#45759) * integrate redux into uptime app * update integrations popup handling * keep popover open after page refresh * updated unit test snaps * update unit tests * fixed types
Summary
Resolves elastic/uptime#48
In monitors list, this PR will keep integrations popover open after auto refresh happens, keep in mind if user click refresh manually, this will close the popover, since that is normal behavior.
Checklist
Testing:
This is the popover