Sort using unix timestamp value #43162

ycombinator · 2019-08-12T23:28:54Z

This PR attempts to fix the sorting for the "Last Modified" column in the Logstash Pipeline Management UI.

Pre-requisites for viewing the Logstash Pipeline Management UI

Use a Trial license.
Enable Security.

ycombinator · 2019-08-12T23:31:28Z

@justinkambic @cjcenizal It's been a while since I've touched UI code and it looks like EUI has advanced quite a bit since I was last using it. I feel like the fix I have in this PR should just work but it doesn't 😞.

So obviously there's more going on here that I can't figure out. I did notice a bunch of React proptype validation warnings (even before I made any changes for this PR), so maybe that has something to do with why this change isn't just working?

Could either of you take a look and point me in the right direction? Thanks!

elasticmachine · 2019-08-13T00:28:39Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ycombinator · 2019-08-14T11:14:10Z

Per @cjcenizal's suggestion, pinging @chandlerprall and @thompsongl for help (please see my previous comment). Thanks!

thompsongl · 2019-08-14T16:28:03Z

@ycombinator Happy to help. I don't seem to have a local setup right now that let's me see this view, but it appears that you're using sortable correctly. What data type is lastModified (Date, timestamp, number, etc.)?

ycombinator · 2019-08-14T16:30:41Z

Thanks @thompsongl!

What data type is lastModified (Date, timestamp, number, etc.)?

It's a moment object.

thompsongl · 2019-08-14T16:46:26Z

Is it possible to use the last_modified field directly and not have to go through Moment?

Really, I'm just trying to discern whether lastModified.valueOf() returns a value that can be sorted simply.

ycombinator · 2019-08-14T21:19:47Z

Really, I'm just trying to discern whether lastModified.valueOf() returns a value that can be sorted simply.

Yes, it is. It returns the milliseconds-since-epoch timestamp, so it's an integer.

thompsongl · 2019-08-14T23:42:24Z

Ok. I'll have to get a local setup that will let me debug. Replicating that component config in a more basic environment works as I'd expect it to.

justinkambic · 2019-08-15T14:57:59Z

FWIW I went so far as to create a contrived table/data on this page and was unable to produce the desired behavior. I can provide the code if it's helpful to anyone.

thompsongl · 2019-08-16T18:26:05Z

Might be helpful, but, I don't think EuiInMemoryTable is the cause of the problem.

This is using the config and new sortable function in this PR and the dates are moment objects.

justinkambic · 2019-09-13T13:32:13Z

I've added d9b2ae5 and 1d9d0ae to fix the sorting problem and update the branch with newer master, respectively. @chandlerprall do you think you'd be ok doing a review for us since @ycombinator and I have both committed at this point?

ycombinator

I played around with the latest changes and they LGTM. I'm able to sort all columns, including the Last Modified one, as expected. Thanks @justinkambic and @chandlerprall!

@chandlerprall, we'd still like your review on this for reasons @justinkambic mentioned in his comment.

elasticmachine · 2019-09-13T15:00:11Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-13T16:13:49Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

ycombinator · 2019-09-17T08:27:03Z

@elasticmachine merge upstream

elasticmachine · 2019-09-17T10:10:17Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

chandlerprall

Changes LGTM

justinkambic

I made sure that localized headings translated alright.

LGTM too!

* Sort using unix timestamp value * Extract internationalization from react components to function calls. * Updating Jest snapshots for pipelines table component

* master: (33 commits) [easy] Exclude __examples__ from coverage (elastic#45556) [DOCS] Update CCR links (elastic#44012) Use unique junit report filenames again (elastic#45897) [ftr/savedObjects] add simple saved object api client to ftr s… (elastic#45856) New visualization editor Lens (elastic#36437) Sort using unix timestamp value (elastic#43162) [APM] Use POST instead of implicit GET (elastic#45903) [Canvas] Converting workpad header components to typescript and adding i18n (elastic#45274) skip flaky test (elastic#45884) set IS_PIPELINE_JOB in intake jobs (elastic#45850) [Uptime] Fix/issue 48 integration popup closes after refresh (elastic#45759) [Logs UI] Support zoom by brushing in the log rate chart (elastic#45879) [DOCS] Changes name to host (elastic#45798) [ML] Add population job wizard test (elastic#45765) [skip-ci][Maps][File upload] Geojson indexing and styling docs (elastic#41394) remove setTimeoue for state change (elastic#45853) [Graph] Restructure folders and add readme (elastic#45782) [ML] Enhance job id error message (elastic#45349) [SIEM] Do not update state component when they did unmount (elastic#45847) [i18n] sync from 7.4 latest translations (elastic#45823) ...

* Sort using unix timestamp value * Extract internationalization from react components to function calls. * Updating Jest snapshots for pipelines table component

Sort using unix timestamp value

f319091

ycombinator requested review from cjcenizal and justinkambic August 12, 2019 23:28

ycombinator added Feature:Logstash Pipelines Logstash Pipeline UI related WIP Work in progress labels Aug 12, 2019

cjcenizal removed their request for review August 13, 2019 17:56

justinkambic added 2 commits September 13, 2019 09:28

Extract internationalization from react components to function calls.

d9b2ae5

Merge branch 'master' into x-pack/mgmt/ls/pipeline-list/sorting

1d9d0ae

justinkambic added release_note:fix v7.5.0 v8.0.0 labels Sep 13, 2019

ycombinator changed the title ~~[WIP] Sort using unix timestamp value~~ Sort using unix timestamp value Sep 13, 2019

ycombinator removed the WIP Work in progress label Sep 13, 2019

ycombinator commented Sep 13, 2019

View reviewed changes

ycombinator added backport pending v7.4.1 labels Sep 13, 2019

Updating Jest snapshots for pipelines table component

cba0e3b

justinkambic mentioned this pull request Sep 13, 2019

[Logstash] Remove formatted message component in favor of i18n translate function #45658

Merged

7 tasks

Merge branch 'master' into x-pack/mgmt/ls/pipeline-list/sorting

a4e2250

chandlerprall approved these changes Sep 17, 2019

View reviewed changes

justinkambic approved these changes Sep 17, 2019

View reviewed changes

ycombinator merged commit c1d6a47 into elastic:master Sep 17, 2019

This was referenced Sep 17, 2019

[7.x] Sort using unix timestamp value (#43162) #45933

Merged

[7.4] Sort using unix timestamp value (#43162) #45934

Merged

ycombinator added a commit that referenced this pull request Sep 19, 2019

Sort using unix timestamp value (#43162) (#45933)

c12e529

* Sort using unix timestamp value * Extract internationalization from react components to function calls. * Updating Jest snapshots for pipelines table component

ycombinator added a commit that referenced this pull request Sep 19, 2019

Sort using unix timestamp value (#43162) (#45934)

fb1d1fa

* Sort using unix timestamp value * Extract internationalization from react components to function calls. * Updating Jest snapshots for pipelines table component

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sort using unix timestamp value #43162

Sort using unix timestamp value #43162

ycombinator commented Aug 12, 2019 •

edited

Loading

ycombinator commented Aug 12, 2019 •

edited

Loading

elasticmachine commented Aug 13, 2019

ycombinator commented Aug 14, 2019

thompsongl commented Aug 14, 2019

ycombinator commented Aug 14, 2019

thompsongl commented Aug 14, 2019 •

edited

Loading

ycombinator commented Aug 14, 2019

thompsongl commented Aug 14, 2019

justinkambic commented Aug 15, 2019

thompsongl commented Aug 16, 2019

justinkambic commented Sep 13, 2019

ycombinator left a comment •

edited

Loading

elasticmachine commented Sep 13, 2019

elasticmachine commented Sep 13, 2019

ycombinator commented Sep 17, 2019

elasticmachine commented Sep 17, 2019

chandlerprall left a comment

justinkambic left a comment

Sort using unix timestamp value #43162

Sort using unix timestamp value #43162

Conversation

ycombinator commented Aug 12, 2019 • edited Loading

Pre-requisites for viewing the Logstash Pipeline Management UI

ycombinator commented Aug 12, 2019 • edited Loading

elasticmachine commented Aug 13, 2019

💔 Build Failed

ycombinator commented Aug 14, 2019

thompsongl commented Aug 14, 2019

ycombinator commented Aug 14, 2019

thompsongl commented Aug 14, 2019 • edited Loading

ycombinator commented Aug 14, 2019

thompsongl commented Aug 14, 2019

justinkambic commented Aug 15, 2019

thompsongl commented Aug 16, 2019

justinkambic commented Sep 13, 2019

ycombinator left a comment • edited Loading

Choose a reason for hiding this comment

elasticmachine commented Sep 13, 2019

💔 Build Failed

elasticmachine commented Sep 13, 2019

💚 Build Succeeded

ycombinator commented Sep 17, 2019

elasticmachine commented Sep 17, 2019

💚 Build Succeeded

chandlerprall left a comment

Choose a reason for hiding this comment

justinkambic left a comment

Choose a reason for hiding this comment

ycombinator commented Aug 12, 2019 •

edited

Loading

ycombinator commented Aug 12, 2019 •

edited

Loading

thompsongl commented Aug 14, 2019 •

edited

Loading

ycombinator left a comment •

edited

Loading