-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating from generate-groups.sh to kube_codegen.sh #3722
Conversation
Build Succeeded 👏 Build Id: e48cd1db-5e3f-4e59-8078-b169c98aa3a3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
The |
Provisional LGTM, will approve when I see that |
Build Failed 😱 Build Id: e3fb8ffe-0e28-4346-9071-fbc287647d7c To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Build Failed 😱 Build Id: af3479a5-c48f-4419-a0c5-4d465e84aa2b To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
This reverts commit 5902e23.
Build Failed 😱 Build Id: 5a15b4f5-40c1-401a-b7a1-b01b30172571 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 2fe5cc1f-5781-45d4-8bcd-d507ac66f2b0 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: da286508-4fd7-452f-b3fa-fe6595e9ff03 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 34ba9772-8305-4913-81a3-b59c2381a117 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 8a1afead-68dc-41a4-b222-87d34e3c82db To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 0013606b-d348-4913-8ba7-73368dae3ca2 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
build/build-image/gen-crd-client.sh
Outdated
echo "Checking if the tag v0.30.0-beta.0 exists..." | ||
if git show-ref --tags | grep -q "refs/tags/v0.30.0-beta.0"; then | ||
echo "Tag found. Checking out v0.30.0-beta.0..." | ||
git checkout v0.30.0-beta.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of doing all this, just do this:
- change line 63 of
build/build-image/Dockerfile
:- copy and paste the old line so we have it around for when we revert this, comment out the copy
- Instead of
-b kubernetes-${KUBERNETES_VER}
, just do-b v0.30.0-beta.0
- Leave a note at line 53 that whenever we bump k8s versions next, consider bumping the pinned version. For the 1.29 bump we may just move code-gen to the GA'd v1.30 tag, but once we bump to 1.30, we should stop pinning it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the necessary changes to the build/build-image/Dockerfile
and refined the gen-crd-client.sh
script. Also, I did not bump the ForceUpdate in the Dockerfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly a nit about which layer the tag is at but LGTM otherwise. The diff below is tiny.
ETA: It looks like the build failure was a unit test flake, too.
Build Succeeded 👏 Build Id: 364b4613-bfa5-4340-9c2f-99555de5b1d9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Minor edits to the Dockerfile
Build Succeeded 👏 Build Id: e57b6439-b1a9-448c-aebc-246514e7d2e1 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://github.com/googleforgames/agones)) | minor | `1.39.0` -> `1.40.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.40.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1400-2024-04-23) [Compare Source](https://github.com/googleforgames/agones/compare/v1.39.0...v1.40.0) [Full Changelog](https://github.com/googleforgames/agones/compare/v1.39.0...v1.40.0) **Breaking changes:** - Counters and Lists: Remove Bool Returns by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3738 **Implemented enhancements:** - Leader Election in Custom Controller by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3696 - Migrating from generate-groups.sh to kube_codegen.sh by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3722 - Move GKEAutopilotExtendedDurationPods to Alpha in 1.28+ by [@​zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3729 - Move DisableResyncOnSDKServer to Beta by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3732 - Counters & Lists landing page and doc improvements by [@​markmandel](https://github.com/markmandel) in [googleforgames/agones#3649 - Graduate FleetAllocationOverflow to Stable by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3733 - Adds Counters and Lists to CSharp SDK by [@​igooch](https://github.com/igooch) in [googleforgames/agones#3581 - Feat/counter and list defaulting order to ascending by [@​lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3734 - Add handling for StatusAddresses in GameServerStatus for the Unity SDK by [@​charlesvien](https://github.com/charlesvien) in [googleforgames/agones#3739 - Feat(gameservers): Shared pod IPs with GameServer Addresses by [@​lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3764 - Be prescriptive about rotating regions when updating Kubernetes versions by [@​zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3716 - Fix ensure-e2e-infra-state-bucket by [@​zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3719 - Create Performance Cluster 1.28 by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3720 - Optimise GameServer Sub-Controller Queues by [@​markmandel](https://github.com/markmandel) in [googleforgames/agones#3781 **Fixed bugs:** - Counters & Lists: Consolidate `priorities` sorting by [@​markmandel](https://github.com/markmandel) in [googleforgames/agones#3690 - Fix(Counter & Lists): Add validation for `priorities` by [@​lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3714 - fix: [#​3607](https://github.com/googleforgames/agones/issues/3607) Metrics data loss in K8S controller by [@​alvin-7](https://github.com/alvin-7) in [googleforgames/agones#3692 - Deflake GameServerAllocationDuringMultipleAllocationClients by allowing errors by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3750 **Security fixes:** - Bump protobufjs from 7.2.4 to 7.2.6 in /sdks/nodejs by [@​dependabot](https://github.com/dependabot) in [googleforgames/agones#3755 - Bump golang.org/x/net from 0.19.0 to 0.23.0 by [@​zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3793 **Other:** - Flaky: TestGameServerCreationAfterDeletingOneExtensionsPod by [@​markmandel](https://github.com/markmandel) in [googleforgames/agones#3699 - Prep for release v1.40.0 by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3700 - Bumps cpp-simple Image and Refactoring Example Makefiles by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3695 - Upgrade Protobuf to 1.33.0 by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3711 - Modify Script for Makefile Version Updates in Examples Directory by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3712 - Adds simple genai server example documentation to the Agones site by [@​igooch](https://github.com/igooch) in [googleforgames/agones#3713 - Update Supported Kubernetes to 1.27, 1.28, 1.29 by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3654 - fix: typo in docs by [@​qhyun2](https://github.com/qhyun2) in [googleforgames/agones#3723 - Tweak: Setting up the Game Server by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3717 - Docs: gke.md - spelling by [@​daniellee](https://github.com/daniellee) in [googleforgames/agones#3740 - Aesthetic rearrangement of cloudbuild.yaml by [@​zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3741 - Docs: Make hitting <enter> on connection explicit by [@​markmandel](https://github.com/markmandel) in [googleforgames/agones#3743 - CI: Don't check Unreal Link by [@​markmandel](https://github.com/markmandel) in [googleforgames/agones#3745 - New recommendation for multi-cluster allocation by [@​markmandel](https://github.com/markmandel) in [googleforgames/agones#3744 - Custom Controller Example Page on Agones Website by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3725 - Add Nitrado logo by [@​towolf](https://github.com/towolf) in [googleforgames/agones#3753 - Remove unnecessary args from e2e-test-cloudbuild by [@​zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3754 - Update Allocation from Fleet Documentation by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3761 - Transform Lint Warnings into Errors by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3756 - Update Canary Testing Documentation by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3760 - Supertuxkart Example on Agones Site by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3728 - Xonotic Example on Agones Site by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3742 - nit documentation fix in kind cluster section when building Agones by [@​vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3770 - Merged steps inside documentation about webhook certificate creation by [@​vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3768 - Example Images: Increment Tags by [@​Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3796 - Update simple game server example documentation by [@​vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3776 **New Contributors:** - [@​lacroixthomas](https://github.com/lacroixthomas) made their first contribution in [googleforgames/agones#3714 - [@​daniellee](https://github.com/daniellee) made their first contribution in [googleforgames/agones#3740 - [@​charlesvien](https://github.com/charlesvien) made their first contribution in [googleforgames/agones#3739 - [@​vicentefb](https://github.com/vicentefb) made their first contribution in [googleforgames/agones#3770 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTYuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM1Ni4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
What type of PR is this?
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #3659
Special notes for your reviewer: