Add handling for StatusAddresses in GameServerStatus for the Unity SDK #3739

charlesvien · 2024-03-28T01:20:05Z

/kind feature

What this PR does / Why we need it:
This PR introduces the functionality to fetch the list of addresses associated with a game server object. This is crucial for developers who require access to both IP addresses and DNS names for their game servers. Given the current structure, where the "address" field primarily accommodates ExternalDNS, there's a notable absence of a straightforward method to obtain the ExternalIP.

Special notes for your reviewer:
I have conducted thorough testing of this feature within our Agones Kubernetes cluster, and it has performed as expected, effectively addressing the current limitation.

google-cla · 2024-03-28T01:20:09Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

agones-bot · 2024-03-28T01:39:38Z

Build Failed 😱

Build Id: 518c7851-7d2d-412b-b380-0cd25b8fcde4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-03-28T04:42:55Z

Build Succeeded 👏

Build Id: f6c9821a-076d-469c-9032-a8176ea384e8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://36ea4e7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3739/head:pr_3739 && git checkout pr_3739
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-36ea4e7-amd64

agones-bot · 2024-03-29T03:27:29Z

Build Succeeded 👏

Build Id: 67190aa3-5c07-4ac7-b255-1a9b594dfebb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://919148d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3739/head:pr_3739 && git checkout pr_3739
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-919148d-amd64

zmerlynn · 2024-03-29T23:23:49Z

Thank you for the submission! We don't have a Unity SDK expert in the core maintainers right now, so tagging @kingshijie and @cadfoot as the most recent commits - would one of you kindly review this PR? If neither reply in a few days, I will.

agones-bot · 2024-03-30T19:40:46Z

Build Succeeded 👏

Build Id: f16e1f32-f6a5-439f-87c6-0a6ec9eb736e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://8e994e2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3739/head:pr_3739 && git checkout pr_3739
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-8e994e2-amd64

agones-bot · 2024-04-02T22:45:59Z

Build Succeeded 👏

Build Id: d1c249ac-32db-4349-b8e0-b0d53ac6c95d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://a3f0074-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3739/head:pr_3739 && git checkout pr_3739
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-a3f0074-amd64

agones-bot · 2024-04-04T18:28:41Z

Build Failed 😱

Build Id: f6ee59ba-01b0-4f65-bbb2-380da5161280

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-04T19:38:10Z

Build Failed 😱

Build Id: 5b6a7566-1b9f-4d11-8be5-2dc25f3564d9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2024-04-05T16:27:26Z

Seen this a few times on bunch on Autopilot 1.29

time="2024-04-04 19:17:45.971" level=info msg="Dumping Events:" fleet=simple-fleet-1.08g745 kind= test=TestAllocatorWithDeprecatedRequired
time="2024-04-04 19:17:46.138" level=info msg="Event!" fleet=simple-fleet-1.08g745 lastTimestamp="2024-04-04 19:07:46 +0000 UTC" message="Created GameServerSet simple-fleet-1.08g745-vftp7" reason=CreatingGameServerSet test=TestAllocatorWithDeprecatedRequired type=Normal
    framework.go:346: 
        	Error Trace:	/go/src/agones.dev/agones/test/e2e/framework/framework.go:346
        	            				/go/src/agones.dev/agones/test/e2e/allocator_test.go:77
        	Error:      	Received unexpected error:
        	            	context deadline exceeded
        	Test:       	TestAllocatorWithDeprecatedRequired
        	Messages:   	error waiting for fleet condition on fleet: simple-fleet-1.08g745
--- FAIL: TestAllocatorWithDeprecatedRequired (602.67s)

@charlesvien because you are using an org rather than a personal repo, I can't upgrade this to main. But I will kickoff the test again.

If you ever need to kickoff a test again, you can always git commit --amend --date=now and force push the commit up, and things will kick off.

agones-bot · 2024-04-05T16:59:56Z

Build Failed 😱

Build Id: 48861c00-8677-4a2c-8172-061fdd3ddd4b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2024-04-05T20:55:45Z

I'm hoping we've sorted some of the CI issues, so if you could rebase against main and push up, it should auto-merge once finished with tests.

agones-bot · 2024-04-06T02:19:07Z

Build Succeeded 👏

Build Id: b433a91-4a9a-47fa-b979-3e5f757ab52d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://8413749-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3739/head:pr_3739 && git checkout pr_3739
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-8413749-amd64

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://github.com/googleforgames/agones)) | minor | `1.39.0` -> `1.40.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.40.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1400-2024-04-23) [Compare Source](https://github.com/googleforgames/agones/compare/v1.39.0...v1.40.0) [Full Changelog](https://github.com/googleforgames/agones/compare/v1.39.0...v1.40.0) **Breaking changes:** - Counters and Lists: Remove Bool Returns by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3738 **Implemented enhancements:** - Leader Election in Custom Controller by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3696 - Migrating from generate-groups.sh to kube_codegen.sh by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3722 - Move GKEAutopilotExtendedDurationPods to Alpha in 1.28+ by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3729 - Move DisableResyncOnSDKServer to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3732 - Counters & Lists landing page and doc improvements by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3649 - Graduate FleetAllocationOverflow to Stable by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3733 - Adds Counters and Lists to CSharp SDK by [@igooch](https://github.com/igooch) in [googleforgames/agones#3581 - Feat/counter and list defaulting order to ascending by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3734 - Add handling for StatusAddresses in GameServerStatus for the Unity SDK by [@charlesvien](https://github.com/charlesvien) in [googleforgames/agones#3739 - Feat(gameservers): Shared pod IPs with GameServer Addresses by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3764 - Be prescriptive about rotating regions when updating Kubernetes versions by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3716 - Fix ensure-e2e-infra-state-bucket by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3719 - Create Performance Cluster 1.28 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3720 - Optimise GameServer Sub-Controller Queues by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3781 **Fixed bugs:** - Counters & Lists: Consolidate `priorities` sorting by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3690 - Fix(Counter & Lists): Add validation for `priorities` by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3714 - fix: [#3607](https://github.com/googleforgames/agones/issues/3607) Metrics data loss in K8S controller by [@alvin-7](https://github.com/alvin-7) in [googleforgames/agones#3692 - Deflake GameServerAllocationDuringMultipleAllocationClients by allowing errors by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3750 **Security fixes:** - Bump protobufjs from 7.2.4 to 7.2.6 in /sdks/nodejs by [@dependabot](https://github.com/dependabot) in [googleforgames/agones#3755 - Bump golang.org/x/net from 0.19.0 to 0.23.0 by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3793 **Other:** - Flaky: TestGameServerCreationAfterDeletingOneExtensionsPod by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3699 - Prep for release v1.40.0 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3700 - Bumps cpp-simple Image and Refactoring Example Makefiles by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3695 - Upgrade Protobuf to 1.33.0 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3711 - Modify Script for Makefile Version Updates in Examples Directory by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3712 - Adds simple genai server example documentation to the Agones site by [@igooch](https://github.com/igooch) in [googleforgames/agones#3713 - Update Supported Kubernetes to 1.27, 1.28, 1.29 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3654 - fix: typo in docs by [@qhyun2](https://github.com/qhyun2) in [googleforgames/agones#3723 - Tweak: Setting up the Game Server by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3717 - Docs: gke.md - spelling by [@daniellee](https://github.com/daniellee) in [googleforgames/agones#3740 - Aesthetic rearrangement of cloudbuild.yaml by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3741 - Docs: Make hitting <enter> on connection explicit by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3743 - CI: Don't check Unreal Link by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3745 - New recommendation for multi-cluster allocation by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3744 - Custom Controller Example Page on Agones Website by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3725 - Add Nitrado logo by [@towolf](https://github.com/towolf) in [googleforgames/agones#3753 - Remove unnecessary args from e2e-test-cloudbuild by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3754 - Update Allocation from Fleet Documentation by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3761 - Transform Lint Warnings into Errors by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3756 - Update Canary Testing Documentation by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3760 - Supertuxkart Example on Agones Site by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3728 - Xonotic Example on Agones Site by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3742 - nit documentation fix in kind cluster section when building Agones by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3770 - Merged steps inside documentation about webhook certificate creation by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3768 - Example Images: Increment Tags by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3796 - Update simple game server example documentation by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3776 **New Contributors:** - [@lacroixthomas](https://github.com/lacroixthomas) made their first contribution in [googleforgames/agones#3714 - [@daniellee](https://github.com/daniellee) made their first contribution in [googleforgames/agones#3740 - [@charlesvien](https://github.com/charlesvien) made their first contribution in [googleforgames/agones#3739 - [@vicentefb](https://github.com/vicentefb) made their first contribution in [googleforgames/agones#3770 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

github-actions bot added kind/feature New features for Agones size/M labels Mar 28, 2024

zmerlynn approved these changes Apr 4, 2024

View reviewed changes

markmandel enabled auto-merge (squash) April 5, 2024 16:28

Add handling for StatusAddresses in GameServerStatus for the Unity SDK

8413749

auto-merge was automatically disabled April 5, 2024 23:40
Head branch was pushed to by a user without write access

charlesvien force-pushed the main branch from 19b10cf to 8413749 Compare April 5, 2024 23:40

markmandel merged commit 8c56546 into googleforgames:main Apr 6, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add handling for StatusAddresses in GameServerStatus for the Unity SDK #3739

Add handling for StatusAddresses in GameServerStatus for the Unity SDK #3739

charlesvien commented Mar 28, 2024 •

edited

Loading

google-cla bot commented Mar 28, 2024

agones-bot commented Mar 28, 2024

agones-bot commented Mar 28, 2024

agones-bot commented Mar 29, 2024

zmerlynn commented Mar 29, 2024 •

edited

Loading

agones-bot commented Mar 30, 2024

agones-bot commented Apr 2, 2024

agones-bot commented Apr 4, 2024

agones-bot commented Apr 4, 2024

markmandel commented Apr 5, 2024

agones-bot commented Apr 5, 2024

markmandel commented Apr 5, 2024

agones-bot commented Apr 6, 2024

Add handling for StatusAddresses in GameServerStatus for the Unity SDK #3739

Add handling for StatusAddresses in GameServerStatus for the Unity SDK #3739

Conversation

charlesvien commented Mar 28, 2024 • edited Loading

google-cla bot commented Mar 28, 2024

agones-bot commented Mar 28, 2024

agones-bot commented Mar 28, 2024

agones-bot commented Mar 29, 2024

zmerlynn commented Mar 29, 2024 • edited Loading

agones-bot commented Mar 30, 2024

agones-bot commented Apr 2, 2024

agones-bot commented Apr 4, 2024

agones-bot commented Apr 4, 2024

markmandel commented Apr 5, 2024

agones-bot commented Apr 5, 2024

markmandel commented Apr 5, 2024

agones-bot commented Apr 6, 2024

charlesvien commented Mar 28, 2024 •

edited

Loading

zmerlynn commented Mar 29, 2024 •

edited

Loading