service discovery: add initial MVP implementation #12368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
service discovery: add state store functionality
events: add state objects and logic for service registrations.
service discovery: add RPC endpoints and FSM logic
service discovery: add HTTP endpoints and sdk wrapper
jobspec: add service block provider parameter
config: add native service discovery admin boolean parameter.
service discovery: add config boolean parameter and fingerprinting
This commit performs refactoring to pull out common service registration objects into a new `client/serviceregistration` package. This new package will form the base point for all client specific service registration functionality. The Consul specific implementation is not moved as it also includes non-service registration implementations; this reduces the blast radius of the changes as well.
client: refactor common service registration objects from Consul.
client: add Nomad service registration implementation.
client: hookup service wrapper for use in clients
When a node fails its heart beating a number of actions are taken to ensure state is cleaned. Service registrations a loosely tied to nodes, therefore we should remove these from state when a node is considered terminally down.
cli: add service commands for list, info, and delete.
The service registration client name was used to provide a distinction between the service block and the service client. This however creates new wording to understand and does not match the CLI, therefore this change fixes that so we have a Services client. Consul specific objects within the service file have been moved to the consul location to create a clearer separation.
jrasell
force-pushed
the
f-1.3-boogie-nights
branch
from
7db3236
to
2d8b370
Compare
jrasell
added a commit
that referenced
this pull request
Apr 6, 2022
jrasell
added a commit
that referenced
this pull request
Apr 6, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the MVP work for Nomad service discovery, whereby Nomad services can specify a provider parameter and become registered within Nomad state. It includes state, RPC, HTTP API, CLI and client work. It does not currently include template functionality which is being worked on currently.
All commits have been reviewed previously except the final two. These two commits perform small refactoring to accommodate CI changes on main and a naming change discussed internally.
I was planning on merging this without squashing to keep some history of the development rather than a single commit which contains +10k changes. If there are thoughts on why we should squash then I am happy to alter the approach.
The failing Nomad RPC test is not a result of changes here, and is fixed within #12364