This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
Extensions #37
Open
Extensions #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
We have done the work to allow attributes to be added to navigation items, which means we can now use the macro instead of plain HTML
Update GOV.UK Frontend to v2.1.0
Release v8.1.0
In GOV.UK Frontend components no longer have separate print stylesheet; print styles are built into the component partials By setting media to all we allow those styles to apply in print situations.
Set stylesheet media to "all" to allow print styles
Fix About link in nav
This builds on the work done in alphagov#588. Previously the ‘clear data’ feature used two GET requests – one to display the confirmation screen, and a second to actually clear the session data. This is not ideal because GET requests are meant to be nullipotent (to have no side effects), and links from the docs part of the kit were still pointing to the old URL, which bypassed the confirmation screen. This adds a form to the confirmation screen which POSTs to itself (/prototype-admin/clear-data), and changes the old data-clearing route to match.
Use form POST request when clearing session data
Update to v2.2.0
Make it available in the app views
Update GOV.UK Frontend to v2.2.0
Release v8.2.0
Required config to enable review apps on Heroku
Heroku review app config
The site referred to docs/views/examples, which was incorrect.
Fix path for page templates in tutorials-and-examples
The previous instructions were a very bare-bones draft which assumed a lot of context. This commit attempts to rewrite them for someone without knowledge of what Notify is, or how an API works. Hopefully this is enough so that someone who is confident using the prototype kit can integrate their prototype with Notify.
Replace ‘check answers’ pattern with updated code
Release 8.5.0
Update GOV.UK Frontend to version 2.6.0
Release 8.6.0
Add guidance for CSS, JavaScript and images
Update the Travis config to build on both macOS and Windows as well as Linux, and against both Node 8 and LTS (currently 10) Travis combines the OS and Node JS versions, so both Node versions will be tested on every operating system. There is a known issue with Windows builds on Travis where the build fails if you have encrypted variables. Splitting the deploy step (which is the step that requires the encrypted variable) into its own job means that the encrypted variables are not present when testing on Windows.
Each stage runs one after another, but will only proceed if all jobs in the previous stage have passed successfully, so this check is not necessary.
In order to make the tests pass on Windows, we need to remove any encrypted variables from the Travis repository settings and specify them in the repo config file instead. This adds a new deploy key encrypted using an encrypted env variable DEPLOY_KEY and updates the release script to use it. Co-authored-by: Hanna Laakso <hanna.laakso@digital.cabinet-office.gov.uk>
The SSH command will always exit with an error code, even if it connects successfully, because GitHub does not provide shell access. We could allow this to fail, but we're not sure it's that useful, so let's just remove it for now.
Test on Windows and macOS; node 8 and 10 (LTS)
Update docs and package.json to Node 10 LTS
…stem As a developer/Designer, I would like to use my departments frontend system alongside govuk-frontend. So that I can prototype using the same components and patterns that will be used in production. This should not be a breaking change for any existing kits. This is a soft release where GOV.UK Design System team would like HMRC to test before releasing this more widely. A proper release with documentation etc. will be done once this has been battle tested with HMRC. Co-authored-by: Alistair Laing <alistair.laing@digital.cabinet-office.gov.uk> Co-authored-by: Hanna Laakso <hanna.laakso@digital.cabinet-office.gov.uk>
This is so we can pick up govuk-prototype-kit.config.json file which was added to govuk-frontend to support this extensions feature.
nataliecarey
force-pushed
the
extensions
branch
from
fa84ffd to
f933ab7
Compare
Extensions Framework
Release 8.7.0
Updates release docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.