Start adding full calendar #7356

ahuang11 · 2024-10-03T23:34:03Z

Focusing only on the view options for now

Not sure how to handle interactions
https://fullcalendar.io/docs/date-clicking-selecting

docs
tests
fix re-rendering

import panel as pn

pn.extension()

cal = pn.widgets.Calendar(sizing_mode="stretch_both")

cal.add_event("2024-10-01 12:00")
cal.show()

holovizbot · 2024-10-04T01:34:33Z

This pull request has been mentioned on HoloViz Discourse. There might be relevant details there:

https://discourse.holoviz.org/t/how-to-use-jscomponent-with-fullcalendar/8306/11

panel/widgets/calendar.py

codecov · 2024-10-04T01:45:44Z

Codecov Report

Attention: Patch coverage is 65.75342% with 25 lines in your changes missing coverage. Please review.

Project coverage is 82.22%. Comparing base (87ef019) to head (2ce0c19).

Files with missing lines	Patch %	Lines
panel/widgets/calendar.py	65.27%	25 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7356      +/-   ##
==========================================
- Coverage   82.23%   82.22%   -0.02%     
==========================================
  Files         337      338       +1     
  Lines       50634    50707      +73     
==========================================
+ Hits        41641    41692      +51     
- Misses       8993     9015      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…#7376)

* Fix type hint for oauth_guest_endpoints * fix pre-commit

* Ensure that autoreload records modules to watch before startup * Apply suggestions from code review * Apply suggestions from code review * Add test * Fix test

* Various fixes for custom component compilation * Apply suggestions from code review --------- Co-authored-by: Philipp Rudiger <philipp.rudiger@blackstone.com>

#7364)

* limit tabulator height with max height * use maxHeight config * reverse logic

Replaced `panel` with `panels`

* Only attempt loading ESM bundles from URL when running server * Handle pyodide

* Add CHANGELOG for 1.5.3 * Update CHANGELOG

Bumps [django](https://github.com/django/django) from 3.2.25 to 4.2.16. - [Commits](django/django@3.2.25...4.2.16) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

ahuang11 · 2024-10-21T15:53:53Z

Can this be compiled with the plugins dynamically loaded @philippjfr

MarcSkovMadsen · 2024-10-21T17:15:42Z

If loading plugins dynamically means loading modules dynamically then yes. See https://dmitripavlutin.com/ecmascript-modules-dynamic-import/.

MarcSkovMadsen · 2024-10-21T17:18:55Z

panel/models/fullcalendar.js

@@ -0,0 +1,104 @@
+import {Calendar} from "@fullcalendar/core"


To be honest I don't believe this component is "core" Panel. Optimally this would be in a separate package like panel-mermaid.

It increases the complexity of the Panel project. And the download size which is important in for example Pyodide.

If loading plugins dynamically means loading modules dynamically then

I meant part of the compilation.

Is 136 KBs significant?
https://bundlephobia.com/package/@fullcalendar/core@6.1.15

Its not the js I'm "worried" about. Its the panel python package.

I'm also leaning towards splitting this out. That said:

And the download size which is important in for example Pyodide

Pyodide bundles do not and will not ship with the JS bundles.

I guess many people will get Panel directly from PyPI in pyodide. We probably should finally figure out how to split that package, so panel/dist is shipped separately. For backward compatibility we'd probably have to create a new package called panel-core and then make panel a metapackage that depends on panel-core and additionally ships panel/dist.

ahuang11 and others added 3 commits October 3, 2024 16:34

start adding full calendar

019f015

add many view parrams

458f8ed

lint

8687fe1

ahuang11 commented Oct 4, 2024

View reviewed changes

panel/widgets/calendar.py Show resolved Hide resolved

philippjfr and others added 24 commits October 18, 2024 16:17

Update CHANGELOG

47851cc

Bump panel.js version to 1.5.2

d1a754f

chore: Update pre-commit (#7366)

ca45454

Corrected styles in doc (#7371)

827fe64

Prevent pipeline network plot from linking with other plots (#7372)

2309bfe

docs: Update nested tabulator example (#7379)

63f2d8d

Bump django from 3.2.25 to 4.2.16 in /examples/apps/django_multi_apps (…

417e325

…#7376)

ci: Update pixi channels (#7378)

3260b7e

Fix oauth guest endpoint (#7385)

a172064

Fix type hint for oauth_guest_endpoints (#7383)

ef5d0be

* Fix type hint for oauth_guest_endpoints * fix pre-commit

fix import map typing (#7392)

2986f18

Ensure that autoreload records modules to watch before startup (#7399)

ae110a5

* Ensure that autoreload records modules to watch before startup * Apply suggestions from code review * Apply suggestions from code review * Add test * Fix test

Various fixes for custom component compilation (#7381)

2454da9

* Various fixes for custom component compilation * Apply suggestions from code review --------- Co-authored-by: Philipp Rudiger <philipp.rudiger@blackstone.com>

Address issues with Tabulator embed_content and optimize row expansion (

c69b81d

#7364)

Update components_overview.md with text fixes (#7335)

8bb20b8

Prevent tabulator from overlapping when max_height is set (#7403)

2b981da

* limit tabulator height with max height * use maxHeight config * reverse logic

docs: fix typo in panel.io.server docstring (#7405)

e01e53e

Replaced `panel` with `panels`

Sync dark mode on browser_info object (#7382)

0f3f98d

Allow loading ESM bundles from URL (#7410)

6c3a9ce

Only attempt loading ESM bundles from URL when running server (#7412)

4fbf361

* Only attempt loading ESM bundles from URL when running server * Handle pyodide

Add CHANGELOG for 1.5.3 (#7409)

01529d6

* Add CHANGELOG for 1.5.3 * Update CHANGELOG

Bump panel.js version to 1.5.3-a.1

7cb5436

Add test (#7418)

7ee8cd6

Bump Tabulator version to 6.3 (#7419)

c931756

philippjfr and others added 7 commits October 18, 2024 16:17

Set table null formatter to empty string (#7421)

cc3ecc1

Do not mutate Children inplace (#7417)

5efff82

Update CHANGELOG for 1.5.3b1

516b9e0

Bump panel.js version to 1.5.3-b.1

9237b13

add docstrings, allow triggering views, bugfixes

c509a44

Merge branch 'main' into add_full_calendar

2ce0c19

MarcSkovMadsen reviewed Oct 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Start adding full calendar #7356

Start adding full calendar #7356

ahuang11 commented Oct 3, 2024 •

edited

Loading

holovizbot commented Oct 4, 2024

codecov bot commented Oct 4, 2024 •

edited

Loading

ahuang11 commented Oct 21, 2024

MarcSkovMadsen commented Oct 21, 2024

MarcSkovMadsen Oct 21, 2024

ahuang11 Oct 21, 2024

MarcSkovMadsen Oct 21, 2024

philippjfr Oct 21, 2024

philippjfr Oct 21, 2024 •

edited

Loading

		@@ -0,0 +1,104 @@
		import {Calendar} from "@fullcalendar/core"

Start adding full calendar #7356

Are you sure you want to change the base?

Start adding full calendar #7356

Conversation

ahuang11 commented Oct 3, 2024 • edited Loading

holovizbot commented Oct 4, 2024

codecov bot commented Oct 4, 2024 • edited Loading

Codecov Report

ahuang11 commented Oct 21, 2024

MarcSkovMadsen commented Oct 21, 2024

MarcSkovMadsen Oct 21, 2024

Choose a reason for hiding this comment

ahuang11 Oct 21, 2024

Choose a reason for hiding this comment

MarcSkovMadsen Oct 21, 2024

Choose a reason for hiding this comment

philippjfr Oct 21, 2024

Choose a reason for hiding this comment

philippjfr Oct 21, 2024 • edited Loading

Choose a reason for hiding this comment

ahuang11 commented Oct 3, 2024 •

edited

Loading

codecov bot commented Oct 4, 2024 •

edited

Loading

philippjfr Oct 21, 2024 •

edited

Loading