Support of read only mount of filesystem volumes added #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree to the DCO for all the commits in this PR. |
k0taperk0t
force-pushed
the
read-only-volume-mount-support
branch
from
9add8ee
to
d04ee0b
Compare
pavannd1
reviewed
Oct 2, 2023
This was referenced Oct 5, 2023
k0taperk0t
force-pushed
the
read-only-volume-mount-support
branch
2 times, most recently
from
521cdc4
to
7ba0910
Compare
|
These changes needed for adding support of Ceph-CSI shallow volumes. |
k0taperk0t
force-pushed
the
read-only-volume-mount-support
branch
from
7ba0910
to
fa335cd
Compare
pavannd1
reviewed
Oct 13, 2023
Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>
Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>
k0taperk0t
force-pushed
the
read-only-volume-mount-support
branch
from
fa335cd
to
2178d7f
Compare
k0taperk0t
changed the title
Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>
|
@viveksinghggits please continue review |
viveksinghggits
approved these changes
Oct 17, 2023
e-sumin
reviewed
Oct 17, 2023
Comment on lines
+118
to
+127
| validatedVols := make(map[string]kube.VolumeMountOptions) | ||
| for pvcName, mountPoint := range vols { | ||
| pvc, err := cli.CoreV1().PersistentVolumeClaims(namespace).Get(ctx, pvcName, metav1.GetOptions{}) | ||
| if err != nil { | ||
| return nil, errors.Wrapf(err, "Failed to retrieve PVC. Namespace %s, Name %s", namespace, pvcName) | ||
| } | ||
|
|
||
| validatedVols[pvcName] = kube.VolumeMountOptions{ | ||
| MountPath: mountPoint, | ||
| ReadOnly: kube.PVCContainsReadOnlyAccessMode(pvc), |
There was a problem hiding this comment.
Since this is duplicate of code from, maybe it worth to extract it and reuse ?
There was a problem hiding this comment.
I'm afraid it's too late to push another commits for this review. But I can prepare another PR with refactoring if it's crucial to fix.
There was a problem hiding this comment.
Not crucial, I was too late :D We can refactor this piece of code next time.
e-sumin
reviewed
Oct 17, 2023
Comment on lines
+187
to
+197
| validatedVols := make(map[string]kube.VolumeMountOptions) | ||
| // Validate volumes | ||
| for pvcName, mountPoint := range vols { | ||
| pvc, err := cli.CoreV1().PersistentVolumeClaims(namespace).Get(ctx, pvcName, metav1.GetOptions{}) | ||
| if err != nil { | ||
| return nil, errors.Wrapf(err, "Failed to retrieve PVC. Namespace %s, Name %s", namespace, pvcName) | ||
| } | ||
|
|
||
| validatedVols[pvcName] = kube.VolumeMountOptions{ | ||
| MountPath: mountPoint, | ||
| ReadOnly: kube.PVCContainsReadOnlyAccessMode(pvc), |
e-sumin
reviewed
Oct 17, 2023
| clientset kubernetes.Interface | ||
| } | ||
|
|
||
| // NewJob creates a new Job object. | ||
| func NewJob(clientset kubernetes.Interface, jobName string, namespace string, serviceAccount string, image string, vols map[string]string, command ...string) (*Job, error) { | ||
| func NewJob(clientset kubernetes.Interface, |
There was a problem hiding this comment.
Suggested change
| func NewJob(clientset kubernetes.Interface, | |
| func NewJob( | |
| clientset kubernetes.Interface, |
leuyentran
pushed a commit
that referenced
this pull request
Oct 18, 2023
* Support of read only mount added Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com> * review comments fixed Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com> * renamings regarding review comments Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com> --------- Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR adds support of read-only mount required by Ceph-CSI shallow volumes feature, only for filesystem volumes.
PR series:
minio#2378make testlocally usingminio&minikubefixed #2379Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan