Error reporting fixed for checking status of minio
#2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree to the DCO for all the commits in this PR. |
10 tasks
k0taperk0t
changed the title
miniominio
k0taperk0t
force-pushed
the
fix-for-minio-check-error-reporting
branch
from
59513cc
to
aa57b64
Compare
This was referenced Oct 5, 2023
viveksinghggits
approved these changes
Oct 5, 2023
Co-authored-by: Vivek Singh <vsingh.ggits.2010@gmail.com>
This was referenced Oct 9, 2023
leuyentran
pushed a commit
that referenced
this pull request
Oct 18, 2023
* error responding fixed for minio check * Comment in build/test.sh updated Co-authored-by: Vivek Singh <vsingh.ggits.2010@gmail.com> --------- Co-authored-by: Vivek Singh <vsingh.ggits.2010@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR fixes error reporting for checking status of
minio. Currently, ifminiois not available or broken we will get the same error:Which is pretty weird, when you have installed
minioand it works fine in local environment. With this change we will able to understand what's wrong withminio. In my case it reports this:PR series:
minio#2378make testlocally usingminio&minikubefixed #2379Pull request type
Please check the type of change your PR introduces: