Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running make test locally using minio & minikube fixed #2379

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Running make test locally using minio & minikube fixed #2379

merged 4 commits into from
Oct 13, 2023

Conversation

k0taperk0t
Copy link
Contributor

@k0taperk0t k0taperk0t commented Oct 5, 2023 •
edited

Change Overview

This PR fixes running make test locally using minio & minikube.

PR series:

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

This was referenced Oct 4, 2023
Merged
Merged
Merged
@k0taperk0t
Copy link
Contributor Author

I agree to the DCO for all the commits in this PR.

@viveksinghggits
Copy link
Contributor

This PR fixes running tests locally using minio & minikube.

Hi @k0taperk0t ,
Can you please explain this a bit, what exactly are we fixing here? What do we mean by fixing running tests?

@k0taperk0t
Copy link
Contributor Author

k0taperk0t commented Oct 6, 2023 •
edited

Can you please explain this a bit, what exactly are we fixing here? What do we mean by fixing running tests?

Hi @viveksinghggits!
I needed to add #2365 functionality to Kanister. Since I've never meet with Kanister, I've tried to follow official documentation and run tests, but I was not able to do this. I met few problems, such as:

Even after fixing previous problems I met with failing of tests, if I try to run it locally.

Then I realized that to fix this I need to make changes for running docker containers, but I think it's a bad idea to make the same changes in a few places, so I did refactoring of running containers: #2377.

Thus, changes in this PR fixes running tests and further commits in this PR will fix failing of these test in local environment. But since these changes are based on #2377, at this time this PR contains commits of #2377 as well. I can't rebase them in PR because then this PR will become "local" for my fork.

The main goal is to make ability to run tests locally to fix #2365.

@k0taperk0t k0taperk0t force-pushed the fix-for-local-running-of-tests branch from 8a1b9db to 05e3f08 Compare October 6, 2023 14:54
@k0taperk0t k0taperk0t mentioned this pull request Oct 9, 2023
Merged
7 tasks
@k0taperk0t k0taperk0t changed the title Running tests locally using minio & minikube fixed Runningmake test locally using minio & minikube fixed Oct 9, 2023
@k0taperk0t k0taperk0t changed the title Runningmake test locally using minio & minikube fixed Running make test locally using minio & minikube fixed Oct 9, 2023
@k0taperk0t k0taperk0t marked this pull request as ready for review October 9, 2023 10:10
@k0taperk0t k0taperk0t mentioned this pull request Oct 9, 2023
Merged
10 tasks
viveksinghggits
viveksinghggits reviewed Oct 12, 2023
View reviewed changes
build/run_container.sh Outdated Show resolved Hide resolved
build/run_container.sh Show resolved Hide resolved
build/test.sh Outdated Show resolved Hide resolved
@k0taperk0t
fix for running tests locally
921ee48 
Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>
@k0taperk0t
A `ERROR: Cannot connect to the Docker daemon at unix:///path_to_sock…
b0c0ffa 
…et. Is the docker daemon running?` error fixed

Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>
@k0taperk0t
fixed failing of some test after running make test within local env…
744680d 
…ironment

Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>
@k0taperk0t
review comments fixed
135a1e9 
Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>
@k0taperk0t k0taperk0t force-pushed the fix-for-local-running-of-tests branch from 05e3f08 to 135a1e9 Compare October 13, 2023 07:41
@mergify mergify bot merged commit d4e4b79 into kanisterio:master Oct 13, 2023
14 checks passed
@k0taperk0t k0taperk0t deleted the fix-for-local-running-of-tests branch October 13, 2023 12:50
leuyentran pushed a commit that referenced this pull request Oct 18, 2023
@k0taperk0t
Running make test locally using minio & minikube fixed (#2379)
2f3c2ed 
* fix for running tests locally

Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>

* A `ERROR: Cannot connect to the Docker daemon at unix:///path_to_socket. Is the docker daemon running?` error fixed

Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>

* fixed failing of some test after running `make test` within local environment

Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>

* review comments fixed

Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>

---------

Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@kale-amruta kale-amruta Awaiting requested review from kale-amruta

@e-sumin e-sumin Awaiting requested review from e-sumin

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k0taperk0t @viveksinghggits