Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile fixed for M1 Macs #2366

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Makefile fixed for M1 Macs #2366

merged 1 commit into from
Oct 3, 2023

Conversation

k0taperk0t
Copy link
Contributor

Change Overview

Attempt to run make golint or make build, as described here, on Mac with M1 chip causes the error:

% make golint
running CMD in the containerized build environment
Unable to find image 'ghcr.io/kanisterio/build:v0.0.24' locally
v0.0.24: Pulling from kanisterio/build
docker: no matching manifest for linux/arm64/v8 in the manifest list entries.
See 'docker run --help'.
make[1]: *** [run] Error 125
make: *** [golint] Error 2

This PR fixes that error.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@k0taperk0t
Copy link
Contributor Author

I agree to the DCO for all the commits in this PR.

@k0taperk0t k0taperk0t marked this pull request as ready for review September 29, 2023 14:13
pavannd1
pavannd1 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @k0taperk0t!

e-sumin
e-sumin approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@e-sumin e-sumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I checked it on my M1 laptop, and it works like a charm.

@e-sumin e-sumin added the kueue label Oct 3, 2023
@mergify mergify bot merged commit 6f64ca7 into kanisterio:master Oct 3, 2023
14 checks passed
@k0taperk0t k0taperk0t deleted the Makefile-fixed-for-M1-Macs branch October 3, 2023 09:35
This was referenced Oct 4, 2023
Merged
Merged
Merged
Merged
Merged
Merged
leuyentran pushed a commit that referenced this pull request Oct 18, 2023
@k0taperk0t
Makefile fixed for M1 Macs (#2366)
fcfae32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@e-sumin e-sumin e-sumin approved these changes

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@k0taperk0t @pavannd1 @e-sumin