Running of containerized commands refactored #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree to the DCO for all the commits in this PR. |
10 tasks
k0taperk0t
force-pushed
the
refactoring-of-running-containers
branch
from
d07c62e
to
925baf4
Compare
k0taperk0t
force-pushed
the
refactoring-of-running-containers
branch
2 times, most recently
from
a9be933
to
5ed3d14
Compare
build/run_container.sh
Outdated
| usage | ||
| exit 1 | ||
| esac | ||
|
|
build/run_container.sh
Outdated
|
|
||
| PWD="${PWD:-$(pwd)}" | ||
|
|
||
| # tag 0.1.0 is, 0.0.1 (latest) + gh + aws + helm binary |
There was a problem hiding this comment.
I think this comment can be improved, I don't see 0.1.0 tag anywhere and which image tag are we talking about?
There was a problem hiding this comment.
This commend just been moved from Makefile. Ok, I'll remove it.
This was referenced Oct 5, 2023
|
LGTM but since I'm not an expert in shell scripting, I'd prefer to have second pair of eyes. |
Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>
Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>
Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>
k0taperk0t
force-pushed
the
refactoring-of-running-containers
branch
from
81ea464
to
cd1eb82
Compare
viveksinghggits
approved these changes
Oct 6, 2023
This was referenced Oct 9, 2023
leuyentran
pushed a commit
that referenced
this pull request
Oct 18, 2023
* running of build & docs containers refactored * A `run` rule fixed in Makefile * build/run_container.sh + minor fixes in Makefile Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com> * trivial review fixes Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com> * review comments fixed Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com> --------- Signed-off-by: Sergey Aksenov <sergey.aksenov@veeam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR removes code duplication and makes code of
Makefileeasier and clear. All commands for running containers moved to separated shell script.These changes required for #2379. Without these changes we will have to make changes from #2379 twice - for
shellandruntargets ofMakefileseparately.PR series:
minio#2378make testlocally usingminio&minikubefixed #2379Pull request type
Please check the type of change your PR introduces: