Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foxy devel #21

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Foxy devel #21

merged 3 commits into from
Nov 23, 2022

Conversation

hyunseok-yang
Copy link
Member

Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)

Description of contribution in a few bullet points

Description of documentation updates required from your changes

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

arshadlab and others added 3 commits June 8, 2022 12:07
@arshadlab
Fix for costmap nodes lifecycle status (ros-navigation#3005)
60043d4 
Lifecycle status for global and local cost nodes not correct.
ros2 lifecycle/service commands  shows unconfigured for these two.
This is due to directly calling on_configure/on_activate/on_cleanup
calls in parent node.  This PR to replace on_xxxxxx() to
configure()/activate()/cleanup() calls of lifecycle base.

Signed-off-by: Arshad Mehmood <arshad.mehmood@intel.com>
@DLu
Add Client Thread for costmap_client_node (ros-navigation#3108)
1922e99
@SteveMacenski
removing timeout from py spins in Foxy (ros-navigation#3161)
ca48280
@hyunseok-yang hyunseok-yang merged commit a1229b3 into foxy-devel-cloi Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyunseok-yang @arshadlab @DLu @SteveMacenski