Responsive: Cashier/ Redirection for Deposit with P2P is not proper when switching from a crypto account Responsive: Cashier/ Redirection for Deposit with P2P is not proper when switching from a crypto account #11
Assignees
Labels
bug
Something isn't working
Comments
likhith-deriv
pushed a commit
that referenced
this issue
Nov 2, 2022
…of-error-component Likhith/74105/ts migration of error component
likhith-deriv
pushed a commit
that referenced
this issue
Jan 11, 2023
* chore: migrate calendar-icon to tsx * fix: updated extensions
likhith-deriv
added a commit
that referenced
this issue
May 10, 2023
* feat: 🎨 incorporated new changes * feat: ✨ incorporated idv for mt5
likhith-deriv
added a commit
that referenced
this issue
May 17, 2023
* refactor: initial commit * revert: revert changes * chore: ts-migration for positions-card.tsx (deriv-com#5) * chore: reports-table-row to tsx (#10) * chore: migrating error-components to tsx (#8) * chore: migrating error-components to tsx * fix: added partial to type * chore: migrate calendar-icon to tsx (#11) * chore: migrate calendar-icon to tsx * fix: updated extensions * chore: migrate list-item to tsx (#12) * chore: migrate currency-wrapper to ts (#17) * chore: migrate empty-portfolio-message to ts (#18) * chore: migrating reports meta to tsx (#23) * chore: migrate amount-cell to ts (#16) * chore: migrate amount-cell to ts * fix: delete component because it is unused * chore: migrating EmptyTradeHistoryMessage to tsx (#19) * chore: migrating EmptyTradeHistoryMessage to tsx * fix: remove extension * fix: migrated sidelist to tsx (deriv-com#13) * fix: migrated sidelist to tsx * fix: circle-ci error * fix: sidelist types * chore: migrate composite calendar mobile to typescript (#26) * chore: migrate composite calendar mobile to typescript * fix: remove component extension from the name * refactor: ♻️ removed unused component (#30) * chore: migrate index file to typescript (#27) * refactor: ♻️ migrate component to tsx (#29) * chore: two-month-picker to tsx with one calendar component (#15) * chore: migrate account statistics to ts (#14) * chore: migrate account statistics to ts * fix: typo in comment * Akmal / chore: migrate routes config to typescript (#31) * chore: migrate routes config to typescript * fix: change type for component * Akmal / chore: migrate data-table-constants to typescript (#33) * chore: migrate data-table-constants to typescript * fix: refactor types * chore: migrate loading component to typescript (#36) * Aizad/73988/msir ts (#21) * chore: migrate market-symbol-icon-row to ts * fix: remove commented lines * fix: remove classname from IconTradeTypes * fix: removed action prop * Sergei / chore: migrate open-positions to tsx (#40) * chore: convert open-positions to tsx * fix: add React.PropsWithChildren to tabs.tsx * fix: change Tabs type * fix: add/change some types and fix some undefined values * refactor: use Return Early pattern for contract-card-sell component * chore: delete commented lines * chore: add moment as dev dependency * chore: commit to check circleCI * fix: change back tabs.tsx * fix: change React.Fragment to null * Akmal / chore: convert helpers to typescript (#28) * chore: convert elpers to typescript * fix: types * chore: migrate placeholder to tsx (#42) * chore: migate placeholder to tsx * fix: destructure props and remove React.propswithchildre * Sergei / 73980 / chore: ts migration of route-with-sub-routes (#45) * chore: ts migration of route-with-sub-routes * refactor: add common types to separate files * fix: get back composite-calendar * refactor: change path from absolute to relative for Types * Sergei / 73979 / chore: ts migration of binary-routes (#46) * chore: ts migration of binary-routes.jsx * chore: add TPassthrough type and add key as index when route.path is undefined * chore: add export for TBinaryRoutes type * refactor: use types from common types * Aizad/73977/binary link ts (#41) * chore: migrate routes folder to tsx * fix: change type for component * fix: migrated test cases to tsx * chore: migrate binary-links to tsx * fix: change back function names * fix: resolved conflict issues * fix: testcases * chore: migrated filter component and fix some issues with composite-c… (#20) * chore: migrated filter component and fix some issues with composite-calendar * fix: change export to CalendarIcon on index.js and added RootStore type to filter-components * fix: change TRootStore to RootStore * fix: replace RootStore to TRootStore * fix: expand object for filtered_date_range * Sergei / chore: ts migration of routes (#38) * chore: ts migration of routes * chore: change RootStore type * Aizad/73994/pss ts (#48) * chore: migrate progress-slider-stream to tsx * fix: imported TContractInfo inside deriv/shared/ * Sergei / chore: migrate statements to tsx (#39) * chore: ts migration of statements * chore: change RootStore type * chore: change local TRootStore with module property * fix: return class RootStore to Stores/index.ts * chore: change core_store type * chore: migrated indicative cell to tsx (#44) * chore: migrated indicative cell to tsx * fix: added types to usestate * fix: change type * fix: change function type to boolean * fix: imported TContractInfo from shared file into indicative-cell * fix: test * fix: mockstore * fix: format-response.ts * fix: mockstore * Aizad/73978/routes ts (#50) * Merge branch 'Improvement/72232/Reports_TS_migration' of github.com:mahdiyeh-deriv/deriv-app into ts-migration * chore: finalising routes folder migration for Reports package 📦 * Akmal / chore: migrate app.jsx to typescript (#37) * chore: migrate app.jsx to typescript * chore: utilize TRootStore type * chore: replace type * Akmal / chore: migrate composite calendar to typescript (#25) * chore: migrate composite calendar to typescript * chore: refactor composite calendar and related components to properly use moment * chore: move out index changes * feat: resolve conflicts * feat: add deriv stores package * Kate/73995/TS migration of Reports (#51) * refactor: migrate reports component into ts * refactor: add useStore hook * refactor: delete extra react fragment Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> --------- Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * redeploy: rerun tests * refactor: remove named import from react * chore: migrate statement to tsx (#47) * chore: migrate statement to tsx * fix: use Statement props from api-types than declaring it in ts file * fix: imported TAccountStatistics inside statement * fix: made changes based on comments * fix: refactor based on suggestions * fix: types in packages/shared/src/utils/shortcode/shortcode.ts * fix: regex to prevent sonarcloud bug * chore: change index.js to index.ts * Rostislav / 73993 / Task - TS migration of ProfitTable (#34) * refactor: init pr * refactor: profit_loss_cell tsx'd * refactor: profit_loss_cell import problem resolved * refactor: profit_loss_cell import another problem fix * refactor: the migration is more or less finished * refactor: a few extra changes * refactor: prev commit accidental changes removed * refactor: TProfitTable type changed a bit * refactor: moved types to common-prop.type.ts * refactor: getSupportedContracts and getUnsupportedContracts moved to shared * refactor: contract.tsx completely replaced by imports from @deriv/shared * refactor: added alias for Types * refactor: applied suggested changes * fix: regex for sonarcloud * fix: remove props from the name of type declaration * fix: resolve comments * fix: fix comments v2 * fix: remove usestate * fix: date-time test * fix: comments v3 * thisyahlen/fix: trade table for mobile (#52) * fix: trade table for mobile * fix: trade table error * fix: statement input validation error on date_from * fix: setdate unix * fix: responsive input validation error * fix: remove unix from store --------- Co-authored-by: aizad-deriv <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> Co-authored-by: Rostik Kayko <119863957+rostislav-deriv@users.noreply.github.com> Co-authored-by: Thisyahlen Nair <thisyahlen@regentmarkets.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: hirad-deriv <hirad@re-work.dev>
likhith-deriv
added a commit
that referenced
this issue
Jun 1, 2023
* feat: evgeniy-wall-376/likhith-wall-379/ onfido and idv verification ux improvement with example * refactor: example window styles and types improvvements * fix: circlci test error * chore: formik init * feat: ✨ incorporated IDV in Personal details for Real account sign up * feat: 🐛 resolved failing tests * chore: api updating form and styles * feat: accounts settings identity onfido impovements add * refactor: ♻️ incorporated review comments * fix: text content * feat: 🎨 migrated to TSx * feat: upgraded pack * refactor: inputs form in separate components * chore: example form ts * chore: example container ts * refactor: ts fix * chore: props passing data instead of connect * feat: 🎨 refactor stylings of shared component * feat: incorporated shared component into poi * feat: incorporated shared component into poi * fix: styles, unnecessary code remove * fix: styles for onfido * chore: fix styling * fix: lost styles restore * style: 🎨 resolved issue with onfido container for mobile * feat: 🎨 incorporated IDV new flow * chore: styles onfido * fix: 🐛 resolved tooltip issue * chore: css onfido page * feat: 🎨 incorporated testcases * fix: 🐛 resolved incorrect path * fix: 🐛 failing test case * chore: new confirm form tests * chore: onfido-sdk-view ts migration * chore: deeprequired type fix * Likhith/hide helper image on no avbl doc (#9) * style: 🎨 incorporated hiding of helper image based on avbl doc * style: 🎨 moved color to common variable * Shahzaib/kyc 42/success banner design updates (#10) * style: update positioning of success banner in KYC flow * style: update positioning of success banner in mt5 account flow * chore: renamed prop from is_mt5 to is_external * style: status message width * Likhith/kyc-34/ improve idv flow for poi (#11) * feat: 🎨 incorporated new changes * feat: ✨ incorporated idv for mt5 * refactor: review comments implementation * fix: ⚡ resolved code smells * fix: ⚡ resolved failing testcase * fix: ⚡ removed commented lines * fix: ⚡ removed minor code smells * fix: ⚡ removed minor code smells * feat: 🎨 code refactored * refactor: onfido window separate component * feat: 🎨 code refactored * feat: 🎨 code refactored (#16) * feat: 🐛 minor code smells * chore: error message banner for onfido flow * chore: renamed error message field name * Revert "Merge branch 'master' of https://github.com/binary-com/deriv-app into shahzaib/KYC-1/error-handling-for-onfido-flow" This reverts commit 44635a3, reversing changes made to f5b8fb9. * refactor: sonar cloud security issue * fix: circleci issue * fix: 🐛 removed a code smell * feat: 🎨 added new testcase * feat: 🎨 removed duplicated types * feat: minor bug fix * chore: onfido sdl view test * chore: onfido types rename, timeout comment * feat: reverted localize changes * feat: incorporated review comments * fix: resolved placeholder * feat: resolved radio button issue * fix: minor bug fix * refactor: custom math random create * refactor: deep required * refactor: revert commits with api hooks * fix: 🚑 reverted the radio button change * fix: errors object with empty fields * fix: date picker update value * fix: 🎨 formatted the code * fix: 🎨 formatted the code * chore: added cleartime out * chore: added cleartime out * refactor: ♻️ incorporated review comments * fix: removed code smells * refactor: onfido blue hint box loading fix * chore: removed unnecessary formik field * fix: 🚀 incorporated null checks * chore: resolved prop duplication in form fields * chore: updated name and types in idv form fields * chore: removed unnecessary formik field * fix: add name prop to date of birth custom component (#23) * Refactor/form fields (#24) * fix: add name prop to date of birth custom component * fix: test cases * refactor: update props from formik for date custom fields component * fix: personal-details import image error * fix: ♻️ incorporated review comments * fix: 🐛 build path issue * feat: removed unused import * style: poi form (#25) * fix: 🎨 fixed styling issue * fix: 🐛 import fix * refactor: is_external flag onfido remove * chore: fix render glitch in mt5 form (#29) * chore: fix render glitch in mt5 form * fix: dispose onfido_ref if any error occurs during onfido token fetching or sdk initialization * fix: add a check to display info message upon onfido initialization (cherry picked from commit 1cf15d2) * fix: asterisk in fields label * feat: 🐛 resolved the testcase issue * fix: empty line validation * feat: ✅ fix failing testcases * Likhith/kyc 95/document number reset (#30) * fix: 🐛 fix document number reset * fix: ✨ incorporated idv option fix * fix: 🐛 resolved the issue with DIEL * fix: fieldset padding in mobile screen (#31) * fix: css alignment form * fix: 🐛 resolved issue with tax field (#32) * fix: Place of birth issue * fix: 🐛 resolved issue with radio button (#33) --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com> Co-authored-by: Matin shafiei <matin@deriv.com>
yauheni-deriv
pushed a commit
that referenced
this issue
Sep 7, 2023
* refactor: ts migration of chart loader * refactor: ts migration of screen large form and started purchase * refactor: add types in store and refcator contract * refactor: ts migaration of purchase field * refactor: ts migration of cancel deal info * refactor: ts migration of the purchase btn * refactor: cancel deal info * refactor: remove simular types * refactor: create file for types * chore: cover return value with react fragment * refactor: apply suggestions * refactor: update imports * refactor: type returned value * refactor: left an explanation of expecting ts error * Akmal / feat: migrate EmptyPortfolioMessage, ErrorComponent and Page404 in Trader package (deriv-com#5) * feat: migrate Page404 to Typescript * feat: migrate EmptyPortfolioMessage to Typescript * feat: migrate ErrorComponent to Typescript * fix: dialog prop * fix: dialog type * chore: remove React.FC * maryia/WEBREL-321/feat: migrate Actions files to TS (#4) * feat: migrate /contract-type.js to ts & remove barrier.js * feat: migrate duration to ts + remove unused currency.js * feat: migrate actions/purchase to ts * feat: migrate actions/symbol to ts * feat: migrate start-date.js to ts * feat: migrate actions/test.js to ts * chore: improve types in start-date and duration * fix: address review comments * revert: unnecessary line deletion * fix: address reviews * refactor: remove some code smells * refactor: remove code smells * refactor: update types in stores * Akmal / feat: migrate utils in Trader package (#9) * feat: migrate MarketUnderlying to Typescript * feat: migrate errors to Typescript * feat: migrate error spec to Typescript * feat: migrate index to Typescript * feat: migrate validator to Typescript * feat: trigger vercel * chore: sort options alphabetically * fix: TValidationResult type * chore: prettier formatting * refactor: reduce code smells * chore: validator type improvements (#12) * Kate / DTRA-249 / Code refactoring and removing duplicated files (deriv-com#13) * refactor: remove duplicated file * refactor: test improvements * fix: removed forgotten import * chore: empty commit to retrigger checks * refactor: apply suggestion * maryia/DTRA-260/TS migration of /Constants files & SmartChart/Helpers files in Trader (#6) * feat: validation-rules and ui.js to ts * chore: squash merge maryia/WEBREL-321/actions-to-TS changes * chore: added types to validation-rules.ts * chore: remove unused ui.js, migrate used ui.js and index.js to ts * chore: remove unused ui.js * chore: remove unused markers.js, and migrate barriers.js to ts * chore: added types to barriers.js and its test * test: add missing test for removeBarrier to barriers * Revert "chore: squash merge maryia/WEBREL-321/actions-to-TS changes" * feat: migrated chart-barrier-store.js to ts * feat: remove unused ChartMarkerStore * build: trigger build * fix: address review comments * henry/webrel-319/ts-migration-modules-trading-helpers-folder (#11) * fix: merge conflicts * fix: resolve comments * fix: remove comment * fix: add loadash types dependency * refactor: move error type to common props file * fix: circle CI * fix: resolve comment * fix: bug * fix: convert returntype to use ttradestore * empty commit * fix: type change * fix: resolve comments * fix: comments * maryia/861n17c54/fix: sonarcloud warnings (#14) * fix: sonarcloud warnings * fix: types * fix: resolve conflicts * refactor: apply suggestions * refactor: add last suggestion * refactor: tests * refactor: update function * refactor: add ts migration of exist tests * fix: tests * fix: test case --------- Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: Matin shafiei <matin@deriv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Redmine: Bug #73625
The text was updated successfully, but these errors were encountered: