[firrtl] Add 4.0.0 public modules #6448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
force-pushed
the
dev/seldridge/firrtl-4.0.0-public-modules-parse
branch
from
7b5be71
to
53ef63f
Compare
|
I integrated the changes from #6179 related to top module scalarization. I replaced this with public module scalarization. All this should be removed with changes on the FIRRTL spec side to include the ABI in the public module definition. |
dtzSiFive
approved these changes
Nov 28, 2023
| auto intModuleOp = | ||
| builder.create<FIntModuleOp>(info.getLoc(), name, portList, intName, | ||
| annotations, parameters, internalPaths); | ||
| SymbolTable::setSymbolVisibility(intModuleOp, |
There was a problem hiding this comment.
Maybe we should have these private by default? Not for this PR.
seldridge
force-pushed
the
dev/seldridge/firrtl-4.0.0-public-modules-parse
branch
2 times, most recently
from
3a28066
to
dfb047f
Compare
fabianschuiki
approved these changes
Nov 28, 2023
It does, yes. Proper attribution via |
Add support for FIRRTL 4.0.0 feature, "public modules". This does not provide complete FIRRTL 4.0.0 support as this requires removing circuit names. This will be done in a later commit. Co-authored-by: Will Dietz <will.dietz@sifive.com> Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Remove the -scalarize-top-module option to firtool (and the parser). Replace this with -scalarize-public-modules. This is done in preparation for FIRRTL 4.0.0. This is also largely unnecessary once FIRRTL 4.0.0 figures out how to attach the ABI to each public module. Co-authored-by: Will Dietz <will.dietz@sifive.com> Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
force-pushed
the
dev/seldridge/firrtl-4.0.0-public-modules-parse
branch
from
dfb047f
to
80b3edb
Compare
seldridge
deleted the
dev/seldridge/firrtl-4.0.0-public-modules-parse
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for FIRRTL 4.0.0 feature, "public modules". This does not provide complete FIRRTL 4.0.0 support as this requires removing circuit names. This will be done in a later commit.
This should get unified with: #6176
Fixes #6176.