Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x backport] test: relocate test files fixtures for better understanding #48787 #49174

Closed
wants to merge 115 commits into from
Closed

[v20.x backport] test: relocate test files fixtures for better understanding #48787 #49174

wants to merge 115 commits into from

Conversation

rluvaton
Copy link
Member

Backport: #48787

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Aug 14, 2023
@rluvaton rluvaton mentioned this pull request Aug 14, 2023
Merged
rluvaton added a commit to rluvaton/node that referenced this pull request Aug 14, 2023
@rluvaton
test: reorder test files fixtures for better understanding
6514d06 
Backport-PR-URL: nodejs#49174
PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
rluvaton added a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@rluvaton
test: reorder test files fixtures for better understanding
2dca814 
PR-URL: nodejs#48787
Backport-PR-URL: nodejs#49174
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
rluvaton
rluvaton commented Aug 15, 2023
View reviewed changes
test/parallel/test-runner-cli.js
Comment on lines -67 to -70
assert.match(stdout, /ok 2 - this should pass/);
assert.match(stdout, /not ok 3 - this should fail/);
assert.match(stdout, /ok 4 - .+subdir.+subdir_test\.js/);
assert.match(stdout, /ok 5 - this should pass/);
Copy link
Member Author

@rluvaton rluvaton Aug 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this, as this is like that on main and was like that at the time of the original PR.

how was it added anyway?

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53335/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53349/

rluvaton and others added 15 commits August 15, 2023 14:34
@rluvaton @RafaelGSS
test_runner: fix global before not called when no global test exists
3b5663c 
PR-URL: nodejs#48877
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@mhdawson @RafaelGSS
doc: add ver of 18.x where Node-api 9 is supported
0fce9d0 
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs#48876
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@ShogunPanda @lpinca @RafaelGSS
http: start connections checking interval on listen
222ce81 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#48611
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@nodejs-github-bot @RafaelGSS
tools: update lint-md-dependencies to rollup@3.26.3
23aa191 
PR-URL: nodejs#48888
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@GuidoPenta @RafaelGSS
doc: improve requireHostHeader
eb7fa4b 
PR-URL: nodejs#48860
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ardinugrxha @RafaelGSS
doc: change duration to duration_ms on test documentation
d130e6f 
PR-URL: nodejs#48892
Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@nodejs-github-bot @RafaelGSS
deps: update ada to 2.6.0
af900c9 
PR-URL: nodejs#48896
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@github-actions @RafaelGSS
doc: run license-builder
15bbe47 
PR-URL: nodejs#48898
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@RaisinTen @RafaelGSS
sea: add support for V8 bytecode-only caching
b206233 
Refs: nodejs/single-executable#73
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#48191
Fixes: nodejs/single-executable#73
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@LiviaMedeiros @RafaelGSS
fs: make mkdtemp accept buffers and URL
f8b421e 
PR-URL: nodejs#48828
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@LiviaMedeiros @RafaelGSS
fs: mention URL in NUL character error message
d2e92b9 
PR-URL: nodejs#48828
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@atlowChemi @RafaelGSS
doc: add new reporter events to custom reporter examples
5268181 
Fixes: nodejs#48894
PR-URL: nodejs#48903
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@joyeecheung @RafaelGSS
src: remove ContextEmbedderIndex::kBindingDataStoreIndex
3066f69 
We can now get the binding data through the reference to the
realm directly, so remove it from the context embedder data
slot.

PR-URL: nodejs#48836
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSS
src,permission: restrict by default when pm enabled
833e571 
PR-URL: nodejs#48907
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@aduh95 @RafaelGSS
module: ensure successful import returns the same result
223e86a 
PR-URL: nodejs#46662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
aduh95 and others added 22 commits August 15, 2023 15:47
@aduh95 @RafaelGSS
esm: fix globalPreload warning
8179751 
PR-URL: nodejs#49069
Fixes: nodejs#49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
@andremralves @RafaelGSS
lib: fix MIME overmatch in data URLs
c1f7728 
This commit adds the delimiters ^ and $ to the regex that matches the
MIME types for `data:` URLs.

PR-URL: nodejs#49104
Fixes: nodejs#48957
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS
doc: make the NODE_VERSION_IS_RELEASE revert clear
00de8be 
PR-URL: nodejs#49114
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@aduh95 @RafaelGSS
doc: fix name of the flag in initialize() docs
d7f5f25 
PR-URL: nodejs#49158
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@joyeecheung @RafaelGSS
src: refactor vector writing in snapshot builder
de95c3d 
- Build a static table of octal strings and use it instead of
  building octal strings repeatedly during printing.
- Print a newline and an offset for every 64 bytes in the case
  of printing array literals so it's easier to locate
  variation in snapshot blobs.
- Rework the printing routines so that the differences are only
  made in a WriteByteVectorLiteral routine. We can update this
  for compression support in the future.
- Rename Snapshot::Generate() that write the data as C++ source
  instead of a blob as Snaphost::GenerateAsSource() for clarity,
  and move the file stream operations into it to streamline
  error handling.

PR-URL: nodejs#48851
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@cjihrig @RafaelGSS
test_runner: reland run global after() hook earlier
b9407ff 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
PR-URL: nodejs#49116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@RafaelGSS
src: remove duplicated code in GenerateSingleExecutableBlob()
eba3a40 
PR-URL: nodejs#49119
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot @RafaelGSS
deps: update zlib to 1.2.13.1-motley-526382e
6206ccd 
PR-URL: nodejs#49033
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@deokjinkim @RafaelGSS
doc: fix Type notation in webstreams
0b2e81c 
Replace `type` with `Type: {Promise}`. Plus, fix incorrect
verb(`creates` -> `returns`) in description.

PR-URL: nodejs#49121
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@nodejs-github-bot @RafaelGSS
tools: update eslint to 8.47.0
44a3626 
PR-URL: nodejs#49124
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@nodejs-github-bot @RafaelGSS
deps: update googletest to 7e33b6a
ef9f868 
PR-URL: nodejs#49034
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@MoLow @RafaelGSS
tools: add @reporters/github to tools
f43e5e1 
PR-URL: nodejs#49129
Refs: nodejs#49120
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow @RafaelGSS
tools: use @reporters/github when running in github actions
9b8f69e 
PR-URL: nodejs#49129
Refs: nodejs#49120
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow @RafaelGSS
tools: use spec reporter in actions
350d3d3 
PR-URL: nodejs#49129
Refs: nodejs#49120
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 @RafaelGSS
test: refactor test-esm-loader-hooks for easier debugging
0de3403 
- Always check stderr before stdout as the former would contain error
  information.
- Always match the full stdout to avoid surprises.
- Use `deepStrictEqual` when appropriate to get more informative test
  failures.
- Remove leading slashes from relative paths/URLs to not confuse them
  with absolute paths.
- Remove unnecessary `--no-warnings` flag.

PR-URL: nodejs#49131
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@tniessen @RafaelGSS
test: fix assertion message in test_async.c
4929204 
PR-URL: nodejs#49146
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot @RafaelGSS
tools: update lint-md-dependencies
0b79e8f 
- @rollup/plugin-commonjs@25.0.4
- rollup@3.28.0

PR-URL: nodejs#49122
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@LiviaMedeiros @RafaelGSS
test: use tmpdir.resolve() in fs tests
f8026e0 
PR-URL: nodejs#49125
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@LiviaMedeiros @RafaelGSS
test: use tmpdir.resolve() in fs tests
1554f51 
PR-URL: nodejs#49126
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@LiviaMedeiros @RafaelGSS
test: use tmpdir.resolve()
58512eb 
Subsystems: blob, child_process, common, crypto, http, http2,
readline, repl, snapshot, trace_events

PR-URL: nodejs#49127
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@LiviaMedeiros @RafaelGSS
test: use tmpdir.resolve()
4a24ffc 
PR-URL: nodejs#49128
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@RafaelGSS
doc: add print results for examples in WebStreams
2ed105a 
PR-URL: nodejs#49143
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@rluvaton rluvaton mentioned this pull request Aug 15, 2023
Merged
@rluvaton
test: reorder test files fixtures for better understanding
7c07077 
PR-URL: nodejs#48787
Backport-PR-URL: nodejs#49174
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
rluvaton added a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@rluvaton
test: reorder test files fixtures for better understanding
c81e537 
PR-URL: nodejs#48787
Backport-PR-URL: nodejs#49174
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@RafaelGSS RafaelGSS force-pushed the v20.x-staging branch 2 times, most recently from 2a9aa46 to 21949c4 Compare August 17, 2023 11:48
@rluvaton rluvaton closed this Aug 17, 2023
@rluvaton rluvaton deleted the backport-48787-to-v20.x branch August 17, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.