-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inplace update restart count #941
Inplace update restart count #941
Conversation
/assign @Fei-Guo |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #941 +/- ##
==========================================
- Coverage 50.29% 50.25% -0.04%
==========================================
Files 126 126
Lines 17855 17900 +45
==========================================
+ Hits 8980 8996 +16
- Misses 7886 7908 +22
- Partials 989 996 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
f2654b7
to
34044e7
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
f12dccf
to
01bc44a
Compare
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: JunjunLi <junjunli666@gmail.com> upgrade golint v3 Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
…penkruise#954) Signed-off-by: veophi <vec.g.sun@gmail.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: astraw99 <wangchengiscool@gmail.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: astraw99 <wangchengiscool@gmail.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
…nkruise#1043) Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
…nkruise#1047) Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: FillZpp <FillZpp.pub@gmail.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: FillZpp <FillZpp.pub@gmail.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
…nkruise#1066) Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: FillZpp <FillZpp.pub@gmail.com> Signed-off-by: FillZpp <FillZpp.pub@gmail.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: FillZpp <FillZpp.pub@gmail.com> Signed-off-by: FillZpp <FillZpp.pub@gmail.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Co-authored-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
* pod probe marker apis Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> * fix statefulset truncateHistory panic Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com> Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
…to inplace-update-restart-count
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
9259a2a
to
18f8906
Compare
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
…ruise into inplace-update-restart-count
…ruise into inplace-update-restart-count Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
…ruise into inplace-update-restart-count Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
…ruise into inplace-update-restart-count Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
…ruise into inplace-update-restart-count Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Ⅰ. Describe what this PR does
Add inPlaceUpdate restart count to annotation.
the result is shown below:
Annotations:
apps.kruise.io/inplace-update-pod-restart-count: The Pod restart count.
apps.kruise.io/inplace-update-containers-restart-count: Every container restart count of the pod.
(revision: the revision of the container updated.)
The revision and timestamp maybe is different between the containers when we just update one(or a part of containers in the pod) container of the pod.Because we just update the restart count of the container when it will be updated(inplace-update).
Ⅱ. Does this pull request fix one issue?
fixes #910
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews