Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Feature/pit branch to main #2935

Closed
wants to merge 38 commits into from

Conversation

manasvinibs
Copy link
Member

Description

Merge feature/pit branch to main

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

rupal-bq and others added 30 commits June 26, 2024 13:17
* Add search after for join

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Enable search after by default

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Add pit

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* nit

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix tests

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* ignore joinWithGeoIntersectNL

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Rerun CI with scroll

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Remove unused code and retrigger CI with search_after true

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Address comments

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Remove unused code change

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Update pit keep alive time with SQL_CURSOR_KEEP_ALIVE

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix scroll condition

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* nit

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Add pit before query execution

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* nit

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Move pit from join request builder to executor

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Remove unused methods

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Add pit in parent class's run()

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Add comment for fetching subsequent result in NestedLoopsElasticExecutor

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Update comment

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Add javadoc for pit handler

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Add pit interface

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Add pit handler unit test

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix failed unit test CI

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix spotless error

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Rename pit class and add logs

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix pit delete unit test

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

---------

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
* Add search after for join

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Enable search after by default

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Add pit

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* nit

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix tests

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* ignore joinWithGeoIntersectNL

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Rerun CI with scroll

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* draft

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Remove unused code and retrigger CI with search_after true

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Address comments

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Remove unused code change

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Update pit keep alive time with SQL_CURSOR_KEEP_ALIVE

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix scroll condition

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* nit

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Add pit before query execution

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Refactor get response with pit method

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Update remaining scroll search calls

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix integ test failures

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* nit

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Move pit from join request builder to executor

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Remove unused methods

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Move pit from request to executor

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix pit.delete call missed while merge

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Move getResponseWithHits method to util class

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* add try catch for create delete pit in minus executor

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* move all common fields to ElasticHitsExecutor

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* add javadoc for ElasticHitsExecutor

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Add missing javadoc

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Forcing an empty commit as last commit is stuck processing updates

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

---------

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
…IndexDescriptors (opensearch-project#2772)

* Register system index descriptors through SystemIndexPlugin.getSystemIndexDescriptors

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add Spark Buffer index pattern

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Upgrade to checkout v4

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix CI issues

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Move env

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Revert "Upgrade to checkout v4"

This reverts commit b35573b.

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Co-authored-by: Derek Ho <dxho@amazon.com>
* Introduce SparkParameterComposerCollection

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Fix comments

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Fix integ test

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

---------

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
…e fields as part of Lucene query (opensearch-project#2762)

Github Issue - opensearch-project#2700

Signed-off-by: Manasvini B S <manasvis@amazon.com>
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
* Add release notes for 2.16

Signed-off-by: Chen Dai <daichen@amazon.com>

* Update with latest PRs

Signed-off-by: Chen Dai <daichen@amazon.com>

* Update with latest PRs

Signed-off-by: Chen Dai <daichen@amazon.com>

---------

Signed-off-by: Chen Dai <daichen@amazon.com>
…cklist. (opensearch-project#2808)

* Update PULL_REQUEST_TEMPLATE to include an API spec change in the checklist.

Signed-off-by: dblock <dblock@amazon.com>

* Re-added sections.

Signed-off-by: dblock <dblock@amazon.com>

---------

Signed-off-by: dblock <dblock@amazon.com>
… method (opensearch-project#2866)

* Add RequestContext parameter to verifyDataSourceAccessAndGetRawMetadata method

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Add comments

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Fix style

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

---------

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
…NDOW (10000) (opensearch-project#2860)

* Change the default value of plugins.query.size_limit to MAX_RESULT_WINDOW (10000)

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* fix ut

Signed-off-by: Lantao Jin <ltjin@amazon.com>

* fix spotless

Signed-off-by: Lantao Jin <ltjin@amazon.com>

---------

Signed-off-by: Lantao Jin <ltjin@amazon.com>
…ity enabled domain (opensearch-project#2878)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
opensearch-project#2834)

* [Feature] Flint query scheduler part1 - integrate job scheduler plugin

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Add comments

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Add unit test

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Remove test rest API

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Fix doc test

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Add more tests

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Fix IT

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Fix IT with security

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Improve test coverage

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Fix integTest cluster

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Fix UT

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Update UT

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Fix bwc test

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Resolve comments

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Fix bwc test

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* clean up doc test

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Resolve comments

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Fix UT

Signed-off-by: Louis Chu <clingzhi@amazon.com>

---------

Signed-off-by: Louis Chu <clingzhi@amazon.com>
bugmakerrrrrr and others added 8 commits August 14, 2024 11:38
---------
Signed-off-by: panguixin <panguixin@bytedance.com>
…tateModelService (opensearch-project#2879)

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
---------
Signed-off-by: Heng Qian <qianheng@amazon.com>
…2869)

Signed-off-by: Manasvini B S <manasvis@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
…rless (opensearch-project#2902)

Signed-off-by: Manasvini B S <manasvis@amazon.com>
…source type. (opensearch-project#2858)

Previously, Iceberg catalog was set as the default catalog. This poses
problems as the behavior to fall back to default Spark catalog is only
correct in some versions of Iceberg. Rather than always opt into
Iceberg, Iceberg should be an option.

Additionally, the Lake Formation flag enabled Lake Formation for the EMR
job. This did not work as expected because EMR system space does not
work with Flint. Instead Lake Formation can be enabled using the Iceberg
catalog implementation.

This changes adds Security Lake as a data source type. Security Lake as
a data source is simply specific options set on top of the base S3Glue
data source.
---------

Signed-off-by: Adi Suresh <adsuresh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.