Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] k8s 1.31 #2004

Closed
wants to merge 1,761 commits into from
Closed

[WIP] k8s 1.31 #2004

wants to merge 1,761 commits into from

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Jul 1, 2024

No description provided.

benluddy and others added 30 commits June 25, 2024 21:12
The CBOR decode and "appendix a" unit tests cover specific serialization behaviors that were known
to be incomplete at the time. Now that all of those cases have been addressed, the mechanism for
skipping those tests can be removed.
…xpression-evaluation

Validate CRD stored messageExpressions with the correct CEL environment
…ionPolicy-GA

promote PDBUnhealthyPodEvictionPolicy to GA
Remove test dependency on swagger.json to fix client-go tests
This is a feature of the underlying k8s.io/klog/v2/ktesting which is
useful also when using the Kubernetes ktesting.
The DRA plugin does that. It didn't actually work and only printed an error
message about NodeInfo not implementing klog.KMetata. That's not a compile-time
check due to limitations with Go generics and had been missed earlier.
Signed-off-by: cpanato <ctadeu@gmail.com>
KEP-4222: Enable JSON-compatible base64 encoding of []byte for CBOR.
…am-consistent-read-from-cache-supports-pagination

Revert "apiserver/storage/cacher: consistent read from cache supports limit"
…ogging

scheduler: fix klog.KObjSlice when applied to []*NodeInfo
Remove 5 seconds from TestWatchStreamSeparation execution by reusing etcdserver
Signed-off-by: googs1025 <googs1025@gmail.com>
The underlying CBOR library will by default encode a value to and from byte string if its type
implements encoding.BinaryMarshaler or encoding.BinaryUnmarshaler, respectively. This is now
disabled via an option to avoid diverging from JSON in those cases.
update publishing rules to use go1.22.4 for all branches
…tests-decrease-time

apiserver/storage: decrease running time of RunWatchSemantics
controlplane/apiserver: Trim managedFields off self-requested informers
kubernetes#112809 tightened what regular
expressions are allowed and now requires that they start matching with a double
dash.
Tal-or and others added 16 commits July 1, 2024 16:21
Adding a new mutation plugin that handles the following:

1. In case of `workload.openshift.io/enable-shared-cpus` request, it
   adds an annotation to hint runtime about the request. runtime
   is not aware of extended resources, hence we need the annotation.
2. It validates the pod's QoS class and return an error if it's not a
   guaranteed QoS class
3. It validates that no more than a single resource is being request.
4. It validates that the pod deployed in a namespace that has mixedcpus
   workloads allowed annotation.

For more information see - openshift/enhancements#1396

Signed-off-by: Talor Itzhak <titzhak@redhat.com>

UPSTREAM: <carry>: Update management webhook pod admission logic

Updating the logic for pod admission to allow a pod creation with workload partitioning annotations to be run in a namespace that has no workload allow annoations.

The pod will be stripped of its workload annotations and treated as if it were normal, a warning annoation will be placed to note the behavior on the pod.

Signed-off-by: ehila <ehila@redhat.com>

UPSTREAM: <carry>: add support for cpu limits into management workloads

Added support to allow workload partitioning to use the CPU limits for a container, to allow the runtime to make better decisions around workload cpu quotas we are passing down the cpu limit as part of the cpulimit value in the annotation. CRI-O will take that information and calculate the quota per node. This should support situations where workloads might have different cpu period overrides assigned.

Updated kubelet for static pods and the admission webhook for regular to support cpu limits.

Updated unit test to reflect changes.

Signed-off-by: ehila <ehila@redhat.com>
…ject openshift feature gates into pkg/features

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
…olumn

The logic is not exressible via JSONPath. Hence, if we want this, we have to help a little with this custom column writer.

OpenShift-Rebase-Source: 633a422
- we tie the shutdown events with the UID of  the first
  (shutdown initiated), this provides us with a more
  deterministic way to compute shutdown duration from
  these events

- move code snippets from the upstream file to openshift
  specific patch file, it reduces chance of code conflict

Note for rebase: squash it into the following commit
cfbb6d6 UPSTREAM: <carry>: create termination events
PersistentVolumeLabel admission plugin is being disabled in OCP 4.16. Skip all tests that require it.
The node.status.addresses logic grew organically and with weird
semantics, this commit try to document existing semantics when
the kubelet uses an external cloud provider and recover the same
behavior existing pre-1.29.

The node.status.addresses can be populated by the kubelet at startup or
delegated to the external cloud provider.

If the --node-ip flag is set to an IP in the node, the kubelet will add
an annotation to the Node object that will be respected by the external
cloud providers, no new IP addresses will be added for the same address
type.

If the IP set in the --node-ip flag is `0.0.0.0` or `::`, the kubelet
will initialize the node with the default address of the corresponding
IP family of the unspecified address, and the cloud-provider will override
it later.
Remove PersistentVolumeLabel admission plugin from the default list of
enabled admissions.

The plugin is deprecated upstream and most of its functionality was removed
in 1.29 and 1.30.

This is continuation of openshift/cluster-kube-apiserver-operator#1693,
the admission is enabled on multiple places.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2024
Copy link

openshift-ci bot commented Jul 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jul 1, 2024
@openshift-ci-robot
Copy link

@soltysh: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@soltysh
Copy link
Member Author

soltysh commented Jul 1, 2024

/test unit
/test integration

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jul 1, 2024
Copy link

openshift-ci bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@soltysh
Copy link
Member Author

soltysh commented Jul 2, 2024

/test e2e-gcp

2 similar comments
@soltysh
Copy link
Member Author

soltysh commented Jul 2, 2024

/test e2e-gcp

@soltysh
Copy link
Member Author

soltysh commented Jul 3, 2024

/test e2e-gcp

Copy link

openshift-ci bot commented Jul 8, 2024

@soltysh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp ecdb77a link true /test e2e-gcp
ci/prow/e2e-aws-ovn-runc ecdb77a link true /test e2e-aws-ovn-runc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@soltysh soltysh closed this Jul 12, 2024
@soltysh soltysh deleted the rebase-2024-07-01 branch July 15, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet