Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pbjs.adServers.dfp.buildVideoUrl does not append hb_uuid or hb_cache_id when using URL #2353

Closed
mkendall07 opened this issue Apr 4, 2018 · 0 comments · Fixed by #2363
Closed

pbjs.adServers.dfp.buildVideoUrl does not append hb_uuid or hb_cache_id when using URL #2353

mkendall07 opened this issue Apr 4, 2018 · 0 comments · Fixed by #2363
Assignees
@mkendall07
Labels
bug

Comments

@mkendall07
Copy link
Member

mkendall07 commented Apr 4, 2018 •
edited
Loading

Type of issue

bug

Description

pbjs.adServers.dfp.buildVideoUrl when using the url option, does not append hb_uuid or hb_cache_id to the cust_params.

example:

var videoUrl = pbjs.adServers.dfp.buildVideoUrl({
                    adUnit: videoAdUnit,
                    url: "https://pubads.g.doubleclick.net/gampad/ads?sz=640x480&iu=/19968336/prebid_cache_video_adunit&impl=s&gdfp_req=1&env=vp&output=xml_vast2&unviewed_position_start=1&hl=en&url=http://www.example.com&cust_params=section%3Dblog%26anotherKey%3DanotherValue"
                });

Results in the following URL:

https://pubads.g.doubleclick.net/gampad/ads?sz=640x480&iu=/19968336/prebid_cache_video_adunit&impl=s&gdfp_req=1&env=vp&output=xml_vast2&unviewed_position_start=1&hl=en&url=http://www.example.com&cust_params=section%3Dblog%26anotherKey%3DanotherValue%26hb_bidder%3DappnexusAst%26hb_adid%3D28e9373ee44fd7%26hb_pb%3D10.00%26hb_size%3D640x480

Affected versions

1.7, legacy
@mkendall07 mkendall07 added the bug label Apr 4, 2018
mkendall07 added a commit that referenced this issue Apr 5, 2018
@mkendall07
fixes #2353 - not appending hb_uuid and hb_cache_id
8c29d2b
@mkendall07 mkendall07 mentioned this issue Apr 5, 2018
Merged
1 task
@mkendall07 mkendall07 self-assigned this Apr 5, 2018
jaiminpanchal27 pushed a commit that referenced this issue Apr 13, 2018
@mkendall07 @jaiminpanchal27
fixes #2353 - not appending hb_uuid and hb_cache_id (#2363)
49ee97d
ArmandChoy pushed a commit to RockYou-Ads/Prebid.js that referenced this issue Apr 18, 2018
Merge branch 'master' of https://github.com/prebid/Prebid.js
e9f72f2 
* 'master' of https://github.com/prebid/Prebid.js: (211 commits)
  Increment Pre Version
  Prebid 1.8.0 Release
  Make eslint aware of the custom import paths (prebid#2292)
  send travis-ci notifications to slack (prebid#2404)
  send appnexus usePaymentRule info to prebid-server ortb request (prebid#2351)
  convert AN bid params to underscore formatting for pbs (prebid#2385)
  EbdrAdapter add usersync  (prebid#2407)
  Add outstream renderer to Beachfront adapter (prebid#2403)
  Add analytics adapter by Sigmoid (prebid#2316)
  deprecate loadScript and add loadExternalScript (prebid#2391)
  Removed the ability for to override any standard query parameters (prebid#2402)
  Unit test failures (prebid#2405)
  Add Unruly Bid Adapter (prebid#2326)
  Added VIS.X Bidder Adapter (prebid#2359)
  Smart: Add prebid version in the data payload (prebid#2394)
  add support for video bids to use an impression tracking URL  (prebid#2365)
  Create rtbdemandAdkBidAdapter_spec.js (prebid#2352)
  Widespace adapter (prebid#2283)
  Add: Vuble Analytics Adapter (prebid#2331)
  fixes prebid#2353 - not appending hb_uuid and hb_cache_id (prebid#2363)
  ...

# Conflicts:
#	test/spec/modules/rockyouBidAdapter_spec.js
dluxemburg pushed a commit to Genius/Prebid.js that referenced this issue Jul 17, 2018
@mkendall07 @dluxemburg
fixes prebid#2353 - not appending hb_uuid and hb_cache_id (prebid#2363)
af6439a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkendall07 mkendall07

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #2353 - not appending hb_uuid and hb_cache_id prebid/Prebid.js
1 participant
@mkendall07