Add analytics adapter by Sigmoid #2316
Conversation
|
This pull request introduces 1 alert when merging 16c9063 into 8719aef - view on lgtm.com new alerts:
Comment posted by lgtm.com |
|
@mkendall07 I have resolved all the errors and added markdown file. Can we move forward with this? |
modules/sigmoidAnalyticsAdapter.js
Outdated
| eventStack.events = []; | ||
| } | ||
|
|
||
| // function flushBidWon() { |
modules/sigmoidAnalyticsAdapter.js
Outdated
| function buildBidWon(eventType, args) { | ||
| bidWon.options = initOptions; | ||
| if (checkAdUnitConfig()) { | ||
| if (initOptions.adUnits.includes(args.adUnitCode)) { |
There was a problem hiding this comment.
Use includes by importing it from core-js
import includes from 'core-js/library/fn/array/includes';
Usage includes(<array>, <item>
includes doesn’t work in older versions of IE. The imported version is polyfilled to work with ie, rather than Babel doing any kind of transforms that might end up not working in target browsers
modules/sigmoidAnalyticsAdapter.js
Outdated
| // attach event listener | ||
| if (err) { | ||
| alert('Error retrieving credentials.'); | ||
| console.error(err); |
There was a problem hiding this comment.
Use utils.logError
modules/sigmoidAnalyticsAdapter.js
Outdated
| AWS.config.credentials.get(function(err) { | ||
| // attach event listener | ||
| if (err) { | ||
| alert('Error retrieving credentials.'); |
modules/sigmoidAnalyticsAdapter.js
Outdated
| const url = 'https://kinesis.us-east-1.amazonaws.com/'; | ||
| const analyticsType = 'endpoint'; | ||
|
|
||
| let auctionInitConst = CONSTANTS.EVENTS.AUCTION_INIT; |
There was a problem hiding this comment.
These should be const
| let adaptermanager = require('src/adaptermanager'); | ||
| let constants = require('src/constants.json'); | ||
|
|
||
| describe('sigmoid Prebid Analytic', function () { |
There was a problem hiding this comment.
Your coverage is 70%. Please increase that to atleast 80%
To test and view use gulp test-coverage and gulp view-coverage
|
@sigmoidanalytics Any update ? |
|
@sigmoidanalytics Travis failed due to lint error. Please check |
* 'master' of https://github.com/prebid/Prebid.js: (211 commits) Increment Pre Version Prebid 1.8.0 Release Make eslint aware of the custom import paths (prebid#2292) send travis-ci notifications to slack (prebid#2404) send appnexus usePaymentRule info to prebid-server ortb request (prebid#2351) convert AN bid params to underscore formatting for pbs (prebid#2385) EbdrAdapter add usersync (prebid#2407) Add outstream renderer to Beachfront adapter (prebid#2403) Add analytics adapter by Sigmoid (prebid#2316) deprecate loadScript and add loadExternalScript (prebid#2391) Removed the ability for to override any standard query parameters (prebid#2402) Unit test failures (prebid#2405) Add Unruly Bid Adapter (prebid#2326) Added VIS.X Bidder Adapter (prebid#2359) Smart: Add prebid version in the data payload (prebid#2394) add support for video bids to use an impression tracking URL (prebid#2365) Create rtbdemandAdkBidAdapter_spec.js (prebid#2352) Widespace adapter (prebid#2283) Add: Vuble Analytics Adapter (prebid#2331) fixes prebid#2353 - not appending hb_uuid and hb_cache_id (prebid#2363) ... # Conflicts: # test/spec/modules/rockyouBidAdapter_spec.js
Type of change
Description of change
This is a new analytics adapter for Prebid by Sigmoid. We are an advanced analytical solutions company.
https://www.sigmoid.com/
contact email of the adapter’s maintainer
ramees@sigmoidanalytics.com
[x ] official adapter submission