-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart: Add prebid version in the data payload #2394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Spacedragoon The changes LGTM. However I noticed that I wasn't getting a bid response from your server when I testing out the changes.
I was using the updated values in your .md file. Is there something I need to configure to see an ad?
Below is a copy of the request that was fired off and ended in a 200 response:
{"siteid":207435,"pageid":896536,"formatid":62913,"bidfloor":0,"buid":"com.smartadserver.android.dashboard","appname":"Smart AdServer Preview","ckid":1234567890123456800,"tagId":"div-gpt-ad-1460505748561-0","sizes":[{"w":300,"h":250},{"w":300,"h":600}],"pageDomain":"http://test.mysite.com:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true","transactionId":"e1f1e151-8ae8-417b-bcfa-6161ad78959f","timeout":3000,"bidId":"2528093c3abe56","prebidVersion":"1.8.0-pre"}
Hi @jsnellbaker , We have fixed the doc to split the test parameters for in-app and web traffic. You could use either. But for simplicity we would recommend to use the web's:
Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ytyukhnin Thanks for providing the alternate test params. I gave them a try and everything was working as expected.
* 'master' of https://github.com/prebid/Prebid.js: (211 commits) Increment Pre Version Prebid 1.8.0 Release Make eslint aware of the custom import paths (prebid#2292) send travis-ci notifications to slack (prebid#2404) send appnexus usePaymentRule info to prebid-server ortb request (prebid#2351) convert AN bid params to underscore formatting for pbs (prebid#2385) EbdrAdapter add usersync (prebid#2407) Add outstream renderer to Beachfront adapter (prebid#2403) Add analytics adapter by Sigmoid (prebid#2316) deprecate loadScript and add loadExternalScript (prebid#2391) Removed the ability for to override any standard query parameters (prebid#2402) Unit test failures (prebid#2405) Add Unruly Bid Adapter (prebid#2326) Added VIS.X Bidder Adapter (prebid#2359) Smart: Add prebid version in the data payload (prebid#2394) add support for video bids to use an impression tracking URL (prebid#2365) Create rtbdemandAdkBidAdapter_spec.js (prebid#2352) Widespace adapter (prebid#2283) Add: Vuble Analytics Adapter (prebid#2331) fixes prebid#2353 - not appending hb_uuid and hb_cache_id (prebid#2363) ... # Conflicts: # test/spec/modules/rockyouBidAdapter_spec.js
* Add prebid version in the data payload * Changing the doc to include the in-app test params * fixing url
Type of change
Description of change
send the version of prebid used in the request.
Also, small change of the test parameter