Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rtbdemandAdkBidAdapter_spec.js #2352

Merged
merged 2 commits into from
Apr 16, 2018
Merged

Conversation

rtbdemand
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@rtbdemand
Copy link
Contributor Author

Added rtbdemandadk.md in PR as well prebid/prebid.github.io#696 and included the unit test file

@jsnellbaker jsnellbaker requested review from jsnellbaker and removed request for ndhimehta April 11, 2018 14:58
@jsnellbaker jsnellbaker assigned jsnellbaker and unassigned ndhimehta Apr 11, 2018
@jsnellbaker
Copy link
Collaborator

@rtbdemand there appear to be some test failures in the Travis build. Can you please investigate and fix?

below is a copy of the error details:

banner request building
      ✖ "before all" hook
HeadlessChrome 65.0.3325 (Linux 0.0.0) rtbdemandadk adapter banner request building "before all" hook FAILED
	TypeError: stub(obj, 'meth', fn) has been removed, see documentation
	    at context.<anonymous> (base/test/test_index.js?9d95b3f642e2ec7bc2fabbb5251c2fb20334726c:58277:20)
responses processing
      ✖ should return fully-initialized banner bid-response
HeadlessChrome 65.0.3325 (Linux 0.0.0) rtbdemandadk adapter responses processing should return fully-initialized banner bid-response FAILED
	AssertionError: expected { Object (requestId, cpm, ...) } to have a property 'width' of 300, but got undefined
	    at context.<anonymous> (base/test/test_index.js?9d95b3f642e2ec7bc2fabbb5251c2fb20334726c:58372:39)

@rtbdemand
Copy link
Contributor Author

Looking at

Copy link
Contributor Author

@rtbdemand rtbdemand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated added width and height fields in response time breaking test

@rtbdemand
Copy link
Contributor Author

Same is fixed..By when will appear in prebid page now

@jsnellbaker jsnellbaker merged commit 77b57f1 into prebid:master Apr 16, 2018
@jsnellbaker jsnellbaker mentioned this pull request Apr 16, 2018
10 tasks
ArmandChoy pushed a commit to RockYou-Ads/Prebid.js that referenced this pull request Apr 18, 2018
* 'master' of https://github.com/prebid/Prebid.js: (211 commits)
  Increment Pre Version
  Prebid 1.8.0 Release
  Make eslint aware of the custom import paths (prebid#2292)
  send travis-ci notifications to slack (prebid#2404)
  send appnexus usePaymentRule info to prebid-server ortb request (prebid#2351)
  convert AN bid params to underscore formatting for pbs (prebid#2385)
  EbdrAdapter add usersync  (prebid#2407)
  Add outstream renderer to Beachfront adapter (prebid#2403)
  Add analytics adapter by Sigmoid (prebid#2316)
  deprecate loadScript and add loadExternalScript (prebid#2391)
  Removed the ability for to override any standard query parameters (prebid#2402)
  Unit test failures (prebid#2405)
  Add Unruly Bid Adapter (prebid#2326)
  Added VIS.X Bidder Adapter (prebid#2359)
  Smart: Add prebid version in the data payload (prebid#2394)
  add support for video bids to use an impression tracking URL  (prebid#2365)
  Create rtbdemandAdkBidAdapter_spec.js (prebid#2352)
  Widespace adapter (prebid#2283)
  Add: Vuble Analytics Adapter (prebid#2331)
  fixes prebid#2353 - not appending hb_uuid and hb_cache_id (prebid#2363)
  ...

# Conflicts:
#	test/spec/modules/rockyouBidAdapter_spec.js
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Create rtbdemandAdkBidAdapter_spec.js

* Update rtbdemandAdkBidAdapter_spec.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants