deprecate loadScript and add loadExternalScript #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idettman
approved these changes
Apr 16, 2018
mkendall07
added
needs 2nd review
|
@mkendall07 Do any docs need to be updated for this PR? |
jsnellbaker
approved these changes
Apr 17, 2018
|
@jsnellbaker |
jaiminpanchal27
approved these changes
Apr 17, 2018
ArmandChoy
pushed a commit
to RockYou-Ads/Prebid.js
that referenced
this pull request
Apr 18, 2018
* 'master' of https://github.com/prebid/Prebid.js: (211 commits) Increment Pre Version Prebid 1.8.0 Release Make eslint aware of the custom import paths (prebid#2292) send travis-ci notifications to slack (prebid#2404) send appnexus usePaymentRule info to prebid-server ortb request (prebid#2351) convert AN bid params to underscore formatting for pbs (prebid#2385) EbdrAdapter add usersync (prebid#2407) Add outstream renderer to Beachfront adapter (prebid#2403) Add analytics adapter by Sigmoid (prebid#2316) deprecate loadScript and add loadExternalScript (prebid#2391) Removed the ability for to override any standard query parameters (prebid#2402) Unit test failures (prebid#2405) Add Unruly Bid Adapter (prebid#2326) Added VIS.X Bidder Adapter (prebid#2359) Smart: Add prebid version in the data payload (prebid#2394) add support for video bids to use an impression tracking URL (prebid#2365) Create rtbdemandAdkBidAdapter_spec.js (prebid#2352) Widespace adapter (prebid#2283) Add: Vuble Analytics Adapter (prebid#2331) fixes prebid#2353 - not appending hb_uuid and hb_cache_id (prebid#2363) ... # Conflicts: # test/spec/modules/rockyouBidAdapter_spec.js
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Use of adLoader.loadScript is deprecated as of prebid 1.x however it was not removed. Adding a deprecated tag here + adding lightweight function to just load a script.