-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebases 'next' branch onto current 'master'. #2165
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use subscribe to persist to localStorage more discoverable than #1608 * Clearer wording
Just fixed a sentence error.
Update WritingTests.md
* feat(compose): optimize one function case * style(compose): do not use a variable for funcs.length * test(compose): add test for a single param
* Remove redundant empty layers (groups) from SVG logo * Optimize redux SVG logo code w/ SVGO
I think React is in our head stamped with ReactDOM. So it may be clearer to specifiate React Native, even if there is no difference between using Redux within React nor React Native. What do you think?
`expect` package is missing from devDependencies and it's required to run tests in this example.
* Add check for ES3 syntax compatibility * Remove uglify optimization that undos ES3 compatibility
I had to add a .babelrc change to get the default examples to work, as described here: http://jamesknelson.com/testing-in-es6-with-mocha-and-babel-6/
Add extra required babel configuration step
I, Herman, setup up patreon account as an employee of HauteLook. The company should receive the credit for funding the project.
The normalizr lib has moved to a different location. Update the URL in comments to point to the new repo.
Hope you are willing to have this listed - I've got lots of great feedback from people who have taken it!
* rename createStore param `initialState` to `preloadedState` * rename configureStore param `initialState` to `preloadedState` * rename `window.__INITIAL_STATE__` in examples and docs rename window.__INITIAL_STATE__ to window.__PRELOADED_STATE__
This short piece of code renders all html tags in JSON harmless, by replacing the `<` character with its unicode escape `\u003c`. Since the only place where JSON can have `<` is in strings, this is sufficient for protecting JSON from XSS injection.
Provide example of initial state SSR scrub
Doc: Improve readability of Usage with React Router section
Fixed typo and increased fidelity of description with respect to example.
Doc: clarify Navigating with React Router section
Added a line in handleChange() which fixes the issue of posts not being requested when a new subreddit is selected.
Updated ExampleRedditAPI.md
grammar fix - missing word
Update ReducingBoilerplate.md
Remove `export` from requestPosts, receivePosts, and fetchPosts actions, as these are not exported in the final version. Also suggest adding brief explanation as to why they are not exported.
Code typo: returns => return
…ave nothing to return
Simplify composer
fixed condition where multiple bad values would be filtered out and h…
…#1569) * throw error if getState, subscribe, or unsubscribe called while dispatching * prevent throwing if not subscribed * update getState error message * fix space after period * update subscribe/unsubscribe error messages
* Add a doc section on dispatching during middleware setup. * Warn when dispatching during middleware setup. * Upgrade the warning to an error. * Update docs to match thrown error behavior.
Redux 4.x behavior changes from 'keeps unwrapped dispatch available while middleware is initializing' to 'warns when dispatching during middleware setup'
Yeah, this isn't working right... 😄 I can make sure that branch gets updated by hand. Doing this via PR isn't going to work with the complexity of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.