Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from prebid:master #1613

Merged
merged 69 commits into from
Jul 15, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Jun 28, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

skapoor-viant and others added 7 commits June 27, 2024 20:31
* Added deals support in viantOrtbBidAdapter

* refactoring

* refactor

* refactor

* refactor

* refactor

* added test case

* refactor

* refactor test file

* added test case and addressed suggestions
* ZetaGlobalSsp adapter: merge params.site and ortb2.site

* fix unit test

* extract buildVideo into utils

* Revert "extract buildVideo into utils"

This reverts commit a075583.

---------

Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com>
Co-authored-by: Alexey Surovenko <ASurovenko@vdhk6ddf9m.home>
* cpmstarBidAdapter - added gvlid, added ortb and banner request data, various cleanups

* cpmstarBidAdapter - fixed schain test for different url encoding

* cpmstarBidAdapter: removed extra blank line
…b2 (#11860)

* AF-3740 retrieved topics data from user on ortb2

* AF-3740 kept old user data

* AF-3740 added some checks for user data

* AF-3740 used mergeDeep for merging user objects

* AF-3740 provided unit tests for ortb2 data

* AF-3740 moved some functionality to utils and used for avoiding duplication

* AF-3740 provided unit tests
big fix for ozsize key
This fixes an issue in the server response parsing for user sync, where it was not using the body from the response. I took the occasion to also convert this member to camelCase for consistency with the others.

Co-authored-by: Kevin Siow <kevin.siow@dailymotion.com>
@pull pull bot added the ⤵️ pull label Jun 28, 2024
…11888)

* vidazooUtils - single request configurations

* fix: shines rtb adapter use vidazoo bidder utils

* fix: added vidazoo utils to illimin adapter

* fix: illumin bid adapter using vidazooUtils

* fix: twistDigital adapter use vidazooUtils

* fix: tagoras adapter use vidazooUtils

* fix: kueezRtb adapter use vidazooUtils

* fix: removed parrable and digitrust id systems
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

…ves (#11863)

* Core: add location method for cross-frame creatives and update creatives

* improvements
Copy link

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

* start sending placement and placmt separately

* move setOnAny function to utils

* remove transformSizes and use util function
Copy link

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

* Outbrain Bid Adapter: Add full ORTB2 device data to request payload

* Outbrain Bid Adapter: Add test to verify presence of ORTB2 device data in request

---------

Co-authored-by: Bohdan V <25197509+BohdanVV@users.noreply.github.com>
Copy link

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

github-actions bot commented Jul 2, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

github-actions bot commented Jul 2, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

github-actions bot commented Jul 2, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

This can cause too big of an issue for reporting it only as warning.
Copy link

github-actions bot commented Jul 2, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

* AppNexus Bid Adapter: Add full ORTB2 device data to request payload

* AppNexus Bid Adapter: Add test to verify presence of ORTB2 device data in request

* AppNexus Bid Adapter: Convert ORTB2 device data to AppNexus format

---------

Co-authored-by: Bohdan V <25197509+BohdanVV@users.noreply.github.com>
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

…dUnit, updated event tracking, added UserId support (#11944)

* Support multiple adUnit, updated event tracking, added UserId support

* remove unused params

* fix unit tests

* change MODULE_NAME

* added keepalive
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

* 10997 set pps to gam display

* update

* update

* review changes

* module handling

* code sharing

* linting fixes

* Rename setPPSConfig

* Filter out adIds that have no auction

* use eql instead of JSON for deep equals

---------

Co-authored-by: Marcin Komorski <marcinkomorski@Marcins-MacBook-Pro.local>
Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

* AdagioAnalyticsAdapter: use adagio rtd.uid as auctionId

* AdagioBidAdapter: use adagio rtd.uid as auctionId

* AdagioAnalyticsAdapter: use common code

---------

Co-authored-by: Olivier <osazos@adagio.io>
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Co-authored-by: Gabriel Chicoye <gabriel@macbookrogab24g.lan>
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

* AdagioAnalyticsAdapter: send PBA for all auctions

* AdagioAnalyticsAdapter: typo

* AdagioAnalyticsAdapter: update md file

---------

Co-authored-by: Olivier <osazos@adagio.io>
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@jefftmahoney jefftmahoney merged commit b8d37a9 into sharethrough:master Jul 15, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.