[WIP] Feature #3417 - Implement tuiDropdownDirectionChange & tuiHintDirectionChange #9645

shiv9604 · 2024-10-30T20:25:38Z

lumberjack-bot · 2024-10-30T20:25:47Z

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

bundlemon · 2024-10-30T20:35:12Z

BundleMon

Files updated (1)

Status	Path	Size	Limits
✅	demo/browser/main.(hash).js	304.5KB (+136B +0.04%)	+10%

Unchanged files (4)

Status	Path	Size	Limits
✅	demo/browser/vendor.(hash).js	260.09KB	+10%
✅	demo/browser/runtime.(hash).js	44.03KB	+10%
✅	demo/browser/styles.(hash).css	19.63KB	+10%
✅	demo/browser/polyfills.(hash).js	11.18KB	+10%

Total files change +133B +0.02%

Groups updated (1)

Status	Path	Size	Limits
✅	demo/browser/*..js	7.34MB (+317B 0%)	-

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

codecov · 2024-10-30T20:40:00Z

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.23%. Comparing base (4a26b1a) to head (a9ba39e).
Report is 601 commits behind head on main.

Files with missing lines	Patch %	Lines
...ives/dropdown/dropdown-position-sided.directive.ts	50.00%	3 Missing ⚠️
...cts/core/directives/dropdown/dropdown.directive.ts	33.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9645      +/-   ##
==========================================
- Coverage   75.68%   75.23%   -0.45%     
==========================================
  Files        1216     1248      +32     
  Lines       19068    19600     +532     
  Branches     2091     2090       -1     
==========================================
+ Hits        14432    14747     +315     
- Misses       4592     4807     +215     
- Partials       44       46       +2

Flag	Coverage Δ
summary	`75.23% <81.48%> (-0.45%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

projects/core/directives/hint/hint.directive.ts

projects/core/directives/dropdown/dropdown-position-sided.directive.ts

projects/core/directives/dropdown/dropdown.directive.ts

projects/core/directives/dropdown/dropdown-position.directive.ts

waterplea · 2024-11-09T09:08:55Z

projects/core/directives/dropdown/dropdown-position-sided.directive.ts

@@ -57,10 +56,13 @@ export class TuiDropdownPositionSided extends TuiPositionAccessor {
            (available[this.previous] > minHeight && direction) ||
            this.previous === better
        ) {
+            this.vertical.emitDirection(better);


It should be this.previous here

waterplea · 2024-11-09T09:11:27Z

projects/core/directives/dropdown/dropdown-position.directive.ts

+        const better: TuiVerticalDirection =
+            available.top > available.bottom ? 'top' : 'bottom';
+
+        this.emitDirection(better);


It's not always better, sometimes it's previous, see if on the next line.

waterplea · 2024-11-09T09:12:09Z

projects/legacy/components/input-tag/input-tag.style.less

-        .t-textfield-icon
-        ::ng-deep
-        [tuiAppearance][data-appearance='icon']::after {
+    :host:not(._readonly):not(._disabled):hover .t-textfield-icon ::ng-deep [tuiAppearance][data-appearance='icon']::after {


Weird that this got affected 🤔 You should rollback those style changes. Maybe you need to run npm i to update some lint config packages locally?

waterplea · 2024-11-09T09:24:04Z

projects/core/directives/dropdown/dropdown-position-sided.directive.ts

@@ -10,13 +10,12 @@ import {TuiDropdownPosition} from './dropdown-position.directive';
 @Directive({
    standalone: true,
    selector: '[tuiDropdownSided]',
-    providers: [TuiDropdownPosition, tuiAsPositionAccessor(TuiDropdownPositionSided)],
+    providers: [tuiAsPositionAccessor(TuiDropdownPositionSided)],


Looks like this was still necessary. Please put it back — I'll investigate myself later how so.

…il today`

…mationd-id`

Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>

…mily#9579) Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>

…ts (taiga-family#9595)

…amily#9687)

…9672)

…ily#9681)

…aiga-family#9648) Co-authored-by: Alexandr Shakirov <al.a.shakirov@tinkoff.ru>

…9699)

…-family#9695)

…iga-family#9711) Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>

…Bar` (taiga-family#9654) Co-authored-by: 40oleg <oleg.merkulov701@gmail.com> Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>

…a-family#9715) Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>

shiv9604 requested a review from a team as a code owner October 30, 2024 20:25

shiv9604 requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team October 30, 2024 20:25

shiv9604 force-pushed the feature/3417-dropdown-hint-direction-change branch from 9f85746 to 014c744 Compare October 30, 2024 20:37

waterplea reviewed Nov 5, 2024

View reviewed changes

projects/core/directives/hint/hint.directive.ts Outdated Show resolved Hide resolved

waterplea requested changes Nov 7, 2024

View reviewed changes

projects/core/directives/dropdown/dropdown-position-sided.directive.ts Show resolved Hide resolved

projects/core/directives/dropdown/dropdown.directive.ts Show resolved Hide resolved

projects/core/directives/dropdown/dropdown-position.directive.ts Show resolved Hide resolved

shiv9604 force-pushed the feature/3417-dropdown-hint-direction-change branch from 959fd4d to c0624d6 Compare November 8, 2024 16:32

waterplea reviewed Nov 9, 2024

View reviewed changes

splincode changed the title ~~Feature #3417 - Implement tuiDropdownDirectionChange & tuiHintDirectionChange~~ [WIP] Feature #3417 - Implement tuiDropdownDirectionChange & tuiHintDirectionChange Nov 20, 2024

splincode marked this pull request as draft November 20, 2024 08:12

mdlufy and others added 13 commits November 23, 2024 01:26

chore(demo-playwright): InputDate add test click any day after `Unt…

8460c3d

…il today`

chore(demo-playwright): InputDate use button selector instead `auto…

fbde61c

…mationd-id`

chore(demo-playwright): use CalendarSheet page object

7274113

chore(demo-playwright): CalendarSheet create inside test

a775aee

fix(core): DropdownOpen fix initial open state (taiga-family#9581)

223e867

Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>

fix(layout): Navigation fix drawer positioning (taiga-family#9594)

6a60823

Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>

chore: disable squash automerge in release branch (taiga-family#9560)

ea3b9a6

chore(demo): hide search button if algolia is not available (taiga-fa…

305d114

…mily#9579) Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>

fix(kit): Badge fix font size on desktop (taiga-family#9593)

bf450fa

chore(demo): update description to improve search (taiga-family#9596)

15fa610

feat(legacy): InputTime & InputDateTime support AM / PM forma…

4c49898

…ts (taiga-family#9595)

feat(core): Calendar not switch to large date

55f9d22

feat(addon-mobile): MobileCalendar add (mousedown.prevent)

7f7af36

mdlufy and others added 27 commits November 23, 2024 01:29

fix(legacy): InputDate incorrect value after backspace

25eb2c0

fix(legacy): InputDate nativeValue set empty instead of handle mask

6687fff

chore(legacy): InputDate use activeItem to check

96cadd6

chore(legacy): InputDate add test for several items

1aa4ddf

chore: update dependency @taiga-ui/design-tokens to v0.147.0 (taiga-f…

befc85b

…amily#9687)

chore: explicit run e2e type check (taiga-family#9668)

f8cfea6

chore(release): 4.14.0

8f1d0f6

chore: use *.pw.spec.ts postfix for playwright tests (taiga-family#…

c3a5e46

…9672)

chore: correct inject playwright cache (taiga-family#9670)

525a9ef

fix: remove default styling from a tag in card component (taiga-fam…

a212a8d

…ily#9681)

feat(kit): add ProgressFixedGradient directive for ProgressBar (t…

05f7eaa

…aiga-family#9648) Co-authored-by: Alexandr Shakirov <al.a.shakirov@tinkoff.ru>

chore: update taiga-family/ci action to v1.94.0 (taiga-family#9692)

82a3af7

chore: update dependency @docsearch/js to v3.7.0 (taiga-family#9691)

25edf5b

chore: update dependency cypress to v13.15.2 (taiga-family#9697)

0ca295c

chore: update w9jds/firebase-action action to v13.24.1 (taiga-family#…

60cf64a

…9699)

ci: add shard matrix (taiga-family#9689)

94c683d

ci: add popular e2e chromium flags (taiga-family#9690)

9b99a27

fix(kit): CalendarRange not switch month with selected value (taiga…

47b826b

…-family#9695)

chore(demo): update Textfield + Maskito example (taiga-family#9693)

c569ae3

chore: add migration warnings (taiga-family#9701)

72fe159

chore(demo): prevent DDoS github api from e2e tests (taiga-family#9706)

249ef0f

feat(core): add readable media aliases (taiga-family#9696)

3239faf

feat(core): resolve pr comments

b0c962b

fix(legacy): fix icons looking interactive in readonly textfields (ta…

945542b

…iga-family#9711) Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>

chore(docs): taiga-family#9644 Added top position example for `Action…

4169331

…Bar` (taiga-family#9654) Co-authored-by: 40oleg <oleg.merkulov701@gmail.com> Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>

feat(layout): AppBarBack add ability to use custom appearance (taig…

deabb6d

…a-family#9715) Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>

chore: update meta for db (taiga-family#9703)

9f49f6b

shiv9604 force-pushed the feature/3417-dropdown-hint-direction-change branch from e711ab7 to 9f49f6b Compare November 22, 2024 21:25

shiv9604 closed this Nov 22, 2024

shiv9604 mentioned this pull request Nov 22, 2024

Feature #3417 - Implement tuiDropdownDirectionChange & tuiHintDirectionChange (New branch with clean git history) #9822

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Feature #3417 - Implement tuiDropdownDirectionChange & tuiHintDirectionChange #9645

[WIP] Feature #3417 - Implement tuiDropdownDirectionChange & tuiHintDirectionChange #9645

shiv9604 commented Oct 30, 2024

lumberjack-bot bot commented Oct 30, 2024 •

edited

Loading

bundlemon bot commented Oct 30, 2024 •

edited

Loading

codecov bot commented Oct 30, 2024 •

edited

Loading

waterplea Nov 9, 2024

waterplea Nov 9, 2024

waterplea Nov 9, 2024

waterplea Nov 9, 2024

[WIP] Feature #3417 - Implement tuiDropdownDirectionChange & tuiHintDirectionChange #9645

[WIP] Feature #3417 - Implement tuiDropdownDirectionChange & tuiHintDirectionChange #9645

Conversation

shiv9604 commented Oct 30, 2024

lumberjack-bot bot commented Oct 30, 2024 • edited Loading

Pull request was closed ✔️

bundlemon bot commented Oct 30, 2024 • edited Loading

BundleMon

codecov bot commented Oct 30, 2024 • edited Loading

Codecov Report

waterplea Nov 9, 2024

Choose a reason for hiding this comment

waterplea Nov 9, 2024

Choose a reason for hiding this comment

waterplea Nov 9, 2024

Choose a reason for hiding this comment

waterplea Nov 9, 2024

Choose a reason for hiding this comment

lumberjack-bot bot commented Oct 30, 2024 •

edited

Loading

bundlemon bot commented Oct 30, 2024 •

edited

Loading

codecov bot commented Oct 30, 2024 •

edited

Loading