[Dashboard] Remove VStack #4748

kien-ngo · 2024-09-22T13:05:22Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

The focus of this PR is to replace the VStack components with div elements for layout in various files.

Detailed summary

Replaced VStack with div in OnboardingTitle, JudgesEarn, AvatarShowcase, ReceiveFundsModal, Dashboard, Judges, AirdropUpload, SnapshotUpload, BillingPeriod, HackathonFooter, HackathonEarnFooter, OnboardingSteps, and AccountForm components.

The following files were skipped due to too many changes: apps/dashboard/src/components/settings/Account/AccountForm.tsx, apps/dashboard/src/components/settings/Account/Usage.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-09-22T13:05:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 23, 2024 1:40am

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Sep 23, 2024 1:40am
thirdweb_playground	⬜️ Skipped (Inspect)	Sep 23, 2024 1:40am
wallet-ui	⬜️ Skipped (Inspect)	Sep 23, 2024 1:40am

changeset-bot · 2024-09-22T13:05:27Z

⚠️ No Changeset found

Latest commit: 3d52dd4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-09-22T13:05:28Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

kien-ngo · 2024-09-22T13:05:46Z

[Dashboard] Remove <Code /> component (ez mode) #4787
[Dashboard] Remove <Box/> easy mode #4786
[Dashboard] Remove Flex easy mode #4785
[Dashboard] Remove more Flex #4784
[Dashboard] Remove <Center /> #4765
[Dashboard] Remove <AspectRatio/> #4750
[Dashboard] Remove HStack #4749
[Dashboard] Remove VStack #4748 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite

github-actions · 2024-09-22T13:09:07Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	43.73 KB (0%)	875 ms (0%)	474 ms (+62.93% 🔺)	1.4 s
thirdweb (cjs)	100.91 KB (0%)	2.1 s (0%)	876 ms (+43.61% 🔺)	2.9 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	141 ms (+152.96% 🔺)	238 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	70 ms (+303.65% 🔺)	80 ms
thirdweb/react (minimal + tree-shaking)	16.73 KB (0%)	335 ms (0%)	78 ms (-23.19% 🔽)	413 ms

codecov · 2024-09-22T13:09:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.06%. Comparing base (24ff6f2) to head (3d52dd4).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4748   +/-   ##
=======================================
  Coverage   49.06%   49.06%           
=======================================
  Files        1054     1054           
  Lines       56856    56856           
  Branches     3890     3890           
=======================================
  Hits        27899    27899           
  Misses      28324    28324           
  Partials      633      633

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 24ff6f2
packages	`45.13% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

graphite-app · 2024-09-23T01:28:47Z

Merge activity

Sep 22, 9:28 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 22, 9:28 PM EDT: jnsdls added this pull request to the Graphite merge queue.
Sep 22, 9:40 PM EDT: jnsdls merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview The focus of this PR is to replace the `VStack` components with `div` elements styled using Tailwind CSS classes for layout consistency and improved accessibility. ### Detailed summary - Replaced `VStack` with `div` in multiple components for layout consistency - Used Tailwind CSS classes for styling and spacing - Improved accessibility and readability of the codebase > The following files were skipped due to too many changes: `apps/dashboard/src/components/settings/Account/AccountForm.tsx`, `apps/dashboard/src/components/settings/Account/Usage.tsx` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – wallet-ui September 22, 2024 13:05 Inactive

vercel bot temporarily deployed to Preview – docs-v2 September 22, 2024 13:05 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground September 22, 2024 13:05 Inactive

github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 22, 2024

kien-ngo changed the title ~~Update~~ [Dashboard] Remove VStack Sep 22, 2024

kien-ngo marked this pull request as ready for review September 22, 2024 13:05

kien-ngo requested review from jnsdls, MananTank and joaquim-verges as code owners September 22, 2024 13:05

vercel bot had a problem deploying to Preview – thirdweb-www September 22, 2024 13:10 Failure

kien-ngo force-pushed the kien/remove-vstack-2 branch from fba4fe0 to f336395 Compare September 22, 2024 14:56

vercel bot temporarily deployed to Preview – thirdweb_playground September 22, 2024 14:56 Inactive

vercel bot temporarily deployed to Preview – wallet-ui September 22, 2024 14:56 Inactive

vercel bot temporarily deployed to Preview – docs-v2 September 22, 2024 14:56 Inactive

vercel bot deployed to Preview – thirdweb-www September 22, 2024 15:05 View deployment

This was referenced Sep 22, 2024

[Dashboard] Remove HStack #4749

Merged

[Dashboard] Remove <AspectRatio/> #4750

Merged

jnsdls approved these changes Sep 23, 2024

View reviewed changes

jnsdls added the merge-queue Adds the pull request to Graphite's merge queue. label Sep 23, 2024

jnsdls force-pushed the kien/remove-vstack-2 branch from f336395 to 3d52dd4 Compare September 23, 2024 01:29

vercel bot temporarily deployed to Preview – docs-v2 September 23, 2024 01:30 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground September 23, 2024 01:30 Inactive

vercel bot temporarily deployed to Preview – wallet-ui September 23, 2024 01:30 Inactive

vercel bot deployed to Preview – thirdweb-www September 23, 2024 01:40 View deployment

graphite-app bot merged commit 3d52dd4 into main Sep 23, 2024
31 checks passed

graphite-app bot deleted the kien/remove-vstack-2 branch September 23, 2024 01:40

vercel bot temporarily deployed to Production – docs-v2 September 23, 2024 01:40 Inactive

vercel bot temporarily deployed to Production – wallet-ui September 23, 2024 01:40 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground September 23, 2024 01:40 Inactive

vercel bot deployed to Production – thirdweb-www September 23, 2024 01:50 View deployment

This was referenced Sep 23, 2024

[Dashboard] Remove <Center /> #4765

Merged

[Dashboard] Remove more Flex #4784

Merged

[Dashboard] Remove Flex easy mode #4785

Merged

[Dashboard] Remove <Box/> easy mode #4786

Merged

[Dashboard] Remove <Code /> component (ez mode) #4787

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dashboard] Remove VStack #4748

[Dashboard] Remove VStack #4748

kien-ngo commented Sep 22, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Sep 22, 2024 •

edited

Loading

changeset-bot bot commented Sep 22, 2024 •

edited

Loading

graphite-app bot commented Sep 22, 2024

kien-ngo commented Sep 22, 2024 •

edited

Loading

github-actions bot commented Sep 22, 2024 •

edited

Loading

codecov bot commented Sep 22, 2024 •

edited

Loading

graphite-app bot commented Sep 23, 2024 •

edited

Loading

[Dashboard] Remove VStack #4748

[Dashboard] Remove VStack #4748

Conversation

kien-ngo commented Sep 22, 2024 • edited by pr-codex bot Loading

Problem solved

PR-Codex overview

Detailed summary

vercel bot commented Sep 22, 2024 • edited Loading

changeset-bot bot commented Sep 22, 2024 • edited Loading

⚠️ No Changeset found

graphite-app bot commented Sep 22, 2024

Your org has enabled the Graphite merge queue for merging into main

kien-ngo commented Sep 22, 2024 • edited Loading

github-actions bot commented Sep 22, 2024 • edited Loading

size-limit report 📦

codecov bot commented Sep 22, 2024 • edited Loading

Codecov Report

graphite-app bot commented Sep 23, 2024 • edited Loading

Merge activity

kien-ngo commented Sep 22, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Sep 22, 2024 •

edited

Loading

changeset-bot bot commented Sep 22, 2024 •

edited

Loading

kien-ngo commented Sep 22, 2024 •

edited

Loading

github-actions bot commented Sep 22, 2024 •

edited

Loading

codecov bot commented Sep 22, 2024 •

edited

Loading

graphite-app bot commented Sep 23, 2024 •

edited

Loading