[Dashboard] Remove <AspectRatio/>

[kien-ngo]

Problem solved

Short description of the bug fixed or feature added

---

PR-Codex overview

This PR focuses on removing the AspectRatio component from various files and replacing its usage with div elements styled with Tailwind CSS classes to achieve the same aspect ratio effect.

Detailed summary

• Removed AspectRatio imports from multiple components.
• Replaced AspectRatio usage with div elements using Tailwind CSS classes for aspect ratios.
• Updated related prop types to reflect the removal of AspectRatio.
• Adjusted CSS classes for styling consistency across components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[changeset-bot]

⚠️ No Changeset found

Latest commit: 28f128d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 25, 2024 1:37am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 25, 2024 1:37am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 25, 2024 1:37am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 25, 2024 1:37am

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[kien-ngo]

• [Dashboard] Remove <Code /> component (ez mode) #4787
• [Dashboard] Remove <Box/> easy mode #4786
• [Dashboard] Remove Flex easy mode #4785
• [Dashboard] Remove more Flex #4784
• [Dashboard] Remove <Center /> #4765
• [Dashboard] Remove <AspectRatio/> #4750 👈
• [Dashboard] Remove HStack #4749
• [Dashboard] Remove VStack #4748
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.11%. Comparing base (e2b3484) to head (28f128d).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4750   +/-   ##
=======================================
  Coverage   49.11%   49.11%           
=======================================
  Files        1052     1052           
  Lines       56786    56786           
  Branches     3889     3889           
=======================================
  Hits        27892    27892           
  Misses      28261    28261           
  Partials      633      633           

Flag	Coverage Δ		*Carryforward flag
legacy_packages	65.68% <ø> (ø)		Carriedforward from e2b3484
packages	45.19% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	41.91 KB (0%)	839 ms (0%)	2.4 s (-8.04% 🔽)	3.2 s
thirdweb (cjs)	101.47 KB (0%)	2.1 s (0%)	6.5 s (+8.89% 🔺)	8.6 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	315 ms (+22.87% 🔺)	411 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	222 ms (+253.93% 🔺)	232 ms
thirdweb/react (minimal + tree-shaking)	16.73 KB (0%)	335 ms (0%)	804 ms (-20.76% 🔽)	1.2 s

[kien-ngo]

@jnsdls I didn't know there was another AspectRatio so I mistakenly removed this one. And now the lint is telling me due to this change, @radix-ui/react-aspect-ratio is no longer being used.

So, should we remove said dependency, or use in as the replacement for all the Chakra-ui's AspectRatio?

[kien-ngo]

(I have a feeling you would want to remove the dep)

[jnsdls]

@MananTank had thoughts on this last time it came up, will have him make the decision on what we do here, but either way it's either we use css or we use the component, we have to pick one of the options, not both

[MananTank]

We can replace all AspectRatio components with CSS/tailwind class but my only concern is that it's not a an exact replacement, (I've seen this when I refactored the FileInput component - I had to make some other changes to make the aspect-ratio work exactly as chakra version ).

Lets verify that all changes are working as expected and we are not accidentally breaking the layout. If they are are - feel free to remove all the components with css class

[kien-ngo]

@MananTank yeah it's not working exactly the same you're right. I had to make few minor changes to re-align the inner content (re-center, more like).

I guess that means we stick with @radix-ui/react-aspect-ratio

[MananTank]

Let's replace the instances where it works with just a css class and make changes in other places as needed and remove AspectRatio component