-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Remove <Center /> #4765
base: kien/remove-aspect-ratio
Are you sure you want to change the base?
[Dashboard] Remove <Center /> #4765
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## kien/remove-aspect-ratio #4765 +/- ##
=========================================================
Coverage 49.11% 49.11%
=========================================================
Files 1052 1052
Lines 56786 56786
Branches 3889 3889
=========================================================
Hits 27892 27892
Misses 28261 28261
Partials 633 633
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
3766d3e
to
60caea8
Compare
820183c
to
4da40f1
Compare
60caea8
to
a3e71c4
Compare
apps/dashboard/src/components/FTUX/components/GraphicContainer.tsx
Outdated
Show resolved
Hide resolved
4da40f1
to
0eac344
Compare
4a84e9e
to
fe714cd
Compare
@@ -70,7 +70,7 @@ export const GameCard: React.FC<GameCardProps> = ({ | |||
(max-width: 1200px) 50vw, | |||
33vw" | |||
/> | |||
<Center position="absolute" top={0} bottom={0} left={0} right={0}> | |||
<div className="flex items-center justify-center absolute top-0 bottom-0 left-0 right-0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use inset-0
instead to set all 4 positions
left={0} | ||
bottom={0} | ||
> | ||
<div className="flex items-center justify-center absolute top-0 right-0 left-0 bottom-0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use inset-0
{...getRootProps()} | ||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflict here
@@ -43,6 +47,8 @@ export const UploadStep: React.FC<UploadStepProps> = ({ | |||
borderColor="inputBorder" | |||
borderWidth="1px" | |||
h="100%" | |||
======= | |||
>>>>>>> 4a84e9e04 (temporarily revert Center eslint) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge conflict here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the commit merge conflict markers and address other nits
0eac344
to
ce7d11d
Compare
fe714cd
to
3a43219
Compare
ce7d11d
to
ca08be8
Compare
3a43219
to
ca67048
Compare
ca08be8
to
28f128d
Compare
ca67048
to
f6f1a79
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR primarily focuses on replacing instances of the
Center
component from@chakra-ui/react
withdiv
elements styled using Tailwind CSS classes for alignment and spacing, enhancing the layout consistency across various components.Detailed summary
Center
withdiv
using Tailwind CSS classes in multiple components.TransactionButton.tsx
,PaymentForm.tsx
,YourFilesSection.tsx
, and many more.