-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Remove more Flex #4784
base: kien/remove-chakra-center-component
Are you sure you want to change the base?
[Dashboard] Remove more Flex #4784
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## kien/remove-chakra-center-component #4784 +/- ##
====================================================================
Coverage 49.11% 49.11%
====================================================================
Files 1052 1052
Lines 56786 56786
Branches 3889 3889
====================================================================
Hits 27892 27892
Misses 28261 28261
Partials 633 633
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
a3e71c4
to
4a84e9e
Compare
3eba1e6
to
c5198d1
Compare
4a84e9e
to
fe714cd
Compare
c5198d1
to
5b7f091
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: no need to specify flex-row
everywhere. It's row by default
borderWidth="1px" | ||
h="100%" | ||
======= | ||
>>>>>>> 4a84e9e04 (temporarily revert Center eslint) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be removed in the stack below - not in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the merge conflict removal from this PR to PR in stack below this one
fe714cd
to
3a43219
Compare
5b7f091
to
074ad39
Compare
3a43219
to
ca67048
Compare
074ad39
to
3122865
Compare
ca67048
to
f6f1a79
Compare
3122865
to
fffabec
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on updating the layout of various components in the application by replacing the
Flex
component withdiv
elements that utilize Tailwind CSS classes for styling. This change aims to improve the consistency and responsiveness of the UI.Detailed summary
Flex
withdiv
using Tailwind CSS classes in multiple components.gap
anddirection
through Tailwind classes.GraphicContainer
,contract-functions
,engine-overview
,Timer
,add-keypair-button
,metadata
,metadata-header
,claim-conditions-form
,PricingCard
,AccountSigner
,ChainValidation
,CreditsItem
, and more.