-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Remove <Code /> component (ez mode) #4787
base: kien/remove-Box-easy-mode
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
37a05d3
to
2884702
Compare
730ea1f
to
48eed45
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## kien/remove-Box-easy-mode #4787 +/- ##
==========================================================
Coverage 49.11% 49.11%
==========================================================
Files 1052 1052
Lines 56786 56786
Branches 3889 3889
==========================================================
Hits 27892 27892
Misses 28261 28261
Partials 633 633
*This pull request uses carry forward flags. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think unstyled code element looks similar to Chakra Code component. Can you verify? Most likely we'll need to add background, a bit of padding, rounded corners etc
We can make a |
2884702
to
1bb0f00
Compare
48eed45
to
e4cb1f4
Compare
1bb0f00
to
9dda291
Compare
e4cb1f4
to
f2b799e
Compare
9dda291
to
eed59aa
Compare
f2b799e
to
0dfefeb
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on changing the usage of the
Code
component to a standard HTML<code>
tag across various components in the application, improving consistency in code representation.Detailed summary
Code
component with<code>
tag inChainValidation
,EngineCorsConfig
,EngineIpAllowlistConfig
,ContractPermissionsPage
,engine-access-tokens
,SnapshotUpload
, andUploadStep
components.