Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Remove <Code /> component (ez mode) #4787

Open
wants to merge 1 commit into
base: kien/remove-Box-easy-mode
Choose a base branch
from

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Sep 24, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on changing the usage of the Code component to a standard HTML <code> tag across various components in the application, improving consistency in code representation.

Detailed summary

  • Replaced Code component with <code> tag in ChainValidation, EngineCorsConfig, EngineIpAllowlistConfig, ContractPermissionsPage, engine-access-tokens, SnapshotUpload, and UploadStep components.
  • Ensured consistent styling and semantics for code snippets.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 24, 2024

⚠️ No Changeset found

Latest commit: 0dfefeb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 24, 2024
@kien-ngo kien-ngo changed the title Remove <Code /> component` [Dashboard] Remove <Code /> component (ez mode) Sep 24, 2024
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 24, 2024 15:02 Inactive
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 1:46am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 25, 2024 1:46am
thirdweb_playground ⬜️ Skipped (Inspect) Sep 25, 2024 1:46am
wallet-ui ⬜️ Skipped (Inspect) Sep 25, 2024 1:46am

@kien-ngo kien-ngo marked this pull request as ready for review September 24, 2024 15:02
Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Sep 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor

github-actions bot commented Sep 24, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.91 KB (0%) 839 ms (0%) 638 ms (+118.54% 🔺) 1.5 s
thirdweb (cjs) 101.47 KB (0%) 2.1 s (0%) 716 ms (-20.68% 🔽) 2.8 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 170 ms (+798.88% 🔺) 267 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 73 ms (+542.83% 🔺) 83 ms
thirdweb/react (minimal + tree-shaking) 16.73 KB (0%) 335 ms (0%) 66 ms (-14.74% 🔽) 401 ms

@vercel vercel bot temporarily deployed to Preview – wallet-ui September 24, 2024 15:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 24, 2024 15:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 24, 2024 15:08 Inactive
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.11%. Comparing base (eed59aa) to head (0dfefeb).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           kien/remove-Box-easy-mode    #4787   +/-   ##
==========================================================
  Coverage                      49.11%   49.11%           
==========================================================
  Files                           1052     1052           
  Lines                          56786    56786           
  Branches                        3889     3889           
==========================================================
  Hits                           27892    27892           
  Misses                         28261    28261           
  Partials                         633      633           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 2e346f5
packages 45.19% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think unstyled code element looks similar to Chakra Code component. Can you verify? Most likely we'll need to add background, a bit of padding, rounded corners etc

Copy link
Member

We can make a InlineCode component and use it everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants