Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Create Umbraco/Bellissima Package (Take Two) #17044

Closed
wants to merge 17 commits into from
Closed

[WIP] Create Umbraco/Bellissima Package (Take Two) #17044

wants to merge 17 commits into from

Conversation

warrenbuckley
Copy link
Contributor

This PR is to rework & reopen the work that @leekelleher done from the previous years community teams day
#14975

leekelleher and others added 15 commits September 22, 2023 13:28
@leekelleher
[WIP] Create Umbraco/Bellissima Package
36863a4
@erikjanwestendorp @lauraneto
Add Content-Security-Policy (CSP) health check (umbraco#16830)
a235591 
* Add CSP Header Check

* Update src/Umbraco.Core/EmbeddedResources/Lang/en.xml

Co-authored-by: Laura Neto <12862535+lauraneto@users.noreply.github.com>

* Update src/Umbraco.Core/EmbeddedResources/Lang/en_us.xml

Co-authored-by: Laura Neto <12862535+lauraneto@users.noreply.github.com>

---------

Co-authored-by: Laura Neto <12862535+lauraneto@users.noreply.github.com>
@PeterKvayt
Making method ExecuteAsync virtual. (umbraco#16496)
3a9ef38 
Co-authored-by: Kvyatkovsky, Petr <pkvyatkovsky@qulix.com>
@JasonElkin
Issue-15712: MemberDefaultLockoutTimeInMinutes fix.
80b8b2a
@nul800sebastiaan
Merge branch 'v14/dev' into contrib
3560fc9
@EmanuelGustafzon
Stripped username before login (umbraco#16921)
9338395 
* Stripped username before login
@matthewcare
Cache a dictionary of dictionaries (umbraco#15908)
3b6fbf1 
* Re-commit change

Re-commit change after merge

* Fix issues after merge

Update usings after merge

* Re-delete obsolete

Remove the obsolete method
@dependabot @JasonElkin
Bump axios from 1.6.5 to 1.7.4 in /tests/Umbraco.Tests.AcceptanceTest
e805197 
Bumps [axios](https://github.com/axios/axios) from 1.6.5 to 1.7.4.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.6.5...v1.7.4)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@JasonElkin @Matthew-Wise
Ignore Visual Studio's generated launchSettings file.
862e45e
@CodeBunTes @emmagarland
Update valid reasons not to have a template on a content node to incl…
385a534 
…ude having a redirect field
@emmagarland
Remove warnings from Umbraco.Web.UI (umbraco#16958)
148d51b 
* Fixed warning SA1119 for Umbraco.Web.UI project (unnecessary parenthesis)

* Remove parenthesis (startup no longer exists)

---------

Co-authored-by: Emma Garland <emma.garland@rocksolidknowledge.com>
@emmagarland @Migaroez
Treat warnings as errors for initial projects (umbraco#15019)
98e9a30 
* Treat warnings as errors for Umbraco.Cms, Umbraco.Cms.Api.Common and Umbraco.Cms.Api.Delivery projects.

* Treat warnings as errors for Umbraco.Cms.Imaging.ImageSharp and Umbraco.Cms.Imaging.ImageSharp2 projects

* Treat warnings as errors for Umbraco.Cms.Persistence.EFCore.Sqlite, Umbraco.Cms.Persistence.EFCore.SqlServer and Umbraco.Cms.StaticAssets

* Treat warnings as errors for Umbraco.Cms.Targets

* Treat warnings as errors for templates/Umbraco.Templates and Umbraco.JsonSchema

* More projects with warnings as errors.

* Reverted warnings as errors due to some file changes since the update.

* Remove unwanted tag

* Removed warnings as errors on TestData project

* Implement warnings as errors in props file, and exclude specific warnings where appropriate as per PR review suggestions.

* Reverted spaces

* Revert "Reverted spaces"

This reverts commit 3734c45.

* Update sdk version to fully support Umbraco.code 2.2.0 dependency on Microsoft.CodeAnalysis.CSharp.Workspaces 4.10.0

* Ignore PathToLongErrors for now in static assets

---------

Co-authored-by: Emma Garland <emma.garland@rocksolidknowledge.com>
Co-authored-by: Sven Geusens <sge@umbraco.dk>
@marwaldv @Matthew-Wise
Update LogDto.cs
7acce83 
fix: issue resolved, where content saving breaks due to saving to umbracoLog with error message like that: String or binary data would be truncated in table 'dto.umbracoLog', column 'parameters'. Truncated value: 'English (United States), German (Switzerland), French (France), Italian (Italy), Arabic (Iraq), Pers'...
@kasparboelkjeldsen
ModelsGenerator to IModelsGenerator in BuildModelsBuilderController (u…
3d5e706 
…mbraco#16919)

* ModelsGenerator to IModelsGenerator in BuildModelsBuilderController

* Added obsolete constructors for backwards compatibility
@emmagarland
Resolved more warnings, and marked more warning types as errors (umbr…
862820c 
…aco#16990)

* Fix warnings SA1111, SA1028, SA1500, IDE1270  in Umbraco.Web.Website, and updated rules.

* Remove warnings: IDE0270: Null check can be simplified

* More SqlServer project warnings resolved

* CS0105 namespace appeared already

* Suppress warning until implementation:

#pragma warning disable CS0162 // Unreachable code detected
#pragma warning disable CS0618 // Type or member is obsolete

CS0162 remove unreachable code
SA1028 remove trailing whitespace
SA1106 no empty statements
CS1570 malformed XML
CS1572 corrected xml parameter
CS1573 param tag added
IDE0007 var not explicit
IDE0008 explicit not var
IDE0057 simplify substring
IDE0074 compound assignment
CA1825 array.empty

Down to 3479 warnings
@warrenbuckley warrenbuckley changed the title [WIP] Create Umbraco/Bellissima Package [WIP] Create Umbraco/Bellissima Package (Take Two) Sep 11, 2024
@github-actions GitHub Actions
Copy link

Hi there @warrenbuckley, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@warrenbuckley
Copy link
Contributor Author

OK PR is now in a state that this can be worked on and finish up what Lee started

@ronaldbarendse
Copy link
Contributor

Great start on this Warren! 💪🏻

If this targets v15, we should probably take the opportunity to make the umbraco-package-rcl the default (remove the one that uses the build targets and rename the RCL one to umbraco-package), see PR: #15258.

@warrenbuckley
Copy link
Contributor Author

@ronaldbarendse should I target v15/dev as opposed to contrib then?

@leekelleher leekelleher mentioned this pull request Sep 16, 2024
Closed
1 task
@ronaldbarendse ronaldbarendse changed the base branch from contrib to v15/dev September 18, 2024 11:38
@warrenbuckley
Copy link
Contributor Author

Going to recreate this PR again and cherry pick Lee's commit so we do it from v15/dev
Even after merging v15/dev into this branch seems to be a bit too much going on

@warrenbuckley
Copy link
Contributor Author

Closing PR as reworked PR targeting V15/dev with @leekelleher original commit/work from his fork

@warrenbuckley warrenbuckley deleted the v14/wip/create-bellissima-package branch September 21, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.