-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge hashicorp 3.34.0 into main #1
Commits on Mar 19, 2021
-
Merge pull request #18304 from hashicorp/t-stragglers-errorcheck4
tests/STRAGGLERS: Add ErrorCheck (Part IV - The semi-lastish one??)
Configuration menu - View commit details
-
Copy full SHA for 476c604 - Browse repository at this point
Copy the full SHA 476c604View commit details -
tests/provider: Use string matching in testAccErrorCheckCommon() and …
…catch all InvalidAction (#18283) Reference: #17566 Previously in AWS GovCloud (US): ``` === CONT TestAccAwsEc2ClientVpn_serial/NetworkAssociation_multipleSubnets resource_aws_ec2_client_vpn_network_association_test.go:144: Step 1/3 error: Error running apply: exit status 1 Error: Error creating Client VPN endpoint: InvalidAction: The action CreateClientVpnEndpoint is not valid for this web service. status code: 400, request id: 387e7807-e2b8-4314-9aa8-6cf2e33a0ded on terraform_plugin_test.tf line 61, in resource "aws_ec2_client_vpn_endpoint" "test": 61: resource "aws_ec2_client_vpn_endpoint" "test" { === CONT TestAccAwsEc2ClientVpn_serial/NetworkAssociation_securityGroups resource_aws_ec2_client_vpn_network_association_test.go:211: Step 1/3 error: Error running apply: exit status 1 Error: Error creating Client VPN endpoint: InvalidAction: The action CreateClientVpnEndpoint is not valid for this web service. status code: 400, request id: ad7a3b32-b650-4683-a7e0-945481550c6d on terraform_plugin_test.tf line 57, in resource "aws_ec2_client_vpn_endpoint" "test": 57: resource "aws_ec2_client_vpn_endpoint" "test" { === CONT TestAccAwsEc2ClientVpn_serial/NetworkAssociation_disappears resource_aws_ec2_client_vpn_network_association_test.go:186: Step 1/1 error: Error running apply: exit status 1 Error: Error creating Client VPN endpoint: InvalidAction: The action CreateClientVpnEndpoint is not valid for this web service. status code: 400, request id: feed7ccb-95a7-411f-b633-da58e8340392 on terraform_plugin_test.tf line 56, in resource "aws_ec2_client_vpn_endpoint" "test": 56: resource "aws_ec2_client_vpn_endpoint" "test" { === CONT TestAccAwsEc2ClientVpn_serial/NetworkAssociation_basic resource_aws_ec2_client_vpn_network_association_test.go:105: Step 1/2 error: Error running apply: exit status 1 Error: Error creating Client VPN endpoint: InvalidAction: The action CreateClientVpnEndpoint is not valid for this web service. status code: 400, request id: 3f31766a-9288-4e46-9f35-6d7922e938ac on terraform_plugin_test.tf line 56, in resource "aws_ec2_client_vpn_endpoint" "test": 56: resource "aws_ec2_client_vpn_endpoint" "test" { --- FAIL: TestAccAwsEc2ClientVpn_serial (0.54s) --- FAIL: TestAccAwsEc2ClientVpn_serial/NetworkAssociation_securityGroups (32.03s) --- FAIL: TestAccAwsEc2ClientVpn_serial/NetworkAssociation_multipleSubnets (32.06s) --- FAIL: TestAccAwsEc2ClientVpn_serial/NetworkAssociation_disappears (31.96s) --- FAIL: TestAccAwsEc2ClientVpn_serial/NetworkAssociation_basic (33.01s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsEc2ClientVpn_serial (0.41s) --- SKIP: TestAccAwsEc2ClientVpn_serial/NetworkAssociation_disappears (30.61s) --- SKIP: TestAccAwsEc2ClientVpn_serial/NetworkAssociation_securityGroups (31.10s) --- SKIP: TestAccAwsEc2ClientVpn_serial/NetworkAssociation_basic (31.01s) ```
Configuration menu - View commit details
-
Copy full SHA for 5a9fa75 - Browse repository at this point
Copy the full SHA 5a9fa75View commit details -
tests/provider: Fix and enable linting for immediate dereference afte…
Configuration menu - View commit details
-
Copy full SHA for aeb3456 - Browse repository at this point
Copy the full SHA aeb3456View commit details -
tests/provider: Fix compilation-time randomization in test configurat…
…ion, enable semgrep rule to catch coding issue (#18220) Reference: #18175 Reference: #18204 Also adds `ErrorCheck` while adjusting these tests. Previously: ``` aws/data_source_aws_cloudfront_distribution_test.go severity:warning rule:helper-acctest-RandInt-compiled: Using `acctest.RandInt()` in constant or variable declaration will execute during compilation and not randomize, pass into string generating function instead 36:var testAccAWSCloudFrontDistributionData = fmt.Sprintf(` 37:%s 38: 39:data "aws_cloudfront_distribution" "test" { 40: id = aws_cloudfront_distribution.s3_distribution.id 41:} 42:`, fmt.Sprintf(testAccAWSCloudFrontDistributionS3ConfigWithTags, acctest.RandInt(), originBucket, logBucket, testAccAWSCloudFrontDistributionRetainConfig())) aws/data_source_aws_ecs_cluster_test.go severity:warning rule:helper-acctest-RandInt-compiled: Using `acctest.RandInt()` in constant or variable declaration will execute during compilation and not randomize, pass into string generating function instead 50:var testAccCheckAwsEcsClusterDataSourceConfig = fmt.Sprintf(` 51:resource "aws_ecs_cluster" "default" { 52: name = "default-%d" 53:} 54: 55:data "aws_ecs_cluster" "default" { 56: cluster_name = aws_ecs_cluster.default.name 57:} 58:`, acctest.RandInt()) -------------------------------------------------------------------------------- 60:var testAccCheckAwsEcsClusterDataSourceConfigContainerInsights = fmt.Sprintf(` 61:resource "aws_ecs_cluster" "default" { 62: name = "default-%d" 63: 64: setting { 65: name = "containerInsights" 66: value = "enabled" 67: } 68:} 69: -------- [hid 4 additional lines, adjust with --max-lines-per-finding] --------- aws/data_source_aws_ecs_service_test.go severity:warning rule:helper-acctest-RandInt-compiled: Using `acctest.RandInt()` in constant or variable declaration will execute during compilation and not randomize, pass into string generating function instead 34:var testAccCheckAwsEcsServiceDataSourceConfig = fmt.Sprintf(` 35:resource "aws_ecs_cluster" "test" { 36: name = "tf-acc-%d" 37:} 38: 39:resource "aws_ecs_task_definition" "test" { 40: family = "mongodb" 41: 42: container_definitions = <<DEFINITION 43:[ -------- [hid 24 additional lines, adjust with --max-lines-per-finding] -------- aws/resource_aws_cloudfront_distribution_test.go severity:warning rule:helper-acctest-RandInt-compiled: Using `acctest.RandInt()` in constant or variable declaration will execute during compilation and not randomize, pass into string generating function instead 1439:var testAccAWSCloudFrontDistributionCustomConfig = fmt.Sprintf(` 1440:variable rand_id { 1441: default = %d 1442:} 1443: 1444:# log bucket 1445:%s 1446: 1447:resource "aws_cloudfront_distribution" "custom_distribution" { 1448: origin { -------- [hid 59 additional lines, adjust with --max-lines-per-finding] -------- 1509:var testAccAWSCloudFrontDistributionOriginRequestPolicyConfigDefault = fmt.Sprintf(` 1510:variable rand_id { 1511: default = %[1]d 1512:} 1513: 1514:# log bucket 1515:%[2]s 1516: 1517:resource "aws_cloudfront_cache_policy" "example" { 1518: name = "test-policy%[1]d" ------- [hid 100 additional lines, adjust with --max-lines-per-finding] -------- 1620:var testAccAWSCloudFrontDistributionOriginRequestPolicyConfigOrdered = fmt.Sprintf(` 1621:variable rand_id { 1622: default = %[1]d 1623:} 1624: 1625:# log bucket 1626:%[2]s 1627: 1628:resource "aws_cloudfront_cache_policy" "example" { 1629: name = "test-policy%[1]d" ------- [hid 113 additional lines, adjust with --max-lines-per-finding] -------- 1744:var testAccAWSCloudFrontDistributionMultiOriginConfig = fmt.Sprintf(` 1745:variable rand_id { 1746: default = %d 1747:} 1748: 1749:# origin bucket 1750:%s 1751: 1752:# log bucket 1753:%s ------- [hid 112 additional lines, adjust with --max-lines-per-finding] -------- 1867:var testAccAWSCloudFrontDistributionNoCustomErroResponseInfo = fmt.Sprintf(` 1868:variable rand_id { 1869: default = %d 1870:} 1871: 1872:resource "aws_cloudfront_distribution" "no_custom_error_responses" { 1873: origin { 1874: domain_name = "www.example.com" 1875: origin_id = "myCustomOrigin" 1876: -------- [hid 50 additional lines, adjust with --max-lines-per-finding] -------- 1928:var testAccAWSCloudFrontDistributionNoOptionalItemsConfig = fmt.Sprintf(` 1929:variable rand_id { 1930: default = %d 1931:} 1932: 1933:resource "aws_cloudfront_distribution" "no_optional_items" { 1934: origin { 1935: domain_name = "www.example.com" 1936: origin_id = "myCustomOrigin" 1937: -------- [hid 41 additional lines, adjust with --max-lines-per-finding] -------- 2076:var testAccAWSCloudFrontDistributionHTTP11Config = fmt.Sprintf(` 2077:variable rand_id { 2078: default = %d 2079:} 2080: 2081:resource "aws_cloudfront_distribution" "http_1_1" { 2082: origin { 2083: domain_name = "www.example.com" 2084: origin_id = "myCustomOrigin" 2085: -------- [hid 47 additional lines, adjust with --max-lines-per-finding] -------- 2134:var testAccAWSCloudFrontDistributionIsIPV6EnabledConfig = fmt.Sprintf(` 2135:variable rand_id { 2136: default = %d 2137:} 2138: 2139:resource "aws_cloudfront_distribution" "is_ipv6_enabled" { 2140: origin { 2141: domain_name = "www.example.com" 2142: origin_id = "myCustomOrigin" 2143: -------- [hid 48 additional lines, adjust with --max-lines-per-finding] -------- 2193:var testAccAWSCloudFrontDistributionOrderedCacheBehavior = fmt.Sprintf(` 2194:variable rand_id { 2195: default = %d 2196:} 2197: 2198:resource "aws_cloudfront_distribution" "main" { 2199: origin { 2200: domain_name = "www.hashicorp.com" 2201: origin_id = "myCustomOrigin" 2202: -------- [hid 86 additional lines, adjust with --max-lines-per-finding] -------- 2290:var testAccAWSCloudFrontDistributionOrderedCacheBehaviorCachePolicy = fmt.Sprintf(` 2291:variable rand_id { 2292: default = %d 2293:} 2294: 2295:resource "aws_cloudfront_distribution" "main" { 2296: origin { 2297: domain_name = "www.hashicorp.com" 2298: origin_id = "myCustomOrigin" 2299: -------- [hid 73 additional lines, adjust with --max-lines-per-finding] -------- aws/resource_aws_elasticache_cluster_test.go severity:warning rule:helper-acctest-RandInt-compiled: Using `acctest.RandInt()` in constant or variable declaration will execute during compilation and not randomize, pass into string generating function instead 1025:var testAccAWSElasticacheClusterInVPCConfig = fmt.Sprintf(` 1026:data "aws_availability_zones" "available" { 1027: state = "available" 1028: 1029: filter { 1030: name = "opt-in-status" 1031: values = ["opt-in-not-required"] 1032: } 1033:} 1034: -------- [hid 58 additional lines, adjust with --max-lines-per-finding] -------- 1094:var testAccAWSElasticacheClusterMultiAZInVPCConfig = fmt.Sprintf(` 1095:data "aws_availability_zones" "available" { 1096: state = "available" 1097: 1098: filter { 1099: name = "opt-in-status" 1100: values = ["opt-in-not-required"] 1101: } 1102:} 1103: -------- [hid 65 additional lines, adjust with --max-lines-per-finding] -------- aws/resource_aws_elasticache_replication_group_test.go severity:warning rule:helper-acctest-RandInt-compiled: Using `acctest.RandInt()` in constant or variable declaration will execute during compilation and not randomize, pass into string generating function instead 1661:var testAccAWSElasticacheReplicationGroupInVPCConfig = fmt.Sprintf(` 1662:data "aws_availability_zones" "available" { 1663: state = "available" 1664: 1665: filter { 1666: name = "opt-in-status" 1667: values = ["opt-in-not-required"] 1668: } 1669:} 1670: -------- [hid 49 additional lines, adjust with --max-lines-per-finding] -------- ran 12 rules on 2158 files: 17 findings ``` Output from acceptance testing: ``` --- PASS: TestAccAWSCloudFrontDistribution_customOrigin (377.36s) --- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (202.77s) --- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Headers (191.20s) --- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn (247.51s) --- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners (199.05s) --- PASS: TestAccAWSCloudFrontDistribution_disappears (176.21s) --- PASS: TestAccAWSCloudFrontDistribution_Enabled (541.17s) --- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (399.22s) --- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (399.21s) --- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (355.41s) --- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (399.84s) --- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (388.59s) --- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (373.92s) --- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (236.34s) --- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Headers (192.33s) --- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn (246.39s) --- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehaviorCachePolicy (371.56s) --- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (5.01s) --- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (0.92s) --- PASS: TestAccAWSCloudFrontDistribution_OriginGroups (338.79s) --- PASS: TestAccAWSCloudFrontDistribution_originPolicyDefault (400.05s) --- PASS: TestAccAWSCloudFrontDistribution_originPolicyOrdered (342.41s) --- PASS: TestAccAWSCloudFrontDistribution_RetainOnDelete (401.36s) --- PASS: TestAccAWSCloudFrontDistribution_S3Origin (313.50s) --- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (459.80s) --- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (152.71s) --- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (162.56s) --- PASS: TestAccAWSCloudFrontDistribution_WaitForDeployment (315.88s) --- PASS: TestAccAWSDataSourceCloudFrontDistribution_basic (400.44s) --- PASS: TestAccAWSEcsDataSource_ecsCluster (27.24s) --- PASS: TestAccAWSEcsDataSource_ecsClusterContainerInsights (24.25s) --- PASS: TestAccAWSEcsServiceDataSource_basic (84.98s) --- PASS: TestAccAWSElasticacheCluster_multiAZInVpc (747.82s) --- PASS: TestAccAWSElasticacheCluster_vpc (614.42s) --- PASS: TestAccAWSElasticacheReplicationGroup_vpc (805.50s) ```
Configuration menu - View commit details
-
Copy full SHA for 5ef790a - Browse repository at this point
Copy the full SHA 5ef790aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cad84e - Browse repository at this point
Copy the full SHA 0cad84eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 421a04b - Browse repository at this point
Copy the full SHA 421a04bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6088992 - Browse repository at this point
Copy the full SHA 6088992View commit details -
Configuration menu - View commit details
-
Copy full SHA for d99259b - Browse repository at this point
Copy the full SHA d99259bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0136db7 - Browse repository at this point
Copy the full SHA 0136db7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4463aa5 - Browse repository at this point
Copy the full SHA 4463aa5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9295caf - Browse repository at this point
Copy the full SHA 9295cafView commit details -
Configuration menu - View commit details
-
Copy full SHA for e81f53b - Browse repository at this point
Copy the full SHA e81f53bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01f6ac3 - Browse repository at this point
Copy the full SHA 01f6ac3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8444cf8 - Browse repository at this point
Copy the full SHA 8444cf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47d5a7e - Browse repository at this point
Copy the full SHA 47d5a7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19e389b - Browse repository at this point
Copy the full SHA 19e389bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4077e0f - Browse repository at this point
Copy the full SHA 4077e0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc94185 - Browse repository at this point
Copy the full SHA bc94185View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2307a52 - Browse repository at this point
Copy the full SHA 2307a52View commit details -
Configuration menu - View commit details
-
Copy full SHA for f743c2f - Browse repository at this point
Copy the full SHA f743c2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0047d7 - Browse repository at this point
Copy the full SHA b0047d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9a5b26 - Browse repository at this point
Copy the full SHA a9a5b26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3551a55 - Browse repository at this point
Copy the full SHA 3551a55View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba97e4f - Browse repository at this point
Copy the full SHA ba97e4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ce4975 - Browse repository at this point
Copy the full SHA 9ce4975View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa38e8a - Browse repository at this point
Copy the full SHA fa38e8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1507cb7 - Browse repository at this point
Copy the full SHA 1507cb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for bab4c56 - Browse repository at this point
Copy the full SHA bab4c56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9752cd1 - Browse repository at this point
Copy the full SHA 9752cd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 630f177 - Browse repository at this point
Copy the full SHA 630f177View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7728f4 - Browse repository at this point
Copy the full SHA d7728f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 280acc2 - Browse repository at this point
Copy the full SHA 280acc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed17b3d - Browse repository at this point
Copy the full SHA ed17b3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54b80ad - Browse repository at this point
Copy the full SHA 54b80adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e5cd3a - Browse repository at this point
Copy the full SHA 0e5cd3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c2deae - Browse repository at this point
Copy the full SHA 1c2deaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 76aea30 - Browse repository at this point
Copy the full SHA 76aea30View commit details -
Configuration menu - View commit details
-
Copy full SHA for d45b7b8 - Browse repository at this point
Copy the full SHA d45b7b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29e313c - Browse repository at this point
Copy the full SHA 29e313cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d881d6 - Browse repository at this point
Copy the full SHA 5d881d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6826f36 - Browse repository at this point
Copy the full SHA 6826f36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02c17a5 - Browse repository at this point
Copy the full SHA 02c17a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9773f18 - Browse repository at this point
Copy the full SHA 9773f18View commit details -
Configuration menu - View commit details
-
Copy full SHA for e259875 - Browse repository at this point
Copy the full SHA e259875View commit details -
Configuration menu - View commit details
-
Copy full SHA for 637dd31 - Browse repository at this point
Copy the full SHA 637dd31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55e2b39 - Browse repository at this point
Copy the full SHA 55e2b39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70dfa1a - Browse repository at this point
Copy the full SHA 70dfa1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c338c0e - Browse repository at this point
Copy the full SHA c338c0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6615b9f - Browse repository at this point
Copy the full SHA 6615b9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a4cfb4 - Browse repository at this point
Copy the full SHA 6a4cfb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa76add - Browse repository at this point
Copy the full SHA fa76addView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff7ea3a - Browse repository at this point
Copy the full SHA ff7ea3aView commit details -
tests/provider: Add missing ErrorCheck to TestCase (#18306)
* tests/provider: Add missing ErrorCheck to TestCase Reference: #18175 Previously: ``` aws/resource_aws_iam_group_policy_test.go:88:36: XAT001: missing ErrorCheck aws/resource_aws_iam_group_policy_test.go:128:36: XAT001: missing ErrorCheck aws/resource_aws_iam_instance_profile_test.go:75:36: XAT001: missing ErrorCheck aws/resource_aws_iam_role_policy_test.go:102:36: XAT001: missing ErrorCheck aws/resource_aws_iam_role_policy_test.go:147:36: XAT001: missing ErrorCheck aws/resource_aws_iam_role_test.go:222:36: XAT001: missing ErrorCheck aws/resource_aws_iam_user_policy_test.go:96:36: XAT001: missing ErrorCheck aws/resource_aws_iam_user_policy_test.go:138:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:237:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:270:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:399:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:443:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:534:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:610:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:664:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:720:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:779:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:813:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:843:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:871:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:970:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:997:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:1034:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:1265:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:1321:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:1385:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:1422:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:1462:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:1504:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:1564:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:3327:36: XAT001: missing ErrorCheck aws/resource_aws_instance_test.go:3924:36: XAT001: missing ErrorCheck aws/resource_aws_internet_gateway_test.go:143:36: XAT001: missing ErrorCheck aws/resource_aws_internet_gateway_test.go:189:36: XAT001: missing ErrorCheck aws/resource_aws_internet_gateway_test.go:213:36: XAT001: missing ErrorCheck aws/resource_aws_key_pair_test.go:170:36: XAT001: missing ErrorCheck aws/resource_aws_nat_gateway_test.go:63:36: XAT001: missing ErrorCheck aws/resource_aws_network_acl_test.go:310:36: XAT001: missing ErrorCheck aws/resource_aws_network_acl_test.go:352:36: XAT001: missing ErrorCheck aws/resource_aws_network_acl_test.go:386:36: XAT001: missing ErrorCheck aws/resource_aws_network_acl_test.go:441:36: XAT001: missing ErrorCheck aws/resource_aws_network_acl_test.go:466:36: XAT001: missing ErrorCheck aws/resource_aws_network_acl_test.go:494:36: XAT001: missing ErrorCheck aws/resource_aws_network_acl_test.go:539:36: XAT001: missing ErrorCheck aws/resource_aws_network_acl_test.go:587:36: XAT001: missing ErrorCheck aws/resource_aws_network_acl_test.go:623:36: XAT001: missing ErrorCheck aws/resource_aws_network_acl_test.go:679:36: XAT001: missing ErrorCheck aws/resource_aws_network_acl_test.go:709:36: XAT001: missing ErrorCheck aws/resource_aws_network_interface_attachment_test.go:16:36: XAT001: missing ErrorCheck aws/resource_aws_network_interface_test.go:74:36: XAT001: missing ErrorCheck aws/resource_aws_network_interface_test.go:108:36: XAT001: missing ErrorCheck aws/resource_aws_network_interface_test.go:155:36: XAT001: missing ErrorCheck aws/resource_aws_network_interface_test.go:200:36: XAT001: missing ErrorCheck aws/resource_aws_network_interface_test.go:269:36: XAT001: missing ErrorCheck aws/resource_aws_network_interface_test.go:302:36: XAT001: missing ErrorCheck aws/resource_aws_network_interface_test.go:330:36: XAT001: missing ErrorCheck aws/resource_aws_network_interface_test.go:358:36: XAT001: missing ErrorCheck aws/resource_aws_network_interface_test.go:398:36: XAT001: missing ErrorCheck aws/resource_aws_opsworks_stack_test.go:228:36: XAT001: missing ErrorCheck aws/resource_aws_route_table_test.go:231:36: XAT001: missing ErrorCheck aws/resource_aws_route_table_test.go:281:36: XAT001: missing ErrorCheck aws/resource_aws_route_table_test.go:316:36: XAT001: missing ErrorCheck aws/resource_aws_route_table_test.go:354:36: XAT001: missing ErrorCheck aws/resource_aws_route_table_test.go:398:36: XAT001: missing ErrorCheck aws/resource_aws_route_table_test.go:416:36: XAT001: missing ErrorCheck aws/resource_aws_route_table_test.go:735:36: XAT001: missing ErrorCheck aws/resource_aws_route_table_test.go:770:36: XAT001: missing ErrorCheck aws/resource_aws_route_table_test.go:913:36: XAT001: missing ErrorCheck aws/resource_aws_security_group_test.go:686:36: XAT001: missing ErrorCheck aws/resource_aws_security_group_test.go:1058:36: XAT001: missing ErrorCheck aws/resource_aws_security_group_test.go:1238:36: XAT001: missing ErrorCheck aws/resource_aws_security_group_test.go:1273:36: XAT001: missing ErrorCheck aws/resource_aws_security_group_test.go:1317:36: XAT001: missing ErrorCheck aws/resource_aws_security_group_test.go:1354:36: XAT001: missing ErrorCheck aws/resource_aws_security_group_test.go:1390:36: XAT001: missing ErrorCheck aws/resource_aws_security_group_test.go:1416:36: XAT001: missing ErrorCheck aws/resource_aws_security_group_test.go:1449:36: XAT001: missing ErrorCheck aws/resource_aws_security_group_test.go:1561:36: XAT001: missing ErrorCheck aws/resource_aws_subnet_test.go:130:36: XAT001: missing ErrorCheck aws/resource_aws_subnet_test.go:167:36: XAT001: missing ErrorCheck aws/resource_aws_subnet_test.go:211:36: XAT001: missing ErrorCheck aws/resource_aws_subnet_test.go:268:36: XAT001: missing ErrorCheck aws/resource_aws_subnet_test.go:310:36: XAT001: missing ErrorCheck aws/resource_aws_subnet_test.go:352:36: XAT001: missing ErrorCheck aws/resource_aws_subnet_test.go:416:36: XAT001: missing ErrorCheck aws/resource_aws_subnet_test.go:474:36: XAT001: missing ErrorCheck aws/resource_aws_subnet_test.go:497:36: XAT001: missing ErrorCheck aws/resource_aws_subnet_test.go:563:36: XAT001: missing ErrorCheck aws/resource_aws_subnet_test.go:603:36: XAT001: missing ErrorCheck aws/resource_aws_subnet_test.go:646:36: XAT001: missing ErrorCheck aws/resource_aws_subnet_test.go:789:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_endpoint_connection_notification_test.go:19:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_endpoint_test.go:481:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_peering_connection_test.go:95:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_peering_connection_test.go:139:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_peering_connection_test.go:166:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_peering_connection_test.go:231:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_peering_connection_test.go:390:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_peering_connection_test.go:526:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_peering_connection_test.go:549:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_peering_connection_test.go:584:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_test.go:169:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_test.go:225:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_test.go:266:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_test.go:307:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_test.go:370:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_test.go:427:36: XAT001: missing ErrorCheck aws/resource_aws_vpc_test.go:449:36: XAT001: missing ErrorCheck aws/resource_aws_vpn_connection_test.go:100:36: XAT001: missing ErrorCheck aws/resource_aws_vpn_connection_test.go:209:36: XAT001: missing ErrorCheck aws/resource_aws_vpn_connection_test.go:317:36: XAT001: missing ErrorCheck aws/resource_aws_vpn_connection_test.go:345:36: XAT001: missing ErrorCheck aws/resource_aws_vpn_connection_test.go:372:36: XAT001: missing ErrorCheck aws/resource_aws_vpn_connection_test.go:398:36: XAT001: missing ErrorCheck aws/resource_aws_vpn_gateway_route_propagation_test.go:16:36: XAT001: missing ErrorCheck aws/resource_aws_vpn_gateway_test.go:110:36: XAT001: missing ErrorCheck aws/resource_aws_vpn_gateway_test.go:257:36: XAT001: missing ErrorCheck aws/resource_aws_vpn_gateway_test.go:321:36: XAT001: missing ErrorCheck aws/resource_aws_vpn_gateway_test.go:349:36: XAT001: missing ErrorCheck ``` * tests: Lint Co-authored-by: Dirk Avery <dirk.avery@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0bbf1ee - Browse repository at this point
Copy the full SHA 0bbf1eeView commit details -
Merge pull request #18307 from hashicorp/t-phase2-errorcheck
tests: Add ErrorCheck (Phase 2)
Configuration menu - View commit details
-
Copy full SHA for dca904d - Browse repository at this point
Copy the full SHA dca904dView commit details -
Merge pull request #18308 from hashicorp/t-phase200-errorcheck
tests: Add ErrorCheck (Phase II 2)
Configuration menu - View commit details
-
Copy full SHA for 66db178 - Browse repository at this point
Copy the full SHA 66db178View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d7b7da - Browse repository at this point
Copy the full SHA 8d7b7daView commit details -
provider: Enable tfproviderdocs enhanced contents checking (#18138)
Reference: #15842 Fixes remaining reports and enables the additional checking. The tooling also supports flags for requiring alphabetical list sorting, but that can be enabled in the future. Previously: ``` Error checking Terraform Provider documentation: 12 errors occurred: * website/docs/r/acmpca_certificate.html.markdown: error checking file contents: attributes section heading (Attribute Reference) should be: Attributes Reference * website/docs/r/acmpca_certificate_authority_certificate.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference * website/docs/r/cognito_identity_provider.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference * website/docs/r/config_conformance_pack.html.markdown: error checking file contents: attributes section byline (In addition to all arguments above (except for template_body and template_s3_uri), the following attributes are exported:) should be: "In addition to all arguments above, the following attributes are exported:" or "No additional attributes are exported." * website/docs/r/iam_user_group_membership.html.markdown: error checking file contents: attributes section byline should be: "In addition to all arguments above, the following attributes are exported:" or "No additional attributes are exported." * website/docs/r/networkfirewall_resource_policy.html.markdown: error checking file contents: attributes section byline (In addition to all arguments above, the following attribute is exported:) should be: "In addition to all arguments above, the following attributes are exported:" or "No additional attributes are exported." * website/docs/r/pinpoint_baidu_channel.markdown: error checking file contents: missing attributes section: ## Attributes Reference * website/docs/r/pinpoint_event_stream.markdown: error checking file contents: missing attributes section: ## Attributes Reference * website/docs/r/pinpoint_gcm_channel.markdown: error checking file contents: missing attributes section: ## Attributes Reference * website/docs/r/securityhub_invite_accepter.markdown: error checking file contents: attributes section byline (The following attributes are exported in addition to the arguments listed above:) should be: "In addition to all arguments above, the following attributes are exported:" or "No additional attributes are exported." * website/docs/r/ses_identity_notification_topic.markdown: error checking file contents: import section code block text should contain resource name: aws_ses_identity_notification_topic * website/docs/r/transfer_ssh_key.html.markdown: error checking file contents: missing attributes section: ## Attributes Reference Error checking Terraform Provider documentation: 1 error occurred: * website/docs/r/securityhub_invite_accepter.markdown: error checking file contents: import section code block text should contain resource name: aws_securityhub_invite_accepter ```
Configuration menu - View commit details
-
Copy full SHA for 9b51c92 - Browse repository at this point
Copy the full SHA 9b51c92View commit details -
Merge pull request #18309 from hashicorp/t-errorcheck-xat001
tests: Enable XAT001, last fix
Configuration menu - View commit details
-
Copy full SHA for 551b75d - Browse repository at this point
Copy the full SHA 551b75dView commit details -
docs/resource/aws_kinesis_stream_consumer: Adjust example code block …
…language from hcl to terraform
Configuration menu - View commit details
-
Copy full SHA for 3d3d3c6 - Browse repository at this point
Copy the full SHA 3d3d3c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7141d1c - Browse repository at this point
Copy the full SHA 7141d1cView commit details
Commits on Mar 22, 2021
-
r/aws_apigatewayv2_domain_name: Use internal finder and waiter packages.
Acceptance test output: $ ACM_CERTIFICATE_ROOT_DOMAIN=<> make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayV2DomainName_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2DomainName_ -timeout 180m === RUN TestAccAWSAPIGatewayV2DomainName_basic === PAUSE TestAccAWSAPIGatewayV2DomainName_basic === RUN TestAccAWSAPIGatewayV2DomainName_disappears === PAUSE TestAccAWSAPIGatewayV2DomainName_disappears === RUN TestAccAWSAPIGatewayV2DomainName_Tags === PAUSE TestAccAWSAPIGatewayV2DomainName_Tags === RUN TestAccAWSAPIGatewayV2DomainName_UpdateCertificate === PAUSE TestAccAWSAPIGatewayV2DomainName_UpdateCertificate === RUN TestAccAWSAPIGatewayV2DomainName_MutualTlsAuthentication === PAUSE TestAccAWSAPIGatewayV2DomainName_MutualTlsAuthentication === CONT TestAccAWSAPIGatewayV2DomainName_basic === CONT TestAccAWSAPIGatewayV2DomainName_UpdateCertificate === CONT TestAccAWSAPIGatewayV2DomainName_MutualTlsAuthentication === CONT TestAccAWSAPIGatewayV2DomainName_Tags === CONT TestAccAWSAPIGatewayV2DomainName_disappears --- PASS: TestAccAWSAPIGatewayV2DomainName_disappears (24.80s) === CONT TestAccAWSAPIGatewayV2DomainName_MutualTlsAuthentication resource_aws_apigatewayv2_domain_name_test.go:279: Step 2/4 error: Error running apply: exit status 1 2021/03/22 17:15:26 [DEBUG] Using modified User-Agent: Terraform/0.12.26 HashiCorp-terraform-exec/0.13.0 Error: error updating API Gateway v2 domain name (tf-acc-01xy3s6uqmlgijxzyxaupimtxq7sqdaldcnzlpdqz8.ewbankkit.com): BadRequestException: Invalid input. Expected one domain name configuration on terraform_plugin_test.tf line 62, in resource "aws_apigatewayv2_domain_name" "test": 62: resource "aws_apigatewayv2_domain_name" "test" { --- FAIL: TestAccAWSAPIGatewayV2DomainName_MutualTlsAuthentication (194.33s) --- PASS: TestAccAWSAPIGatewayV2DomainName_basic (210.10s) --- PASS: TestAccAWSAPIGatewayV2DomainName_Tags (296.94s) --- PASS: TestAccAWSAPIGatewayV2DomainName_UpdateCertificate (430.93s) FAIL FAIL github.com/terraform-providers/terraform-provider-aws/aws 431.633s FAIL GNUmakefile:27: recipe for target 'testacc' failed make: *** [testacc] Error 1
Configuration menu - View commit details
-
Copy full SHA for a8eb986 - Browse repository at this point
Copy the full SHA a8eb986View commit details
Commits on Mar 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d34aca9 - Browse repository at this point
Copy the full SHA d34aca9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b314de - Browse repository at this point
Copy the full SHA 0b314deView commit details -
r/aws_apigatewayv2_domain_name: Use internal lister package for sweeper.
Acceptance test output: $ TEST=./aws SWEEP=us-west-2 SWEEPARGS=-sweep-run=aws_apigatewayv2_domain_name make sweep WARNING: This will destroy infrastructure. Use only in development accounts. go test ./aws -v -sweep=us-west-2 -sweep-run=aws_apigatewayv2_domain_name -timeout 60m 2021/03/23 10:24:20 [DEBUG] Running Sweepers for region (us-west-2): 2021/03/23 10:24:20 [DEBUG] Running Sweeper (aws_apigatewayv2_domain_name) in region (us-west-2) 2021/03/23 10:24:20 [INFO] AWS Auth provider used: "EnvProvider" 2021/03/23 10:24:20 [DEBUG] Trying to get account information via sts:GetCallerIdentity 2021/03/23 10:24:21 [DEBUG] Trying to get account information via sts:GetCallerIdentity 2021/03/23 10:24:22 [DEBUG] Deleting API Gateway v2 domain name (testing1.ewbankkit.com) 2021/03/23 10:24:23 Sweeper Tests ran successfully: - aws_apigatewayv2_domain_name ok github.com/terraform-providers/terraform-provider-aws/aws 2.324s
Configuration menu - View commit details
-
Copy full SHA for 705190f - Browse repository at this point
Copy the full SHA 705190fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 22e1219 - Browse repository at this point
Copy the full SHA 22e1219View commit details -
r/aws_apigatewayv2_domain_name: Always send domain name configuration…
… on update of mutual TLS configuration. Acceptance test output: $ ACM_CERTIFICATE_ROOT_DOMAIN=ewbankkit.com make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayV2DomainName_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2DomainName_ -timeout 180m === RUN TestAccAWSAPIGatewayV2DomainName_basic === PAUSE TestAccAWSAPIGatewayV2DomainName_basic === RUN TestAccAWSAPIGatewayV2DomainName_disappears === PAUSE TestAccAWSAPIGatewayV2DomainName_disappears === RUN TestAccAWSAPIGatewayV2DomainName_Tags === PAUSE TestAccAWSAPIGatewayV2DomainName_Tags === RUN TestAccAWSAPIGatewayV2DomainName_UpdateCertificate === PAUSE TestAccAWSAPIGatewayV2DomainName_UpdateCertificate === RUN TestAccAWSAPIGatewayV2DomainName_MutualTlsAuthentication === PAUSE TestAccAWSAPIGatewayV2DomainName_MutualTlsAuthentication === CONT TestAccAWSAPIGatewayV2DomainName_basic === CONT TestAccAWSAPIGatewayV2DomainName_MutualTlsAuthentication === CONT TestAccAWSAPIGatewayV2DomainName_UpdateCertificate === CONT TestAccAWSAPIGatewayV2DomainName_Tags === CONT TestAccAWSAPIGatewayV2DomainName_disappears --- PASS: TestAccAWSAPIGatewayV2DomainName_Tags (52.69s) --- PASS: TestAccAWSAPIGatewayV2DomainName_disappears (121.05s) --- PASS: TestAccAWSAPIGatewayV2DomainName_MutualTlsAuthentication (263.95s) --- PASS: TestAccAWSAPIGatewayV2DomainName_basic (347.90s) --- PASS: TestAccAWSAPIGatewayV2DomainName_UpdateCertificate (469.99s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 470.492s
Configuration menu - View commit details
-
Copy full SHA for 85fa43c - Browse repository at this point
Copy the full SHA 85fa43cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bd9874 - Browse repository at this point
Copy the full SHA 6bd9874View commit details -
tests/resource/aws_vpc_peering_connection: Remove ID-only refresh con…
…figuration (#18349) Reference: #18348 Identifier only refresh testing is generally a legacy testing practice before full import testing was the normal convention. Certain functionality of `IDRefreshName` testing, such as alternate providers defined by the test configuration and `ProviderFactories`, is not compatible since there is no method to pass in the original configuration to prevent Terraform CLI errors such as: ``` === CONT TestAccAWSVPCPeeringConnection_region testing_new.go:214: Error running terraform refresh: exit status 1 Error: Provider configuration not present To work with aws_vpc.peer (orphan) its original provider configuration at provider["registry.terraform.io/hashicorp/awsalternate"] is required, but it has been removed. This occurs when a provider configuration is removed while objects created by that provider still exist in the state. Re-add the provider configuration to destroy aws_vpc.peer (orphan), after which you can remove the provider configuration again. --- FAIL: TestAccAWSVPCPeeringConnection_region (24.38s) ``` Import testing accepts a `Config`, which is how it does not have a similar issue. Will submit followup issue to fix the Go documentation in the Terraform Plugin SDK as this testing is not run by default and note this limitation. Will also submit followup issue to remove `IDRefreshIgnore` and `IDRefreshName` from all testing. Output from acceptance testing: ``` --- PASS: TestAccAWSVPCPeeringConnection_peerRegionAutoAccept (13.29s) --- PASS: TestAccAWSVPCPeeringConnection_failedState (14.70s) --- PASS: TestAccAWSVPCPeeringConnection_plan (24.21s) --- PASS: TestAccAWSVPCPeeringConnection_optionsNoAutoAccept (25.87s) --- PASS: TestAccAWSVPCPeeringConnection_basic (27.94s) --- PASS: TestAccAWSVPCPeeringConnection_region (30.92s) --- PASS: TestAccAWSVPCPeeringConnection_options (60.28s) --- PASS: TestAccAWSVPCPeeringConnection_accept (61.32s) --- PASS: TestAccAWSVPCPeeringConnection_tags (62.79s) ```
Configuration menu - View commit details
-
Copy full SHA for 3cc0f8c - Browse repository at this point
Copy the full SHA 3cc0f8cView commit details -
Updates documentation for
automatic_failover_enabled
to remove refe……rence to multi-az and add requirement for `number_cache_clusters`
Configuration menu - View commit details
-
Copy full SHA for 61f3768 - Browse repository at this point
Copy the full SHA 61f3768View commit details -
tests/provider: Fix and enable AWS SDK Go pointer conversion linting …
…(C resources) (#18335) Reference: #12992 Previously: ``` aws/resource_aws_cloud9_environment_ec2.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-assignment: Prefer AWS Go SDK pointer conversion functions for dereferencing during assignment, e.g. aws.StringValue() 132: status := *out.Status aws/resource_aws_cloudfront_distribution_test.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-assignment: Prefer AWS Go SDK pointer conversion functions for dereferencing during assignment, e.g. aws.StringValue() 53: distributionID := *distributionSummary.Id aws/resource_aws_cloudfront_origin_request_policy.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-assignment: Prefer AWS Go SDK pointer conversion functions for dereferencing during assignment, e.g. aws.StringValue() 161: originRequestPolicy := *resp.OriginRequestPolicy.OriginRequestPolicyConfig aws/resource_aws_cloudtrail.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-assignment: Prefer AWS Go SDK pointer conversion functions for dereferencing during assignment, e.g. aws.StringValue() 569: item["read_write_type"] = *raw.ReadWriteType -------------------------------------------------------------------------------- 570: item["include_management_events"] = *raw.IncludeManagementEvents -------------------------------------------------------------------------------- 584: item["type"] = *raw.Type -------------------------------------------------------------------------------- severity:warning rule:prefer-aws-go-sdk-pointer-conversion-conditional: Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g. aws.StringValue() 262: if d.Id() == *c.Name { aws/resource_aws_cloudwatch_log_destination.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-conditional: Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g. aws.StringValue() 142: if *destination.DestinationName == name { aws/resource_aws_cloudwatch_log_metric_filter.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-conditional: Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g. aws.StringValue() 173: if *mf.FilterName == name { aws/resource_aws_cloudwatch_log_resource_policy.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-conditional: Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g. aws.StringValue() 107: if *resourcePolicy.PolicyName == name { aws/resource_aws_cloudwatch_log_stream.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-conditional: Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g. aws.StringValue() 152: if *ls.LogStreamName == name { aws/resource_aws_cloudwatch_metric_alarm.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-assignment: Prefer AWS Go SDK pointer conversion functions for dereferencing during assignment, e.g. aws.StringValue() 310: arn := *resp.AlarmArn -------------------------------------------------------------------------------- 581: flatDims[*d.Name] = *d.Value aws/resource_aws_codedeploy_deployment_group.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-assignment: Prefer AWS Go SDK pointer conversion functions for dereferencing during assignment, e.g. aws.StringValue() 1111: l["key"] = *tf.Key -------------------------------------------------------------------------------- 1114: l["value"] = *tf.Value -------------------------------------------------------------------------------- 1117: l["type"] = *tf.Type -------------------------------------------------------------------------------- 1130: l["key"] = *tf.Key -------------------------------------------------------------------------------- 1133: l["value"] = *tf.Value -------------------------------------------------------------------------------- 1136: l["type"] = *tf.Type -------------------------------------------------------------------------------- 1171: item["trigger_name"] = *tc.TriggerName -------------------------------------------------------------------------------- 1172: item["trigger_target_arn"] = *tc.TriggerTargetArn -------------------------------------------------------------------------------- 1187: item["enabled"] = *config.Enabled -------------------------------------------------------------------------------- 1210: item["enabled"] = *config.Enabled -------------------------------------------------------------------------------- 1211: item["ignore_poll_alarm_failure"] = *config.IgnorePollAlarmFailure -------------------------------------------------------------------------------- 1315: item["deployment_option"] = *style.DeploymentOption -------------------------------------------------------------------------------- 1318: item["deployment_type"] = *style.DeploymentType -------------------------------------------------------------------------------- 1355: deploymentReadyOption["action_on_timeout"] = *config.DeploymentReadyOption.ActionOnTimeout -------------------------------------------------------------------------------- 1358: deploymentReadyOption["wait_time_in_minutes"] = *config.DeploymentReadyOption.WaitTimeInMinutes -------------------------------------------------------------------------------- 1369: greenFleetProvisioningOption["action"] = *config.GreenFleetProvisioningOption.Action -------------------------------------------------------------------------------- 1380: blueInstanceTerminationOption["action"] = *config.TerminateBlueInstancesOnDeploymentSuccess.Action -------------------------------------------------------------------------------- 1383: blueInstanceTerminationOption["termination_wait_time_in_minutes"] = *config.TerminateBlueInstancesOnDeploymentSuccess.TerminationWaitTimeInMinutes -------------------------------------------------------------------------------- severity:warning rule:prefer-aws-go-sdk-pointer-conversion-conditional: Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g. aws.StringValue() 1110: if tf.Key != nil && *tf.Key != "" { -------------------------------------------------------------------------------- 1113: if tf.Value != nil && *tf.Value != "" { -------------------------------------------------------------------------------- 1116: if tf.Type != nil && *tf.Type != "" { -------------------------------------------------------------------------------- 1129: if tf.Key != nil && *tf.Key != "" { -------------------------------------------------------------------------------- 1132: if tf.Value != nil && *tf.Value != "" { -------------------------------------------------------------------------------- 1135: if tf.Type != nil && *tf.Type != "" { aws/resource_aws_codepipeline.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-assignment: Prefer AWS Go SDK pointer conversion functions for dereferencing during assignment, e.g. aws.StringValue() 464: m[k] = *v aws/resource_aws_config_remediation_configuration.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-assignment: Prefer AWS Go SDK pointer conversion functions for dereferencing during assignment, e.g. aws.StringValue() 123: item["resource_value"] = *value.ResourceValue.Value -------------------------------------------------------------------------------- 126: item["static_value"] = *value.StaticValue.Values[0] ran 15 rules on 2163 files: 40 findings ``` Output from acceptance testing: ``` --- PASS: TestAccAWSCloud9EnvironmentEc2_allFields (286.70s) --- PASS: TestAccAWSCloud9EnvironmentEc2_basic (209.52s) --- PASS: TestAccAWSCloud9EnvironmentEc2_disappears (170.86s) --- PASS: TestAccAWSCloud9EnvironmentEc2_tags (232.19s) --- PASS: TestAccAWSCloudFrontOriginRequestPolicy_basic (19.69s) --- PASS: TestAccAWSCloudFrontOriginRequestPolicy_noneBehavior (22.64s) --- PASS: TestAccAWSCloudFrontOriginRequestPolicy_update (37.49s) --- FAIL: TestAccAWSCloudTrail_serial (656.14s) --- FAIL: TestAccAWSCloudTrail_serial/Trail (656.14s) --- FAIL: TestAccAWSCloudTrail_serial/Trail/basic (48.14s) # Account permissions --- FAIL: TestAccAWSCloudTrail_serial/Trail/enableLogging (46.70s) # Account permissions --- PASS: TestAccAWSCloudTrail_serial/Trail/cloudwatch (73.41s) --- PASS: TestAccAWSCloudTrail_serial/Trail/eventSelector (138.13s) --- PASS: TestAccAWSCloudTrail_serial/Trail/includeGlobalServiceEvents (35.63s) --- PASS: TestAccAWSCloudTrail_serial/Trail/insightSelector (35.46s) --- PASS: TestAccAWSCloudTrail_serial/Trail/isMultiRegion (91.64s) --- PASS: TestAccAWSCloudTrail_serial/Trail/kmsKey (35.12s) --- PASS: TestAccAWSCloudTrail_serial/Trail/logValidation (65.09s) --- PASS: TestAccAWSCloudTrail_serial/Trail/tags (86.69s) --- SKIP: TestAccAWSCloudTrail_serial/Trail/isOrganization (0.13s) --- PASS: TestAccAWSCloudwatchLogDestination_basic (84.11s) --- PASS: TestAccAWSCloudwatchLogDestination_disappears (88.96s) --- PASS: TestAccAWSCloudWatchLogMetricFilter_basic (92.40s) --- PASS: TestAccAWSCloudWatchLogResourcePolicy_basic (32.98s) --- PASS: TestAccAWSCloudWatchLogStream_basic (21.49s) --- PASS: TestAccAWSCloudWatchLogStream_disappears (20.86s) --- PASS: TestAccAWSCloudWatchLogStream_disappears_LogGroup (20.50s) --- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (252.05s) --- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic (26.06s) --- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction (27.65s) --- PASS: TestAccAWSCloudWatchMetricAlarm_basic (23.92s) --- PASS: TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm (17.54s) --- PASS: TestAccAWSCloudWatchMetricAlarm_disappears (18.25s) --- PASS: TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (42.33s) --- PASS: TestAccAWSCloudWatchMetricAlarm_expression (96.17s) --- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (19.08s) --- PASS: TestAccAWSCloudWatchMetricAlarm_missingStatistic (5.29s) --- PASS: TestAccAWSCloudWatchMetricAlarm_tags (62.51s) --- PASS: TestAccAWSCloudWatchMetricAlarm_treatMissingData (42.33s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create (33.38s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete (51.51s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable (38.86s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update (40.28s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create (43.51s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete (61.36s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable (42.37s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update (64.37s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_basic (71.37s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_basic_tagSet (61.98s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete (46.42s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create (151.03s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete (48.72s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update (45.77s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update_with_asg (177.57s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create (31.64s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default (31.74s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete (45.98s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update (43.92s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_disappears (30.83s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_ECS_BlueGreen (310.19s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_inPlaceDeploymentWithTrafficControl_create (35.95s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_inPlaceDeploymentWithTrafficControl_update (54.46s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create (32.28s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete (44.30s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create (43.70s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete (67.73s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update (45.46s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update (64.46s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_onPremiseTag (41.70s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic (71.08s) --- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple (73.36s) --- FAIL: TestAccAWSCodePipeline_multiregion_ConvertSingleRegion (83.25s) # #16706 --- PASS: TestAccAWSCodePipeline_basic (72.08s) --- PASS: TestAccAWSCodePipeline_deployWithServiceRole (47.91s) --- PASS: TestAccAWSCodePipeline_disappears (37.13s) --- PASS: TestAccAWSCodePipeline_emptyStageArtifacts (43.65s) --- PASS: TestAccAWSCodePipeline_multiregion_basic (46.08s) --- PASS: TestAccAWSCodePipeline_multiregion_Update (73.72s) --- PASS: TestAccAWSCodePipeline_tags (98.61s) --- PASS: TestAccAWSCodePipeline_WithNamespace (49.41s) --- SKIP: TestAccAWSCodePipeline_WithGitHubv1SourceAction (0.00s) --- PASS: TestAccAWSConfig_serial (3698.82s) --- PASS: TestAccAWSConfig_serial/RemediationConfiguration (364.40s) --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/basic (86.05s) --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/disappears (83.00s) --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/recreates (99.34s) --- PASS: TestAccAWSConfig_serial/RemediationConfiguration/updates (96.01s) ```
Configuration menu - View commit details
-
Copy full SHA for b6e34c1 - Browse repository at this point
Copy the full SHA b6e34c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b224038 - Browse repository at this point
Copy the full SHA b224038View commit details
Commits on Mar 24, 2021
-
r/aws_mq_configuration: add missing authentication_strategy
When creating an ActiveMQ instance with authentication_strategy=ldap, then the corresponding configuration has to contain the same option as well for the user to be able to include a cachedLDAPAuthorizationMap element in the broker xml configuration. If the option is not provided when creating the configuration, the default strategy "simple" is assumed and AWS automatically removes the cachedLDAPAuthorizationMap element.
Configuration menu - View commit details
-
Copy full SHA for 155ee8d - Browse repository at this point
Copy the full SHA 155ee8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2850d10 - Browse repository at this point
Copy the full SHA 2850d10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f907a8 - Browse repository at this point
Copy the full SHA 7f907a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e889eaa - Browse repository at this point
Copy the full SHA e889eaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 580e6b0 - Browse repository at this point
Copy the full SHA 580e6b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c7d16d - Browse repository at this point
Copy the full SHA 3c7d16dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdbd9b7 - Browse repository at this point
Copy the full SHA cdbd9b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cf6877 - Browse repository at this point
Copy the full SHA 0cf6877View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1850da - Browse repository at this point
Copy the full SHA e1850daView commit details -
Configuration menu - View commit details
-
Copy full SHA for eca06c0 - Browse repository at this point
Copy the full SHA eca06c0View commit details -
Merge pull request #18070 from agranig/b-aws_mq_configuration-add_mis…
…sing_auth_strategy r/aws_mq_configuration: add missing authentication_strategy
Configuration menu - View commit details
-
Copy full SHA for 3d8e0fa - Browse repository at this point
Copy the full SHA 3d8e0faView commit details -
Configuration menu - View commit details
-
Copy full SHA for c869f7a - Browse repository at this point
Copy the full SHA c869f7aView commit details -
build(deps): bump github.com/bflad/tfproviderlint from 0.23.0 to 0.24…
….0 in /awsproviderlint (#18368) * build(deps): bump github.com/bflad/tfproviderlint in /awsproviderlint Bumps [github.com/bflad/tfproviderlint](https://github.com/bflad/tfproviderlint) from 0.23.0 to 0.24.0. - [Release notes](https://github.com/bflad/tfproviderlint/releases) - [Changelog](https://github.com/bflad/tfproviderlint/blob/main/CHANGELOG.md) - [Commits](bflad/tfproviderlint@v0.23.0...v0.24.0) Signed-off-by: dependabot[bot] <support@github.com> * tests/provider: Disable new failing tfproviderlint reports for now Reference: #18354 Reference: #18377 Reference: #18378 Reference: #18379 Reference: #18380 Reference: #18381 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brian Flad <bflad417@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9c10042 - Browse repository at this point
Copy the full SHA 9c10042View commit details -
Update CHANGELOG.md for #18368
changelogbot committedMar 24, 2021 Configuration menu - View commit details
-
Copy full SHA for 43c8b0a - Browse repository at this point
Copy the full SHA 43c8b0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7faa19 - Browse repository at this point
Copy the full SHA b7faa19View commit details -
Merge pull request #18355 from hashicorp/elasticache-repgroup-docs
resource/aws_elasticache_replication_group: Updates documentation for `automatic_failover_enabled`
Configuration menu - View commit details
-
Copy full SHA for 1337aec - Browse repository at this point
Copy the full SHA 1337aecView commit details -
Configuration menu - View commit details
-
Copy full SHA for a7071cb - Browse repository at this point
Copy the full SHA a7071cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c56c6c - Browse repository at this point
Copy the full SHA 2c56c6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab57f69 - Browse repository at this point
Copy the full SHA ab57f69View commit details -
r/aws_api_gateway_vpc_link: Persist ID of newly created VPC Link when…
… it fails to reach Available state (#18382) * r/aws_api_gateway_vpc_link: Persist ID of new;y created VPC Link when it fails to reach Available state. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayVpcLink_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayVpcLink_basic -timeout 180m === RUN TestAccAWSAPIGatewayVpcLink_basic === PAUSE TestAccAWSAPIGatewayVpcLink_basic === CONT TestAccAWSAPIGatewayVpcLink_basic --- PASS: TestAccAWSAPIGatewayVpcLink_basic (750.44s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 750.547s * Add CHANGELOG entry.
Configuration menu - View commit details
-
Copy full SHA for 362106b - Browse repository at this point
Copy the full SHA 362106bView commit details -
Merge pull request #18384 from hashicorp/b-wafv2-logging-config-depre…
…cation-warning resource/aws_wafv2_web_acl_logging_configuration: remove incorrect deprecation warning for single_header argument
Configuration menu - View commit details
-
Copy full SHA for f300605 - Browse repository at this point
Copy the full SHA f300605View commit details -
Update CHANGELOG.md for #18384
changelogbot committedMar 24, 2021 Configuration menu - View commit details
-
Copy full SHA for 87d504a - Browse repository at this point
Copy the full SHA 87d504aView commit details -
aws_vpc: Correct the ARN account id (#17729)
* aws_vpc: Correct the ARN account id * Remove aws_vpc from the document
Configuration menu - View commit details
-
Copy full SHA for 733468e - Browse repository at this point
Copy the full SHA 733468eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69e2d3c - Browse repository at this point
Copy the full SHA 69e2d3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fc9faa - Browse repository at this point
Copy the full SHA 4fc9faaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78e067c - Browse repository at this point
Copy the full SHA 78e067cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbd183f - Browse repository at this point
Copy the full SHA cbd183fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 126bea0 - Browse repository at this point
Copy the full SHA 126bea0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6024828 - Browse repository at this point
Copy the full SHA 6024828View commit details -
Configuration menu - View commit details
-
Copy full SHA for f25719d - Browse repository at this point
Copy the full SHA f25719dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c963d53 - Browse repository at this point
Copy the full SHA c963d53View commit details -
Merge pull request #18361 from hashicorp/elasticache_secondary_cluster
resource/aws_elasticache_replication_group: Prevent re-creation when encryption enabled
Configuration menu - View commit details
-
Copy full SHA for ac6f114 - Browse repository at this point
Copy the full SHA ac6f114View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80fc255 - Browse repository at this point
Copy the full SHA 80fc255View commit details -
Update CHANGELOG.md for #18361
changelogbot committedMar 24, 2021 Configuration menu - View commit details
-
Copy full SHA for cc28c41 - Browse repository at this point
Copy the full SHA cc28c41View commit details
Commits on Mar 25, 2021
-
Merge pull request #8611 from mavericknsk/f-aws_lightsail_open_ports
New resource: aws_lightsail_instance_public_ports
Configuration menu - View commit details
-
Copy full SHA for c3f18ab - Browse repository at this point
Copy the full SHA c3f18abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 690280e - Browse repository at this point
Copy the full SHA 690280eView commit details -
build(deps): Bump github.com/hashicorp/terraform-plugin-sdk/v2 (#18395)
Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.4.4 to 2.5.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.4.4...v2.5.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0460004 - Browse repository at this point
Copy the full SHA 0460004View commit details -
Update CHANGELOG.md for #18395
changelogbot committedMar 25, 2021 Configuration menu - View commit details
-
Copy full SHA for 496fe7b - Browse repository at this point
Copy the full SHA 496fe7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfc6bd9 - Browse repository at this point
Copy the full SHA dfc6bd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f29295 - Browse repository at this point
Copy the full SHA 9f29295View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8619a4 - Browse repository at this point
Copy the full SHA d8619a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d5b25c - Browse repository at this point
Copy the full SHA 3d5b25cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfd07db - Browse repository at this point
Copy the full SHA bfd07dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29afc7c - Browse repository at this point
Copy the full SHA 29afc7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fce8f9 - Browse repository at this point
Copy the full SHA 5fce8f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d85170 - Browse repository at this point
Copy the full SHA 4d85170View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c34456 - Browse repository at this point
Copy the full SHA 4c34456View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4406339 - Browse repository at this point
Copy the full SHA 4406339View commit details -
Merge pull request #14905 from kurtmc/feature/lightsail-public-ports
Add cidrs attribute to aws_lightsail_instance_public_ports resource
Configuration menu - View commit details
-
Copy full SHA for 69e0f43 - Browse repository at this point
Copy the full SHA 69e0f43View commit details -
Merge pull request #18375 from ewbankkit/td-add-semgrep-makefile-target
Makefile: Add 'semgrep' target
Configuration menu - View commit details
-
Copy full SHA for e5d2257 - Browse repository at this point
Copy the full SHA e5d2257View commit details -
Merge pull request #14014 from ewbankkit/t-additional-aws_route-tests
r/aws_route: Refactor acceptance tests in preparation for future fixes/enhancements
Configuration menu - View commit details
-
Copy full SHA for 48fefb7 - Browse repository at this point
Copy the full SHA 48fefb7View commit details -
resource/aws_pinpoint_email_channel: Support using SES configuration …
…set and add plan time validations (#18314) Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSPinpointEmailChannel_disappears (19.13s) --- PASS: TestAccAWSPinpointEmailChannel_configurationSet (22.62s) --- PASS: TestAccAWSPinpointEmailChannel_basic (34.66s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSPinpointEmailChannel_disappears (27.30s) --- PASS: TestAccAWSPinpointEmailChannel_configurationSet (33.09s) --- PASS: TestAccAWSPinpointEmailChannel_basic (53.08s) ```
Configuration menu - View commit details
-
Copy full SHA for e80ca2f - Browse repository at this point
Copy the full SHA e80ca2fView commit details -
Merge pull request #18042 from hashicorp/b-remove_computed_from_forwa…
…rded_values Allow forwarded_values to be empty
Configuration menu - View commit details
-
Copy full SHA for 1d10aa1 - Browse repository at this point
Copy the full SHA 1d10aa1View commit details -
Merge branch 'r/pinpoint_event_stream_eventual_consistency' of ssh://…
…github.com/DrFaust92/terraform-provider-aws into DrFaust92-r/pinpoint_event_stream_eventual_consistency
Configuration menu - View commit details
-
Copy full SHA for 16c4405 - Browse repository at this point
Copy the full SHA 16c4405View commit details -
Update CHANGELOG.md for #18042
changelogbot committedMar 25, 2021 Configuration menu - View commit details
-
Copy full SHA for 85137f5 - Browse repository at this point
Copy the full SHA 85137f5View commit details -
Merge pull request #18347 from shedimon/ecs-exec
Add enable_execute_command to aws_ecs_service
Configuration menu - View commit details
-
Copy full SHA for e3ba872 - Browse repository at this point
Copy the full SHA e3ba872View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dbe102 - Browse repository at this point
Copy the full SHA 3dbe102View commit details -
resource/aws_pinpoint_event_stream: Update IAM error retry logic to m…
…atch Contributing Guide Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSPinpointEventStream_disappears (71.12s) --- PASS: TestAccAWSPinpointEventStream_basic (143.79s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSPinpointEventStream_disappears (69.10s) --- PASS: TestAccAWSPinpointEventStream_basic (148.10s) ```
Configuration menu - View commit details
-
Copy full SHA for 935f8a2 - Browse repository at this point
Copy the full SHA 935f8a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbef8cc - Browse repository at this point
Copy the full SHA dbef8ccView commit details -
Merge pull request #12151 from jbaptistetrb/master
resource/aws_ecs_service: fix ecs service force new if service discov…
Configuration menu - View commit details
-
Copy full SHA for 9c0f5e5 - Browse repository at this point
Copy the full SHA 9c0f5e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a50ada3 - Browse repository at this point
Copy the full SHA a50ada3View commit details -
Update aws/resource_aws_iam_server_certificate.go
Co-authored-by: Brian Flad <bflad417@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2cb9e61 - Browse repository at this point
Copy the full SHA 2cb9e61View commit details -
Merge pull request #18408 from hashicorp/update_test_config
Add missing parameter and ErrorCheck on test
Configuration menu - View commit details
-
Copy full SHA for c90908f - Browse repository at this point
Copy the full SHA c90908fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a736b99 - Browse repository at this point
Copy the full SHA a736b99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71a3ee5 - Browse repository at this point
Copy the full SHA 71a3ee5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d466949 - Browse repository at this point
Copy the full SHA d466949View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12a6d2b - Browse repository at this point
Copy the full SHA 12a6d2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1281fe3 - Browse repository at this point
Copy the full SHA 1281fe3View commit details -
Update CHANGELOG.md for #18408
changelogbot committedMar 25, 2021 Configuration menu - View commit details
-
Copy full SHA for b2ea95a - Browse repository at this point
Copy the full SHA b2ea95aView commit details -
Merge branch 'r/iam_server_certificate_tags' of ssh://github.com/DrFa…
…ust92/terraform-provider-aws into DrFaust92-r/iam_server_certificate_tags
Configuration menu - View commit details
-
Copy full SHA for a3befc2 - Browse repository at this point
Copy the full SHA a3befc2View commit details -
docs/resource/aws_iam_server_certificate: Move tags documentation to …
…arguments Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSIAMServerCertificate_disappears (14.13s) --- PASS: TestAccAWSIAMServerCertificate_name_prefix (15.89s) --- PASS: TestAccAWSIAMServerCertificate_Path (18.27s) --- PASS: TestAccAWSIAMServerCertificate_basic (18.19s) --- PASS: TestAccAWSIAMServerCertificate_file (31.71s) --- PASS: TestAccAWSIAMServerCertificate_tags (40.61s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSIAMServerCertificate_disappears (17.41s) --- PASS: TestAccAWSIAMServerCertificate_name_prefix (20.05s) --- PASS: TestAccAWSIAMServerCertificate_basic (22.42s) --- PASS: TestAccAWSIAMServerCertificate_Path (22.36s) --- PASS: TestAccAWSIAMServerCertificate_file (37.52s) --- PASS: TestAccAWSIAMServerCertificate_tags (51.54s) ```
Configuration menu - View commit details
-
Copy full SHA for f107b89 - Browse repository at this point
Copy the full SHA f107b89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ed8aae - Browse repository at this point
Copy the full SHA 5ed8aaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ee95bf - Browse repository at this point
Copy the full SHA 5ee95bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for d16a65c - Browse repository at this point
Copy the full SHA d16a65cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68ed1bb - Browse repository at this point
Copy the full SHA 68ed1bbView commit details -
r/aws_route: Correct capitalization of 'IPv4' and 'IPv6'.
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_disappears_RouteTable === PAUSE TestAccAWSRoute_disappears_RouteTable === RUN TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRoute_IPv6_To_InternetGateway === PAUSE TestAccAWSRoute_IPv6_To_InternetGateway === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === RUN TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached === PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached === RUN TestAccAWSRoute_IPv6_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv6_To_VpnGateway === PAUSE TestAccAWSRoute_IPv6_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_VpnGateway === PAUSE TestAccAWSRoute_IPv4_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === RUN TestAccAWSRoute_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_NatGateway === PAUSE TestAccAWSRoute_IPv4_To_NatGateway === RUN TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === RUN TestAccAWSRoute_IPv4_To_TransitGateway === PAUSE TestAccAWSRoute_IPv4_To_TransitGateway === RUN TestAccAWSRoute_IPv6_To_TransitGateway === PAUSE TestAccAWSRoute_IPv6_To_TransitGateway === RUN TestAccAWSRoute_IPv4_To_LocalGateway === PAUSE TestAccAWSRoute_IPv4_To_LocalGateway === RUN TestAccAWSRoute_IPv6_To_LocalGateway === PAUSE TestAccAWSRoute_IPv6_To_LocalGateway === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === RUN TestAccAWSRoute_IPv4_Update_Target === PAUSE TestAccAWSRoute_IPv4_Update_Target === RUN TestAccAWSRoute_IPv6_Update_Target === PAUSE TestAccAWSRoute_IPv6_Update_Target === RUN TestAccAWSRoute_IPv4_To_VpcEndpoint === PAUSE TestAccAWSRoute_IPv4_To_VpcEndpoint === RUN TestAccAWSRoute_LocalRoute === PAUSE TestAccAWSRoute_LocalRoute === CONT TestAccAWSRoute_basic === CONT TestAccAWSRoute_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (27.43s) === CONT TestAccAWSRoute_LocalRoute --- PASS: TestAccAWSRoute_basic (36.72s) === CONT TestAccAWSRoute_IPv4_To_VpcEndpoint --- PASS: TestAccAWSRoute_LocalRoute (21.98s) === CONT TestAccAWSRoute_IPv6_Update_Target --- PASS: TestAccAWSRoute_IPv6_Update_Target (226.03s) === CONT TestAccAWSRoute_IPv4_Update_Target --- PASS: TestAccAWSRoute_IPv4_To_VpcEndpoint (273.71s) === CONT TestAccAWSRoute_ConditionalCidrBlock === CONT TestAccAWSRoute_IPv6_To_LocalGateway --- PASS: TestAccAWSRoute_ConditionalCidrBlock (51.91s) === CONT TestAccAWSRoute_IPv6_To_LocalGateway data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found --- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (1.28s) === CONT TestAccAWSRoute_IPv4_To_LocalGateway data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found --- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (1.10s) === CONT TestAccAWSRoute_IPv6_To_TransitGateway --- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (357.84s) === CONT TestAccAWSRoute_IPv4_To_TransitGateway --- PASS: TestAccAWSRoute_IPv4_Update_Target (626.78s) === CONT TestAccAWSRoute_DoesNotCrashWithVpcEndpoint --- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (43.28s) === CONT TestAccAWSRoute_IPv4_To_NatGateway --- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (399.08s) === CONT TestAccAWSRoute_IPv6_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (25.57s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments --- PASS: TestAccAWSRoute_IPv4_To_NatGateway (228.62s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Attached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (190.46s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (57.67s) === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (340.04s) === CONT TestAccAWSRoute_IPv4_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (35.60s) === CONT TestAccAWSRoute_IPv6_To_VpnGateway --- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (41.86s) === CONT TestAccAWSRoute_IPv6_To_InternetGateway --- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (34.47s) === CONT TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached --- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (58.80s) === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_Instance (326.97s) === CONT TestAccAWSRoute_disappears_RouteTable --- PASS: TestAccAWSRoute_disappears_RouteTable (33.05s) === CONT TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (37.46s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_disappears (31.77s) --- PASS: TestAccAWSRoute_IPv6_To_Instance (327.89s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 2012.898s
Configuration menu - View commit details
-
Copy full SHA for a4bf248 - Browse repository at this point
Copy the full SHA a4bf248View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c90855 - Browse repository at this point
Copy the full SHA 7c90855View commit details -
Configuration menu - View commit details
-
Copy full SHA for 967b940 - Browse repository at this point
Copy the full SHA 967b940View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d57fe8 - Browse repository at this point
Copy the full SHA 1d57fe8View commit details -
r/aws_route: Return 'NotFoundError' instead of 'nil' when no route fo…
…und (#15945). r/aws_route: Implement 'd.IsNewResource()' checksin 'resourceAwsRouteRead' (#16796). Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute_basic\|TestAccAWSRoute_disappears' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_basic\|TestAccAWSRoute_disappears -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_disappears_RouteTable === PAUSE TestAccAWSRoute_disappears_RouteTable === CONT TestAccAWSRoute_basic === CONT TestAccAWSRoute_disappears_RouteTable --- PASS: TestAccAWSRoute_disappears_RouteTable (34.67s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_basic (36.39s) --- PASS: TestAccAWSRoute_disappears (31.85s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 66.620s
Configuration menu - View commit details
-
Copy full SHA for 88fd905 - Browse repository at this point
Copy the full SHA 88fd905View commit details -
r/aws_route: Change 'finder.RouteTable' to 'finder.RouteTables' to su…
…pport data source returning multiple route tables. Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute_basic\|TestAccAWSRoute_disappears' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_basic\|TestAccAWSRoute_disappears -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_disappears_RouteTable === PAUSE TestAccAWSRoute_disappears_RouteTable === CONT TestAccAWSRoute_basic === CONT TestAccAWSRoute_disappears_RouteTable --- PASS: TestAccAWSRoute_disappears_RouteTable (33.82s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_basic (35.39s) --- PASS: TestAccAWSRoute_disappears (31.99s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 65.901s
Configuration menu - View commit details
-
Copy full SHA for f4bff31 - Browse repository at this point
Copy the full SHA f4bff31View commit details -
Revert "r/aws_route: Change 'finder.RouteTable' to 'finder.RouteTable…
…s' to support data source returning multiple route tables." This reverts commit 5b93284.
Configuration menu - View commit details
-
Copy full SHA for 6f9b6e3 - Browse repository at this point
Copy the full SHA 6f9b6e3View commit details -
r/aws_route: Add 'testAccCheckAWSRouteExists'.
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_disappears_RouteTable === PAUSE TestAccAWSRoute_disappears_RouteTable === RUN TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRoute_IPv6_To_InternetGateway === PAUSE TestAccAWSRoute_IPv6_To_InternetGateway === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === RUN TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached === PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached === RUN TestAccAWSRoute_IPv6_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv6_To_VpnGateway === PAUSE TestAccAWSRoute_IPv6_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_VpnGateway === PAUSE TestAccAWSRoute_IPv4_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === RUN TestAccAWSRoute_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_NatGateway === PAUSE TestAccAWSRoute_IPv4_To_NatGateway === RUN TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === RUN TestAccAWSRoute_IPv4_To_TransitGateway === PAUSE TestAccAWSRoute_IPv4_To_TransitGateway === RUN TestAccAWSRoute_IPv6_To_TransitGateway === PAUSE TestAccAWSRoute_IPv6_To_TransitGateway === RUN TestAccAWSRoute_IPv4_To_LocalGateway === PAUSE TestAccAWSRoute_IPv4_To_LocalGateway === RUN TestAccAWSRoute_IPv6_To_LocalGateway === PAUSE TestAccAWSRoute_IPv6_To_LocalGateway === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === RUN TestAccAWSRoute_IPv4_Update_Target === PAUSE TestAccAWSRoute_IPv4_Update_Target === RUN TestAccAWSRoute_IPv6_Update_Target === PAUSE TestAccAWSRoute_IPv6_Update_Target === RUN TestAccAWSRoute_IPv4_To_VpcEndpoint === PAUSE TestAccAWSRoute_IPv4_To_VpcEndpoint === RUN TestAccAWSRoute_LocalRoute === PAUSE TestAccAWSRoute_LocalRoute === CONT TestAccAWSRoute_basic === CONT TestAccAWSRoute_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (27.59s) === CONT TestAccAWSRoute_LocalRoute --- PASS: TestAccAWSRoute_basic (36.97s) === CONT TestAccAWSRoute_IPv4_To_VpcEndpoint --- PASS: TestAccAWSRoute_LocalRoute (22.34s) === CONT TestAccAWSRoute_IPv6_Update_Target === CONT TestAccAWSRoute_IPv4_To_VpcEndpoint resource_aws_route_test.go:1305: Step 1/2 error: Error running apply: 2021/01/24 16:28:27 [DEBUG] Using modified User-Agent: Terraform/0.12.26 HashiCorp-terraform-exec/0.12.0 Error: error waiting for VPC Endpoint (vpce-0467b8bc3339b49d3) to become available: VPC Endpoint is in a failed state --- FAIL: TestAccAWSRoute_IPv4_To_VpcEndpoint (117.58s) === CONT TestAccAWSRoute_IPv4_Update_Target --- PASS: TestAccAWSRoute_IPv6_Update_Target (240.69s) === CONT TestAccAWSRoute_ConditionalCidrBlock === CONT TestAccAWSRoute_IPv4_Update_Target resource_aws_route_test.go:961: Step 1/9 error: Error running apply: 2021/01/24 16:30:26 [DEBUG] Using modified User-Agent: Terraform/0.12.26 HashiCorp-terraform-exec/0.12.0 Error: error waiting for VPC Endpoint (vpce-00b5c230eaa0bb041) to become available: VPC Endpoint is in a failed state --- PASS: TestAccAWSRoute_ConditionalCidrBlock (53.83s) === CONT TestAccAWSRoute_IPv6_To_LocalGateway data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found --- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (1.20s) === CONT TestAccAWSRoute_IPv4_To_LocalGateway data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found --- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (1.09s) === CONT TestAccAWSRoute_IPv6_To_TransitGateway --- FAIL: TestAccAWSRoute_IPv4_Update_Target (293.81s) === CONT TestAccAWSRoute_IPv4_To_TransitGateway --- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (398.85s) === CONT TestAccAWSRoute_DoesNotCrashWithVpcEndpoint --- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (43.25s) === CONT TestAccAWSRoute_IPv4_To_NatGateway --- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (357.85s) === CONT TestAccAWSRoute_IPv6_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (25.91s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments --- PASS: TestAccAWSRoute_IPv4_To_NatGateway (198.68s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Attached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (188.15s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (58.13s) === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (350.41s) === CONT TestAccAWSRoute_IPv4_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (55.38s) === CONT TestAccAWSRoute_IPv6_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_Instance (326.27s) === CONT TestAccAWSRoute_IPv6_To_InternetGateway --- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (41.21s) === CONT TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached --- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (35.53s) === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (58.52s) === CONT TestAccAWSRoute_disappears_RouteTable --- PASS: TestAccAWSRoute_disappears_RouteTable (33.04s) === CONT TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (37.15s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_disappears (32.57s) --- PASS: TestAccAWSRoute_IPv6_To_Instance (349.57s) FAIL FAIL github.com/terraform-providers/terraform-provider-aws/aws 1789.890s FAIL GNUmakefile:27: recipe for target 'testacc' failed make: *** [testacc] Error 1 Failures are unrelated to this change.
Configuration menu - View commit details
-
Copy full SHA for a205744 - Browse repository at this point
Copy the full SHA a205744View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e96236 - Browse repository at this point
Copy the full SHA 5e96236View commit details -
Configuration menu - View commit details
-
Copy full SHA for b48ef53 - Browse repository at this point
Copy the full SHA b48ef53View commit details -
Merge branch 'r/iam_saml_provider_tags' of ssh://github.com/DrFaust92…
…/terraform-provider-aws into DrFaust92-r/iam_saml_provider_tags
Configuration menu - View commit details
-
Copy full SHA for 90f6829 - Browse repository at this point
Copy the full SHA 90f6829View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fd401d - Browse repository at this point
Copy the full SHA 1fd401dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c52235 - Browse repository at this point
Copy the full SHA 1c52235View commit details -
tests/resource/aws_iam_server_certificate: Add missing ErrorCheck (#1…
…8413) Previously: ``` aws/resource_aws_iam_server_certificate_test.go:154:36: XAT001: missing ErrorCheck 153 154 resource.ParallelTest(t, resource.TestCase{ 155 PreCheck: func() { testAccPreCheck(t) }, ``` Output from acceptance testing: ``` --- PASS: TestAccAWSIAMServerCertificate_name_prefix (15.33s) ```
Configuration menu - View commit details
-
Copy full SHA for 914c9a1 - Browse repository at this point
Copy the full SHA 914c9a1View commit details -
Update CHANGELOG.md for #18413
changelogbot committedMar 25, 2021 Configuration menu - View commit details
-
Copy full SHA for 93658ed - Browse repository at this point
Copy the full SHA 93658edView commit details -
r/aws_route: Add 'ErrorCheck' to new acceptance tests.
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 180m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_disappears_RouteTable === PAUSE TestAccAWSRoute_disappears_RouteTable === RUN TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRoute_IPv6_To_InternetGateway === PAUSE TestAccAWSRoute_IPv6_To_InternetGateway === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === RUN TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached === PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached === RUN TestAccAWSRoute_IPv6_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv6_To_VpnGateway === PAUSE TestAccAWSRoute_IPv6_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_VpnGateway === PAUSE TestAccAWSRoute_IPv4_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === RUN TestAccAWSRoute_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_NatGateway === PAUSE TestAccAWSRoute_IPv4_To_NatGateway === RUN TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === RUN TestAccAWSRoute_IPv4_To_TransitGateway === PAUSE TestAccAWSRoute_IPv4_To_TransitGateway === RUN TestAccAWSRoute_IPv6_To_TransitGateway === PAUSE TestAccAWSRoute_IPv6_To_TransitGateway === RUN TestAccAWSRoute_IPv4_To_LocalGateway === PAUSE TestAccAWSRoute_IPv4_To_LocalGateway === RUN TestAccAWSRoute_IPv6_To_LocalGateway === PAUSE TestAccAWSRoute_IPv6_To_LocalGateway === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === RUN TestAccAWSRoute_IPv4_Update_Target === PAUSE TestAccAWSRoute_IPv4_Update_Target === RUN TestAccAWSRoute_IPv6_Update_Target === PAUSE TestAccAWSRoute_IPv6_Update_Target === RUN TestAccAWSRoute_IPv4_To_VpcEndpoint === PAUSE TestAccAWSRoute_IPv4_To_VpcEndpoint === RUN TestAccAWSRoute_LocalRoute === PAUSE TestAccAWSRoute_LocalRoute === CONT TestAccAWSRoute_basic === CONT TestAccAWSRoute_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (28.45s) === CONT TestAccAWSRoute_LocalRoute --- PASS: TestAccAWSRoute_basic (38.00s) === CONT TestAccAWSRoute_IPv4_To_VpcEndpoint --- PASS: TestAccAWSRoute_LocalRoute (22.59s) === CONT TestAccAWSRoute_IPv6_Update_Target --- PASS: TestAccAWSRoute_IPv6_Update_Target (232.50s) === CONT TestAccAWSRoute_IPv4_Update_Target --- PASS: TestAccAWSRoute_IPv4_To_VpcEndpoint (338.09s) === CONT TestAccAWSRoute_ConditionalCidrBlock --- PASS: TestAccAWSRoute_ConditionalCidrBlock (53.66s) === CONT TestAccAWSRoute_IPv6_To_LocalGateway data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found --- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (0.67s) === CONT TestAccAWSRoute_IPv4_To_LocalGateway data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found --- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (0.53s) === CONT TestAccAWSRoute_IPv6_To_TransitGateway --- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (379.86s) === CONT TestAccAWSRoute_IPv4_To_TransitGateway --- PASS: TestAccAWSRoute_IPv4_Update_Target (649.40s) === CONT TestAccAWSRoute_DoesNotCrashWithVpcEndpoint --- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (44.09s) === CONT TestAccAWSRoute_IPv4_To_NatGateway --- PASS: TestAccAWSRoute_IPv4_To_NatGateway (188.51s) === CONT TestAccAWSRoute_IPv6_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (368.92s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments --- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (26.92s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Attached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (109.80s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (155.70s) === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (58.67s) === CONT TestAccAWSRoute_IPv4_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (45.64s) === CONT TestAccAWSRoute_IPv6_To_VpnGateway --- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (60.67s) === CONT TestAccAWSRoute_IPv6_To_InternetGateway --- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (35.74s) === CONT TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached --- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (59.67s) === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv6_To_Instance (76.28s) === CONT TestAccAWSRoute_disappears_RouteTable --- PASS: TestAccAWSRoute_IPv4_To_Instance (306.09s) === CONT TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRoute_disappears_RouteTable (34.85s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (40.15s) --- PASS: TestAccAWSRoute_disappears (33.21s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 1707.091s
Configuration menu - View commit details
-
Copy full SHA for 0dee7b5 - Browse repository at this point
Copy the full SHA 0dee7b5View commit details -
resource/aws_iam_oidc_provider: Add tagging support + validations + s…
…weeper (#17964) Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSIAMOpenIDConnectProvider_disappears (10.03s) --- PASS: TestAccAWSIAMOpenIDConnectProvider_basic (20.50s) --- PASS: TestAccAWSIAMOpenIDConnectProvider_tags (32.26s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSIAMOpenIDConnectProvider_disappears (15.58s) --- PASS: TestAccAWSIAMOpenIDConnectProvider_basic (36.70s) --- PASS: TestAccAWSIAMOpenIDConnectProvider_tags (47.27s) ```
Configuration menu - View commit details
-
Copy full SHA for 9bdfe01 - Browse repository at this point
Copy the full SHA 9bdfe01View commit details -
Merge pull request #17387 from adam-tylr/b-issue-17386
Add ForceNew to ecs_service service_registries
Configuration menu - View commit details
-
Copy full SHA for a01547a - Browse repository at this point
Copy the full SHA a01547aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cf80e1 - Browse repository at this point
Copy the full SHA 7cf80e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e0d0f6 - Browse repository at this point
Copy the full SHA 5e0d0f6View commit details -
resource/aws_iam_instance_profile: Add tagging support + sweeper (#17962
) Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSIAMInstanceProfile_withoutRole (24.71s) --- PASS: TestAccAWSIAMInstanceProfile_disappears_role (25.87s) --- PASS: TestAccAWSIAMInstanceProfile_disappears (26.09s) --- PASS: TestAccAWSIAMInstanceProfile_namePrefix (28.30s) --- PASS: TestAccAWSIAMInstanceProfile_basic (31.35s) --- PASS: TestAccAWSIAMInstanceProfile_tags (44.67s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSIAMInstanceProfile_withoutRole (32.70s) --- PASS: TestAccAWSIAMInstanceProfile_disappears_role (34.17s) --- PASS: TestAccAWSIAMInstanceProfile_disappears (34.40s) --- PASS: TestAccAWSIAMInstanceProfile_basic (39.09s) --- PASS: TestAccAWSIAMInstanceProfile_namePrefix (41.02s) --- PASS: TestAccAWSIAMInstanceProfile_tags (69.02s) ```
Configuration menu - View commit details
-
Copy full SHA for 82cc1be - Browse repository at this point
Copy the full SHA 82cc1beView commit details -
resource/aws_ami_from_instance: Tag on create (#17968)
Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSAMIFromInstance_disappears (259.64s) --- PASS: TestAccAWSAMIFromInstance_basic (276.96s) --- PASS: TestAccAWSAMIFromInstance_tags (309.87s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSAMIFromInstance_disappears (289.51s) --- PASS: TestAccAWSAMIFromInstance_basic (307.13s) --- PASS: TestAccAWSAMIFromInstance_tags (356.92s) ```
Configuration menu - View commit details
-
Copy full SHA for 9216b97 - Browse repository at this point
Copy the full SHA 9216b97View commit details -
Merge pull request #16930 from ewbankkit/b-various-aws_route-fixes-Ma…
…rkVII r/aws_route: Correctly handle update of route target
Configuration menu - View commit details
-
Copy full SHA for e1ecea3 - Browse repository at this point
Copy the full SHA e1ecea3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e09b03c - Browse repository at this point
Copy the full SHA e09b03cView commit details -
Configuration menu - View commit details
-
Copy full SHA for af889b0 - Browse repository at this point
Copy the full SHA af889b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae58399 - Browse repository at this point
Copy the full SHA ae58399View commit details -
Configuration menu - View commit details
-
Copy full SHA for f596ac6 - Browse repository at this point
Copy the full SHA f596ac6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6b7d2b - Browse repository at this point
Copy the full SHA d6b7d2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ace84dc - Browse repository at this point
Copy the full SHA ace84dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8947eca - Browse repository at this point
Copy the full SHA 8947ecaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fbee28 - Browse repository at this point
Copy the full SHA 1fbee28View commit details -
resource/aws_vpc: Handle read-after-create eventual consistency (#18391)
* resource/aws_vpc: Handle read-after-create eventual consistency Reference: #16796 Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (82.88s) --- PASS: TestAccAWSVpc_basic (41.94s) --- PASS: TestAccAWSVpc_bothDnsOptionsSet (50.15s) --- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (42.24s) --- PASS: TestAccAWSVpc_classiclinkOptionSet (42.26s) --- PASS: TestAccAWSVpc_coreMismatchedDiffs (29.27s) --- PASS: TestAccAWSVpc_defaultAndIgnoreTags (62.73s) --- PASS: TestAccAWSVpc_defaultTags_providerAndResource_duplicateTag (4.83s) --- PASS: TestAccAWSVpc_defaultTags_providerAndResource_nonOverlappingTag (70.21s) --- PASS: TestAccAWSVpc_defaultTags_providerAndResource_overlappingTag (69.97s) --- PASS: TestAccAWSVpc_defaultTags_providerOnly (65.84s) --- PASS: TestAccAWSVpc_defaultTags_updateToProviderOnly (55.23s) --- PASS: TestAccAWSVpc_defaultTags_updateToResourceOnly (50.23s) --- PASS: TestAccAWSVpc_DisabledDnsSupport (49.90s) --- PASS: TestAccAWSVpc_disappears (22.42s) --- PASS: TestAccAWSVpc_ignoreTags (64.60s) --- PASS: TestAccAWSVpc_tags (82.89s) --- PASS: TestAccAWSVpc_Tenancy (84.83s) --- PASS: TestAccAWSVpc_update (67.73s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (85.77s) --- PASS: TestAccAWSVpc_basic (36.99s) --- PASS: TestAccAWSVpc_bothDnsOptionsSet (48.65s) --- PASS: TestAccAWSVpc_coreMismatchedDiffs (32.11s) --- PASS: TestAccAWSVpc_defaultAndIgnoreTags (63.25s) --- PASS: TestAccAWSVpc_defaultTags_providerAndResource_duplicateTag (4.70s) --- PASS: TestAccAWSVpc_defaultTags_providerAndResource_nonOverlappingTag (59.36s) --- PASS: TestAccAWSVpc_defaultTags_providerAndResource_overlappingTag (59.09s) --- PASS: TestAccAWSVpc_defaultTags_providerOnly (60.21s) --- PASS: TestAccAWSVpc_defaultTags_updateToProviderOnly (46.79s) --- PASS: TestAccAWSVpc_defaultTags_updateToResourceOnly (48.55s) --- PASS: TestAccAWSVpc_DisabledDnsSupport (47.71s) --- PASS: TestAccAWSVpc_disappears (23.64s) --- PASS: TestAccAWSVpc_ignoreTags (62.21s) --- PASS: TestAccAWSVpc_tags (82.23s) --- PASS: TestAccAWSVpc_Tenancy (83.42s) --- PASS: TestAccAWSVpc_update (66.22s) --- SKIP: TestAccAWSVpc_classiclinkDnsSupportOptionSet (15.15s) --- SKIP: TestAccAWSVpc_classiclinkOptionSet (15.15s) ``` * Update CHANGELOG for #18391
Configuration menu - View commit details
-
Copy full SHA for 12912ee - Browse repository at this point
Copy the full SHA 12912eeView commit details -
resource/aws_subnet: Handle read-after-create eventual consistency (#…
…18392) * resource/aws_subnet: Handle read-after-create eventual consistency Reference: #12829 Reference: #16796 Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSSubnet_availabilityZoneId (53.74s) --- PASS: TestAccAWSSubnet_basic (52.50s) --- PASS: TestAccAWSSubnet_defaultAndIgnoreTags (80.26s) --- PASS: TestAccAWSSubnet_defaultTags_providerAndResource_duplicateTag (6.45s) --- PASS: TestAccAWSSubnet_defaultTags_providerAndResource_nonOverlappingTag (84.84s) --- PASS: TestAccAWSSubnet_defaultTags_providerAndResource_overlappingTag (86.61s) --- PASS: TestAccAWSSubnet_defaultTags_providerOnly (87.99s) --- PASS: TestAccAWSSubnet_defaultTags_updateToProviderOnly (69.48s) --- PASS: TestAccAWSSubnet_defaultTags_updateToResourceOnly (72.12s) --- PASS: TestAccAWSSubnet_disappears (41.08s) --- PASS: TestAccAWSSubnet_enableIpv6 (109.36s) --- PASS: TestAccAWSSubnet_ignoreTags (81.13s) --- PASS: TestAccAWSSubnet_ipv6 (118.69s) --- PASS: TestAccAWSSubnet_MapPublicIpOnLaunch (118.55s) --- PASS: TestAccAWSSubnet_tags (106.25s) --- SKIP: TestAccAWSSubnet_CustomerOwnedIpv4Pool (1.44s) --- SKIP: TestAccAWSSubnet_MapCustomerOwnedIpOnLaunch (1.40s) --- SKIP: TestAccAWSSubnet_outpost (1.70s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSSubnet_availabilityZoneId (55.41s) --- PASS: TestAccAWSSubnet_basic (55.46s) --- PASS: TestAccAWSSubnet_defaultAndIgnoreTags (85.95s) --- PASS: TestAccAWSSubnet_defaultTags_providerAndResource_duplicateTag (6.64s) --- PASS: TestAccAWSSubnet_defaultTags_providerAndResource_nonOverlappingTag (82.23s) --- PASS: TestAccAWSSubnet_defaultTags_providerAndResource_overlappingTag (84.95s) --- PASS: TestAccAWSSubnet_defaultTags_providerOnly (86.26s) --- PASS: TestAccAWSSubnet_defaultTags_updateToProviderOnly (69.05s) --- PASS: TestAccAWSSubnet_defaultTags_updateToResourceOnly (73.74s) --- PASS: TestAccAWSSubnet_disappears (42.78s) --- PASS: TestAccAWSSubnet_enableIpv6 (117.40s) --- PASS: TestAccAWSSubnet_ignoreTags (83.74s) --- PASS: TestAccAWSSubnet_ipv6 (126.25s) --- PASS: TestAccAWSSubnet_MapPublicIpOnLaunch (124.27s) --- PASS: TestAccAWSSubnet_tags (115.31s) --- SKIP: TestAccAWSSubnet_CustomerOwnedIpv4Pool (6.95s) --- SKIP: TestAccAWSSubnet_MapCustomerOwnedIpOnLaunch (2.60s) --- SKIP: TestAccAWSSubnet_outpost (2.14s) ``` * Update CHANGELOG for #18392
Configuration menu - View commit details
-
Copy full SHA for 0016fc8 - Browse repository at this point
Copy the full SHA 0016fc8View commit details -
Update CHANGELOG.md for #18392
changelogbot committedMar 25, 2021 Configuration menu - View commit details
-
Copy full SHA for c103c41 - Browse repository at this point
Copy the full SHA c103c41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f38bb7 - Browse repository at this point
Copy the full SHA 4f38bb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2201b15 - Browse repository at this point
Copy the full SHA 2201b15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d0d370 - Browse repository at this point
Copy the full SHA 1d0d370View commit details -
r/aws_route: AWS Wavelength support.
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m === RUN TestAccAWSRoute_basic === PAUSE TestAccAWSRoute_basic === RUN TestAccAWSRoute_disappears === PAUSE TestAccAWSRoute_disappears === RUN TestAccAWSRoute_disappears_RouteTable === PAUSE TestAccAWSRoute_disappears_RouteTable === RUN TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRoute_IPv6_To_InternetGateway === PAUSE TestAccAWSRoute_IPv6_To_InternetGateway === RUN TestAccAWSRoute_IPv6_To_Instance === PAUSE TestAccAWSRoute_IPv6_To_Instance === RUN TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached === PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached === RUN TestAccAWSRoute_IPv6_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv6_To_VpnGateway === PAUSE TestAccAWSRoute_IPv6_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_VpnGateway === PAUSE TestAccAWSRoute_IPv4_To_VpnGateway === RUN TestAccAWSRoute_IPv4_To_Instance === PAUSE TestAccAWSRoute_IPv4_To_Instance === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached === RUN TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments === RUN TestAccAWSRoute_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRoute_IPv4_To_NatGateway === PAUSE TestAccAWSRoute_IPv4_To_NatGateway === RUN TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint === RUN TestAccAWSRoute_IPv4_To_TransitGateway === PAUSE TestAccAWSRoute_IPv4_To_TransitGateway === RUN TestAccAWSRoute_IPv6_To_TransitGateway === PAUSE TestAccAWSRoute_IPv6_To_TransitGateway === RUN TestAccAWSRoute_IPv4_To_CarrierGateway === PAUSE TestAccAWSRoute_IPv4_To_CarrierGateway === RUN TestAccAWSRoute_IPv4_To_LocalGateway === PAUSE TestAccAWSRoute_IPv4_To_LocalGateway === RUN TestAccAWSRoute_IPv6_To_LocalGateway === PAUSE TestAccAWSRoute_IPv6_To_LocalGateway === RUN TestAccAWSRoute_ConditionalCidrBlock === PAUSE TestAccAWSRoute_ConditionalCidrBlock === RUN TestAccAWSRoute_IPv4_Update_Target === PAUSE TestAccAWSRoute_IPv4_Update_Target === RUN TestAccAWSRoute_IPv6_Update_Target === PAUSE TestAccAWSRoute_IPv6_Update_Target === RUN TestAccAWSRoute_IPv4_To_VpcEndpoint === PAUSE TestAccAWSRoute_IPv4_To_VpcEndpoint === RUN TestAccAWSRoute_LocalRoute === PAUSE TestAccAWSRoute_LocalRoute === CONT TestAccAWSRoute_basic === CONT TestAccAWSRoute_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (27.86s) === CONT TestAccAWSRoute_LocalRoute --- PASS: TestAccAWSRoute_basic (37.05s) === CONT TestAccAWSRoute_IPv4_To_VpcEndpoint --- PASS: TestAccAWSRoute_LocalRoute (22.22s) === CONT TestAccAWSRoute_IPv6_Update_Target --- PASS: TestAccAWSRoute_IPv6_Update_Target (217.77s) === CONT TestAccAWSRoute_IPv4_Update_Target --- PASS: TestAccAWSRoute_IPv4_To_VpcEndpoint (314.58s) === CONT TestAccAWSRoute_ConditionalCidrBlock --- PASS: TestAccAWSRoute_ConditionalCidrBlock (54.25s) === CONT TestAccAWSRoute_IPv6_To_LocalGateway data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found --- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (1.28s) === CONT TestAccAWSRoute_IPv4_To_LocalGateway data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found --- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (1.16s) === CONT TestAccAWSRoute_IPv4_To_CarrierGateway --- PASS: TestAccAWSRoute_IPv4_To_CarrierGateway (25.48s) === CONT TestAccAWSRoute_IPv6_To_TransitGateway --- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (378.71s) === CONT TestAccAWSRoute_IPv4_To_TransitGateway --- PASS: TestAccAWSRoute_IPv4_Update_Target (682.34s) === CONT TestAccAWSRoute_DoesNotCrashWithVpcEndpoint --- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (42.49s) === CONT TestAccAWSRoute_IPv4_To_NatGateway --- PASS: TestAccAWSRoute_IPv4_To_NatGateway (187.94s) === CONT TestAccAWSRoute_IPv6_To_VpcPeeringConnection --- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (378.19s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments --- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (26.27s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Attached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_TwoAttachments (173.10s) === CONT TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (58.15s) === CONT TestAccAWSRoute_IPv4_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (330.77s) === CONT TestAccAWSRoute_IPv4_To_VpnGateway --- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (38.73s) === CONT TestAccAWSRoute_IPv6_To_VpnGateway --- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (37.37s) === CONT TestAccAWSRoute_IPv6_To_InternetGateway --- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (34.74s) === CONT TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached --- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (58.78s) === CONT TestAccAWSRoute_IPv6_To_Instance --- PASS: TestAccAWSRoute_IPv4_To_Instance (310.07s) === CONT TestAccAWSRoute_disappears_RouteTable --- PASS: TestAccAWSRoute_disappears_RouteTable (34.49s) === CONT TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (37.65s) === CONT TestAccAWSRoute_disappears --- PASS: TestAccAWSRoute_disappears (32.07s) --- PASS: TestAccAWSRoute_IPv6_To_Instance (328.50s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 2035.886s
Configuration menu - View commit details
-
Copy full SHA for 328a3de - Browse repository at this point
Copy the full SHA 328a3deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0597561 - Browse repository at this point
Copy the full SHA 0597561View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3e15b5 - Browse repository at this point
Copy the full SHA f3e15b5View commit details -
Merge pull request #14193 from DrFaust92/r/ecr_repo_policy
r/ecr_repository_policy - Read after update + validate `policy` + disappears test
Configuration menu - View commit details
-
Copy full SHA for 70900dd - Browse repository at this point
Copy the full SHA 70900ddView commit details -
Merge pull request #14101 from DrFaust92/r/sns_subscription_refactor
r/sns_topic_subscription - recreate on topic deletion + validations
Configuration menu - View commit details
-
Copy full SHA for 37b0efc - Browse repository at this point
Copy the full SHA 37b0efcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b79641 - Browse repository at this point
Copy the full SHA 1b79641View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b18f11 - Browse repository at this point
Copy the full SHA 3b18f11View commit details -
Merge pull request #18351 from ewbankkit/b-aws_apigatewayv2_domain_na…
…me-update r/aws_apigatewayv2_domain_name: Always send domain name configuration on update of mutual TLS configuration
Configuration menu - View commit details
-
Copy full SHA for 043fa9d - Browse repository at this point
Copy the full SHA 043fa9dView commit details
Commits on Mar 26, 2021
-
service/storagegateway: Support Cached and VTL gateway upload buffers (…
…#18313) * service/storagegateway: Support Cached and VTL gateway upload buffers Reference: #17809 The referenced issue contains the context, but the gist of this issue is that the Storage Gateway API canonicalizes the Cached and VTL disk identifiers only after first cache or upload buffer use, which means that this resource must accept the path first, then perform its own lookup after creation. This also fixes the `aws_storagegateway_local_disk` data source, which was missing `Computed` on the `disk_node` and `disk_path` attributes, which prevented it for being used to lookup one for the value of the other. Previously: ``` === CONT TestAccAWSStorageGatewayUploadBuffer_DiskPath resource_aws_storagegateway_upload_buffer_test.go:107: Step 1/2 error: Error running apply: exit status 1 Error: error reading Storage Gateway Upload Buffer (arn:aws:storagegateway:us-west-2:187416307283:gateway/sgw-D0A941B9:/dev/nvme1n1): not found on terraform_plugin_test.tf line 129, in resource "aws_storagegateway_upload_buffer" "test": 129: resource "aws_storagegateway_upload_buffer" "test" { --- FAIL: TestAccAWSStorageGatewayUploadBuffer_DiskPath (418.35s) ``` Output from acceptance testing: ``` --- PASS: TestAccAWSStorageGatewayLocalDiskDataSource_DiskNode (288.52s) --- PASS: TestAccAWSStorageGatewayLocalDiskDataSource_DiskPath (300.60s) --- PASS: TestAccAWSStorageGatewayUploadBuffer_basic (418.26s) --- PASS: TestAccAWSStorageGatewayUploadBuffer_DiskPath (444.33s) ``` * Update CHANGELOG for #18313
Configuration menu - View commit details
-
Copy full SHA for 21916ea - Browse repository at this point
Copy the full SHA 21916eaView commit details -
Update CHANGELOG.md for #18313
changelogbot committedMar 26, 2021 Configuration menu - View commit details
-
Copy full SHA for 7d36712 - Browse repository at this point
Copy the full SHA 7d36712View commit details -
service/ec2: Handle read-after-write eventual consistency issues in N…
…etwork ACL resources (#18388) * service/ec2: Handle read-after-write eventual consistency issues in Network ACL resources Reference: #16796 Reference: https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/retries-and-waiters.md#resource-lifecycle-retries Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSNetworkAcl_basic (55.36s) --- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (49.96s) --- PASS: TestAccAWSNetworkAcl_disappears (32.88s) --- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (86.30s) --- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (43.19s) --- PASS: TestAccAWSNetworkAcl_espProtocol (44.05s) --- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (83.59s) --- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (40.67s) --- PASS: TestAccAWSNetworkAcl_ipv6Rules (64.78s) --- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (52.74s) --- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (43.49s) --- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (50.78s) --- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (72.14s) --- PASS: TestAccAWSNetworkAcl_SubnetChange (74.65s) --- PASS: TestAccAWSNetworkAcl_Subnets (87.92s) --- PASS: TestAccAWSNetworkAcl_SubnetsDelete (81.74s) --- PASS: TestAccAWSNetworkAcl_tags (74.60s) --- PASS: TestAccAWSNetworkAclRule_allProtocol (69.48s) --- PASS: TestAccAWSNetworkAclRule_basic (54.04s) --- PASS: TestAccAWSNetworkAclRule_disappears (30.99s) --- PASS: TestAccAWSNetworkAclRule_disappears_IngressEgressSameNumber (41.45s) --- PASS: TestAccAWSNetworkAclRule_disappears_NetworkAcl (40.04s) --- PASS: TestAccAWSNetworkAclRule_ipv6 (45.12s) --- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (47.00s) --- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (72.25s) --- PASS: TestAccAWSNetworkAclRule_tcpProtocol (61.69s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSNetworkAcl_basic (58.57s) --- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (94.47s) --- PASS: TestAccAWSNetworkAcl_disappears (60.54s) --- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (99.32s) --- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (74.30s) --- PASS: TestAccAWSNetworkAcl_espProtocol (63.01s) --- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (129.73s) --- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (64.84s) --- PASS: TestAccAWSNetworkAcl_ipv6Rules (95.18s) --- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (61.43s) --- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (86.34s) --- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (87.57s) --- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (129.92s) --- PASS: TestAccAWSNetworkAcl_SubnetChange (144.88s) --- PASS: TestAccAWSNetworkAcl_Subnets (144.73s) --- PASS: TestAccAWSNetworkAcl_SubnetsDelete (120.00s) --- PASS: TestAccAWSNetworkAcl_tags (122.44s) --- PASS: TestAccAWSNetworkAclRule_allProtocol (72.14s) --- PASS: TestAccAWSNetworkAclRule_basic (95.37s) --- PASS: TestAccAWSNetworkAclRule_disappears (61.95s) --- PASS: TestAccAWSNetworkAclRule_disappears_IngressEgressSameNumber (56.73s) --- PASS: TestAccAWSNetworkAclRule_disappears_NetworkAcl (65.84s) --- PASS: TestAccAWSNetworkAclRule_ipv6 (89.03s) --- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (81.90s) --- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (123.78s) --- PASS: TestAccAWSNetworkAclRule_missingParam (27.16s) --- PASS: TestAccAWSNetworkAclRule_tcpProtocol (88.83s) ``` * Update CHANGELOG for #18388
Configuration menu - View commit details
-
Copy full SHA for 43a4da2 - Browse repository at this point
Copy the full SHA 43a4da2View commit details -
Update CHANGELOG.md for #18388
changelogbot committedMar 26, 2021 Configuration menu - View commit details
-
Copy full SHA for d732881 - Browse repository at this point
Copy the full SHA d732881View commit details -
tests/provider: Add missing ErrorCheck
Previously: ``` Error: /home/runner/work/terraform-provider-aws/terraform-provider-aws/aws/resource_aws_config_configuration_aggregator_test.go:209:36: XAT001: missing ErrorCheck 208 209 resource.ParallelTest(t, resource.TestCase{ 210 PreCheck: func() { testAccPreCheck(t) }, Error: /home/runner/work/terraform-provider-aws/terraform-provider-aws/aws/resource_aws_ecr_repository_policy_test.go:84:36: XAT001: missing ErrorCheck 83 84 resource.ParallelTest(t, resource.TestCase{ 85 PreCheck: func() { testAccPreCheck(t) }, Error: /home/runner/work/terraform-provider-aws/terraform-provider-aws/aws/resource_aws_ecr_repository_policy_test.go:105:36: XAT001: missing ErrorCheck 104 105 resource.ParallelTest(t, resource.TestCase{ 106 PreCheck: func() { testAccPreCheck(t) }, Error: /home/runner/work/terraform-provider-aws/terraform-provider-aws/aws/resource_aws_sns_topic_subscription_test.go:444:36: XAT001: missing ErrorCheck 443 444 resource.ParallelTest(t, resource.TestCase{ 445 PreCheck: func() { testAccPreCheck(t) }, Error: /home/runner/work/terraform-provider-aws/terraform-provider-aws/aws/resource_aws_sns_topic_subscription_test.go:466:36: XAT001: missing ErrorCheck 465 466 resource.ParallelTest(t, resource.TestCase{ 467 PreCheck: func() { testAccPreCheck(t) }, make: *** [GNUmakefile:92: awsproviderlint] Error 3 ```
Configuration menu - View commit details
-
Copy full SHA for c646ad6 - Browse repository at this point
Copy the full SHA c646ad6View commit details -
tf-release-bot authored and TeamCity committed
Mar 26, 2021 Configuration menu - View commit details
-
Copy full SHA for bf230a0 - Browse repository at this point
Copy the full SHA bf230a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33560da - Browse repository at this point
Copy the full SHA 33560daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 271f7db - Browse repository at this point
Copy the full SHA 271f7dbView commit details -
provider: Migrate to iamwaiter.PropagationTimeout constant and begin …
…enabling go-mnd linter (#17811) Reference: #13199 Reference: #16752 Reference: #16753 IAM eventual consistency handling has long been the source of needing retries in resource logic. Due to the lack of a consistent implementation (e.g. static constant) for how long to retry for these types of errors, there have been varying retry durations. The `iamwaiter.PropagationTimeout` constant was introduced for this purpose. This change begins by introducing the `go-mnd` linter to enforce the usage of constants in function arguments. Example reports below. The rest of the changes are the minimum required to ensure `iamwaiter.PropagationTimeout` with its 2 minute duration is applied. You will note that this is fixing the duration in some cases to slightly increase it to the standard value. Any higher durations are ignored to reduce changes for now. As such, this can be reviewed by validating that a lower duration was not introduced and skipping acceptance testing since no logic changes should be introduced. One caveat to `go-mnd` is that it currently ignores `1` as a magic number, which is possible in usage such as `1*time.Minute`, and that ignored number cannot be overriden. An upstream issue will be created to ask the `ignore-number` configuration to overwrite instead of append. Example previous report: ``` aws/resource_aws_api_gateway_account.go:99:23: mnd: Magic number: 2, in <argument> detected (gomnd) err = resource.Retry(2*time.Minute, func() *resource.RetryError { ^ ```
Configuration menu - View commit details
-
Copy full SHA for f17c81e - Browse repository at this point
Copy the full SHA f17c81eView commit details -
tests/provider: Fix and enable AWS SDK Go pointer conversion linting …
…(T-W resources) (#18353) Reference: #12992 Previously: ``` aws/resource_aws_transfer_ssh_key.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-assignment: Prefer AWS Go SDK pointer conversion functions for dereferencing during assignment, e.g. aws.StringValue() 101: body = *s.SshPublicKeyBody -------------------------------------------------------------------------------- severity:warning rule:prefer-aws-go-sdk-pointer-conversion-conditional: Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g. aws.StringValue() 100: if sshKeyID == *s.SshPublicKeyId { aws/resource_aws_volume_attachment.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-conditional: Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g. aws.StringValue() 179: if a.InstanceId != nil && *a.InstanceId == instanceID { -------------------------------------------------------------------------------- 215: if len(vols.Volumes) == 0 || *vols.Volumes[0].State == ec2.VolumeStateAvailable { aws/resource_aws_vpc.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-assignment: Prefer AWS Go SDK pointer conversion functions for dereferencing during assignment, e.g. aws.StringValue() 339: classiclink_enabled = *v.ClassicLinkEnabled -------------------------------------------------------------------------------- 364: classiclinkdns_enabled = *v.ClassicLinkDnsSupported -------------------------------------------------------------------------------- severity:warning rule:prefer-aws-go-sdk-pointer-conversion-conditional: Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g. aws.StringValue() 337: if *v.VpcId == vpcid { -------------------------------------------------------------------------------- 362: if *v.VpcId == vpcid { aws/resource_aws_vpc_peering_connection.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-conditional: Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g. aws.StringValue() 146: if (client.accountid == *pc.AccepterVpcInfo.OwnerId) && (client.accountid != *pc.RequesterVpcInfo.OwnerId) { -------------------------------------------------------------------------------- 146: if (client.accountid == *pc.AccepterVpcInfo.OwnerId) && (client.accountid != *pc.RequesterVpcInfo.OwnerId) { aws/resource_aws_vpn_connection_route.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-conditional: Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g. aws.StringValue() 158: if *r.DestinationCidrBlock == cidrBlock && *r.State != "deleted" { -------------------------------------------------------------------------------- 158: if *r.DestinationCidrBlock == cidrBlock && *r.State != "deleted" { aws/resource_aws_vpn_gateway_route_propagation.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-conditional: Prefer AWS Go SDK pointer conversion functions for dereferencing during conditionals, e.g. aws.StringValue() 90: if *vgw.GatewayId == gwID { aws/resource_aws_waf_sql_injection_match_set.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-assignment: Prefer AWS Go SDK pointer conversion functions for dereferencing during assignment, e.g. aws.StringValue() 179: m["text_transformation"] = *t.TextTransformation aws/resource_aws_wafregional_rule.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-assignment: Prefer AWS Go SDK pointer conversion functions for dereferencing during assignment, e.g. aws.StringValue() 228: m["negated"] = *p.Negated -------------------------------------------------------------------------------- 229: m["type"] = *p.Type -------------------------------------------------------------------------------- 230: m["data_id"] = *p.DataId aws/resource_aws_workspaces_ip_group.go severity:warning rule:prefer-aws-go-sdk-pointer-conversion-assignment: Prefer AWS Go SDK pointer conversion functions for dereferencing during assignment, e.g. aws.StringValue() 219: r["description"] = *rule.RuleDesc ran 15 rules on 2163 files: 18 findings ``` Output from acceptance testing: ``` --- PASS: TestAccAWSTransferSshKey_basic (172.65s) --- PASS: TestAccAWSVolumeAttachment_attachStopped (379.45s) --- PASS: TestAccAWSVolumeAttachment_basic (137.33s) --- PASS: TestAccAWSVolumeAttachment_disappears (127.64s) --- PASS: TestAccAWSVolumeAttachment_skipDestroy (106.70s) --- PASS: TestAccAWSVolumeAttachment_update (117.94s) --- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (96.85s) --- PASS: TestAccAWSVpc_basic (35.87s) --- PASS: TestAccAWSVpc_bothDnsOptionsSet (45.41s) --- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (39.09s) --- PASS: TestAccAWSVpc_classiclinkOptionSet (38.76s) --- PASS: TestAccAWSVpc_coreMismatchedDiffs (30.39s) --- PASS: TestAccAWSVpc_defaultAndIgnoreTags (69.04s) --- PASS: TestAccAWSVpc_defaultTags_providerAndResource_duplicateTag (5.12s) --- PASS: TestAccAWSVpc_defaultTags_providerAndResource_nonOverlappingTag (74.60s) --- PASS: TestAccAWSVpc_defaultTags_providerAndResource_overlappingTag (77.40s) --- PASS: TestAccAWSVpc_defaultTags_providerOnly (74.67s) --- PASS: TestAccAWSVpc_defaultTags_updateToProviderOnly (53.56s) --- PASS: TestAccAWSVpc_defaultTags_updateToResourceOnly (54.07s) --- PASS: TestAccAWSVpc_DisabledDnsSupport (44.39s) --- PASS: TestAccAWSVpc_disappears (21.95s) --- PASS: TestAccAWSVpc_ignoreTags (69.04s) --- PASS: TestAccAWSVpc_tags (79.06s) --- PASS: TestAccAWSVpc_Tenancy (77.06s) --- PASS: TestAccAWSVpc_update (58.54s) --- FAIL: TestAccAWSVPCPeeringConnection_region (39.86s) # #18348 --- PASS: TestAccAWSVPCPeeringConnection_accept (81.01s) --- PASS: TestAccAWSVPCPeeringConnection_basic (43.58s) --- PASS: TestAccAWSVPCPeeringConnection_failedState (18.09s) --- PASS: TestAccAWSVPCPeeringConnection_options (78.71s) --- PASS: TestAccAWSVPCPeeringConnection_optionsNoAutoAccept (30.00s) --- PASS: TestAccAWSVPCPeeringConnection_peerRegionAutoAccept (16.39s) --- PASS: TestAccAWSVPCPeeringConnection_plan (31.03s) --- PASS: TestAccAWSVPCPeeringConnection_tags (85.86s) --- PASS: TestAccAWSVpnConnectionRoute_basic (457.75s) --- PASS: TestAccAWSVPNGatewayRoutePropagation_basic (55.88s) --- PASS: TestAccAWSWafRegionalRule_basic (61.65s) --- PASS: TestAccAWSWafRegionalRule_changeNameForceNew (107.77s) --- PASS: TestAccAWSWafRegionalRule_changePredicates (103.24s) --- PASS: TestAccAWSWafRegionalRule_disappears (64.90s) --- PASS: TestAccAWSWafRegionalRule_noPredicates (44.78s) --- PASS: TestAccAWSWafRegionalRule_tags (97.70s) --- PASS: TestAccAWSWafSqlInjectionMatchSet_basic (21.90s) --- PASS: TestAccAWSWafSqlInjectionMatchSet_changeNameForceNew (38.62s) --- PASS: TestAccAWSWafSqlInjectionMatchSet_changeTuples (35.26s) --- PASS: TestAccAWSWafSqlInjectionMatchSet_disappears (16.76s) --- PASS: TestAccAWSWafSqlInjectionMatchSet_noTuples (20.81s) --- FAIL: TestAccAwsWorkspacesIpGroup_MultipleDirectories (612.05s) # #18352 --- PASS: TestAccAwsWorkspacesIpGroup_basic (44.84s) --- PASS: TestAccAwsWorkspacesIpGroup_disappears (24.70s) --- PASS: TestAccAwsWorkspacesIpGroup_tags (69.57s) ```
Configuration menu - View commit details
-
Copy full SHA for a59bcfa - Browse repository at this point
Copy the full SHA a59bcfaView commit details -
Merge pull request #16961 from ewbankkit/f-aws_route-wavelength
r/aws_route: AWS Wavelength support
Configuration menu - View commit details
-
Copy full SHA for 43f50a5 - Browse repository at this point
Copy the full SHA 43f50a5View commit details -
r/aws_route_table: AWS Wavelength support.
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteTable_ -timeout 120m === RUN TestAccAWSRouteTable_basic === PAUSE TestAccAWSRouteTable_basic === RUN TestAccAWSRouteTable_disappears === PAUSE TestAccAWSRouteTable_disappears === RUN TestAccAWSRouteTable_disappears_SubnetAssociation === PAUSE TestAccAWSRouteTable_disappears_SubnetAssociation === RUN TestAccAWSRouteTable_IPv4_To_InternetGateway === PAUSE TestAccAWSRouteTable_IPv4_To_InternetGateway === RUN TestAccAWSRouteTable_IPv4_To_Instance === PAUSE TestAccAWSRouteTable_IPv4_To_Instance === RUN TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRouteTable_tags === PAUSE TestAccAWSRouteTable_tags === RUN TestAccAWSRouteTable_RequireRouteDestination === PAUSE TestAccAWSRouteTable_RequireRouteDestination === RUN TestAccAWSRouteTable_RequireRouteTarget === PAUSE TestAccAWSRouteTable_RequireRouteTarget === RUN TestAccAWSRouteTable_Route_ConfigMode === PAUSE TestAccAWSRouteTable_Route_ConfigMode === RUN TestAccAWSRouteTable_IPv4_To_TransitGateway === PAUSE TestAccAWSRouteTable_IPv4_To_TransitGateway === RUN TestAccAWSRouteTable_IPv4_To_VpcEndpoint === PAUSE TestAccAWSRouteTable_IPv4_To_VpcEndpoint === RUN TestAccAWSRouteTable_IPv4_To_CarrierGateway === PAUSE TestAccAWSRouteTable_IPv4_To_CarrierGateway === RUN TestAccAWSRouteTable_IPv4_To_LocalGateway === PAUSE TestAccAWSRouteTable_IPv4_To_LocalGateway === RUN TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRouteTable_vgwRoutePropagation === PAUSE TestAccAWSRouteTable_vgwRoutePropagation === RUN TestAccAWSRouteTable_ConditionalCidrBlock === PAUSE TestAccAWSRouteTable_ConditionalCidrBlock === RUN TestAccAWSRouteTable_IPv4_To_NatGateway === PAUSE TestAccAWSRouteTable_IPv4_To_NatGateway === RUN TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached === PAUSE TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached === RUN TestAccAWSRouteTable_VpcMultipleCidrs === PAUSE TestAccAWSRouteTable_VpcMultipleCidrs === RUN TestAccAWSRouteTable_VpcClassicLink === PAUSE TestAccAWSRouteTable_VpcClassicLink === RUN TestAccAWSRouteTable_GatewayVpcEndpoint === PAUSE TestAccAWSRouteTable_GatewayVpcEndpoint === RUN TestAccAWSRouteTable_MultipleRoutes === PAUSE TestAccAWSRouteTable_MultipleRoutes === CONT TestAccAWSRouteTable_basic === CONT TestAccAWSRouteTable_IPv4_To_CarrierGateway --- PASS: TestAccAWSRouteTable_basic (22.53s) === CONT TestAccAWSRouteTable_MultipleRoutes --- PASS: TestAccAWSRouteTable_IPv4_To_CarrierGateway (27.08s) === CONT TestAccAWSRouteTable_GatewayVpcEndpoint --- PASS: TestAccAWSRouteTable_GatewayVpcEndpoint (38.31s) === CONT TestAccAWSRouteTable_VpcClassicLink --- PASS: TestAccAWSRouteTable_VpcClassicLink (22.43s) === CONT TestAccAWSRouteTable_VpcMultipleCidrs --- PASS: TestAccAWSRouteTable_VpcMultipleCidrs (44.06s) === CONT TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached --- PASS: TestAccAWSRouteTable_MultipleRoutes (167.25s) === CONT TestAccAWSRouteTable_IPv4_To_NatGateway --- PASS: TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached (64.25s) === CONT TestAccAWSRouteTable_ConditionalCidrBlock --- PASS: TestAccAWSRouteTable_ConditionalCidrBlock (52.89s) === CONT TestAccAWSRouteTable_vgwRoutePropagation --- PASS: TestAccAWSRouteTable_vgwRoutePropagation (65.65s) === CONT TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection (26.92s) === CONT TestAccAWSRouteTable_IPv4_To_LocalGateway data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found --- SKIP: TestAccAWSRouteTable_IPv4_To_LocalGateway (1.76s) === CONT TestAccAWSRouteTable_tags --- PASS: TestAccAWSRouteTable_IPv4_To_NatGateway (216.05s) === CONT TestAccAWSRouteTable_IPv4_To_VpcEndpoint --- PASS: TestAccAWSRouteTable_tags (69.02s) === CONT TestAccAWSRouteTable_IPv4_To_TransitGateway --- PASS: TestAccAWSRouteTable_IPv4_To_VpcEndpoint (297.37s) === CONT TestAccAWSRouteTable_Route_ConfigMode --- PASS: TestAccAWSRouteTable_Route_ConfigMode (70.12s) === CONT TestAccAWSRouteTable_RequireRouteTarget --- PASS: TestAccAWSRouteTable_RequireRouteTarget (11.79s) === CONT TestAccAWSRouteTable_RequireRouteDestination === CONT TestAccAWSRouteTable_IPv4_To_InternetGateway --- PASS: TestAccAWSRouteTable_IPv4_To_TransitGateway (411.37s) --- PASS: TestAccAWSRouteTable_IPv4_To_InternetGateway (64.50s) === CONT TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway --- PASS: TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway (47.10s) === CONT TestAccAWSRouteTable_IPv4_To_Instance --- PASS: TestAccAWSRouteTable_RequireRouteDestination (314.49s) === CONT TestAccAWSRouteTable_disappears_SubnetAssociation --- PASS: TestAccAWSRouteTable_disappears_SubnetAssociation (24.60s) === CONT TestAccAWSRouteTable_disappears --- PASS: TestAccAWSRouteTable_disappears (19.61s) --- PASS: TestAccAWSRouteTable_IPv4_To_Instance (324.26s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 1259.709s
Configuration menu - View commit details
-
Copy full SHA for b02094f - Browse repository at this point
Copy the full SHA b02094fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e544066 - Browse repository at this point
Copy the full SHA e544066View commit details -
Revert "r/aws_default_route_table: AWS Wavelength support."
This reverts commit a32cff5e705ae5c7f841c1743d8f7f84500d0294.
Configuration menu - View commit details
-
Copy full SHA for 3b6ddfe - Browse repository at this point
Copy the full SHA 3b6ddfeView commit details -
r/aws_default_route_table: Add 'arn' attribute.
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultRouteTable_' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSDefaultRouteTable_ -timeout 120m === RUN TestAccAWSDefaultRouteTable_basic === PAUSE TestAccAWSDefaultRouteTable_basic === RUN TestAccAWSDefaultRouteTable_disappears_Vpc === PAUSE TestAccAWSDefaultRouteTable_disappears_Vpc === RUN TestAccAWSDefaultRouteTable_Route_ConfigMode === PAUSE TestAccAWSDefaultRouteTable_Route_ConfigMode === RUN TestAccAWSDefaultRouteTable_swap === PAUSE TestAccAWSDefaultRouteTable_swap === RUN TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway === PAUSE TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway === RUN TestAccAWSDefaultRouteTable_IPv4_To_VpcEndpoint === PAUSE TestAccAWSDefaultRouteTable_IPv4_To_VpcEndpoint === RUN TestAccAWSDefaultRouteTable_VpcEndpointAssociation === PAUSE TestAccAWSDefaultRouteTable_VpcEndpointAssociation === RUN TestAccAWSDefaultRouteTable_tags === PAUSE TestAccAWSDefaultRouteTable_tags === RUN TestAccAWSDefaultRouteTable_ConditionalCidrBlock === PAUSE TestAccAWSDefaultRouteTable_ConditionalCidrBlock === CONT TestAccAWSDefaultRouteTable_basic === CONT TestAccAWSDefaultRouteTable_IPv4_To_VpcEndpoint --- PASS: TestAccAWSDefaultRouteTable_basic (29.97s) === CONT TestAccAWSDefaultRouteTable_ConditionalCidrBlock --- PASS: TestAccAWSDefaultRouteTable_ConditionalCidrBlock (54.15s) === CONT TestAccAWSDefaultRouteTable_tags --- PASS: TestAccAWSDefaultRouteTable_tags (52.24s) === CONT TestAccAWSDefaultRouteTable_VpcEndpointAssociation --- PASS: TestAccAWSDefaultRouteTable_VpcEndpointAssociation (44.51s) === CONT TestAccAWSDefaultRouteTable_swap --- PASS: TestAccAWSDefaultRouteTable_swap (91.07s) === CONT TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway === CONT TestAccAWSDefaultRouteTable_Route_ConfigMode --- PASS: TestAccAWSDefaultRouteTable_IPv4_To_VpcEndpoint (323.68s) --- PASS: TestAccAWSDefaultRouteTable_Route_ConfigMode (84.01s) === CONT TestAccAWSDefaultRouteTable_disappears_Vpc --- PASS: TestAccAWSDefaultRouteTable_disappears_Vpc (14.13s) --- PASS: TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway (400.11s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 672.134s
Configuration menu - View commit details
-
Copy full SHA for 406cdd6 - Browse repository at this point
Copy the full SHA 406cdd6View commit details -
r/aws_route_table: Better documentation of attribute-as-blocks mode f…
…or 'route' attribute.
Configuration menu - View commit details
-
Copy full SHA for 7aba268 - Browse repository at this point
Copy the full SHA 7aba268View commit details -
r/aws_default_route_table: Better documentation of attribute-as-block…
…s mode for 'route' attribute.
Configuration menu - View commit details
-
Copy full SHA for 27cc72d - Browse repository at this point
Copy the full SHA 27cc72dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7208fbc - Browse repository at this point
Copy the full SHA 7208fbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3de8d25 - Browse repository at this point
Copy the full SHA 3de8d25View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3d5d16 - Browse repository at this point
Copy the full SHA f3d5d16View commit details -
Revert "r/aws_default_route_table: AWS Wavelength support."
This reverts commit a32cff5e705ae5c7f841c1743d8f7f84500d0294.
Configuration menu - View commit details
-
Copy full SHA for b3674ec - Browse repository at this point
Copy the full SHA b3674ecView commit details -
r/aws_default_route_table: Add 'arn' attribute.
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultRouteTable_' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSDefaultRouteTable_ -timeout 120m === RUN TestAccAWSDefaultRouteTable_basic === PAUSE TestAccAWSDefaultRouteTable_basic === RUN TestAccAWSDefaultRouteTable_disappears_Vpc === PAUSE TestAccAWSDefaultRouteTable_disappears_Vpc === RUN TestAccAWSDefaultRouteTable_Route_ConfigMode === PAUSE TestAccAWSDefaultRouteTable_Route_ConfigMode === RUN TestAccAWSDefaultRouteTable_swap === PAUSE TestAccAWSDefaultRouteTable_swap === RUN TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway === PAUSE TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway === RUN TestAccAWSDefaultRouteTable_IPv4_To_VpcEndpoint === PAUSE TestAccAWSDefaultRouteTable_IPv4_To_VpcEndpoint === RUN TestAccAWSDefaultRouteTable_VpcEndpointAssociation === PAUSE TestAccAWSDefaultRouteTable_VpcEndpointAssociation === RUN TestAccAWSDefaultRouteTable_tags === PAUSE TestAccAWSDefaultRouteTable_tags === RUN TestAccAWSDefaultRouteTable_ConditionalCidrBlock === PAUSE TestAccAWSDefaultRouteTable_ConditionalCidrBlock === CONT TestAccAWSDefaultRouteTable_basic === CONT TestAccAWSDefaultRouteTable_IPv4_To_VpcEndpoint --- PASS: TestAccAWSDefaultRouteTable_basic (29.97s) === CONT TestAccAWSDefaultRouteTable_ConditionalCidrBlock --- PASS: TestAccAWSDefaultRouteTable_ConditionalCidrBlock (54.15s) === CONT TestAccAWSDefaultRouteTable_tags --- PASS: TestAccAWSDefaultRouteTable_tags (52.24s) === CONT TestAccAWSDefaultRouteTable_VpcEndpointAssociation --- PASS: TestAccAWSDefaultRouteTable_VpcEndpointAssociation (44.51s) === CONT TestAccAWSDefaultRouteTable_swap --- PASS: TestAccAWSDefaultRouteTable_swap (91.07s) === CONT TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway === CONT TestAccAWSDefaultRouteTable_Route_ConfigMode --- PASS: TestAccAWSDefaultRouteTable_IPv4_To_VpcEndpoint (323.68s) --- PASS: TestAccAWSDefaultRouteTable_Route_ConfigMode (84.01s) === CONT TestAccAWSDefaultRouteTable_disappears_Vpc --- PASS: TestAccAWSDefaultRouteTable_disappears_Vpc (14.13s) --- PASS: TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway (400.11s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 672.134s
Configuration menu - View commit details
-
Copy full SHA for 2c07639 - Browse repository at this point
Copy the full SHA 2c07639View commit details -
r/aws_default_route_table: Better documentation of attribute-as-block…
…s mode for 'route' attribute.
Configuration menu - View commit details
-
Copy full SHA for 929876e - Browse repository at this point
Copy the full SHA 929876eView commit details -
r/aws_route_table: Add 'ErrorCheck' to new acceptance tests.
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteTable_' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteTable_ -timeout 180m === RUN TestAccAWSRouteTable_basic === PAUSE TestAccAWSRouteTable_basic === RUN TestAccAWSRouteTable_disappears === PAUSE TestAccAWSRouteTable_disappears === RUN TestAccAWSRouteTable_disappears_SubnetAssociation === PAUSE TestAccAWSRouteTable_disappears_SubnetAssociation === RUN TestAccAWSRouteTable_IPv4_To_InternetGateway === PAUSE TestAccAWSRouteTable_IPv4_To_InternetGateway === RUN TestAccAWSRouteTable_IPv4_To_Instance === PAUSE TestAccAWSRouteTable_IPv4_To_Instance === RUN TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway === PAUSE TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway === RUN TestAccAWSRouteTable_tags === PAUSE TestAccAWSRouteTable_tags === RUN TestAccAWSRouteTable_RequireRouteDestination === PAUSE TestAccAWSRouteTable_RequireRouteDestination === RUN TestAccAWSRouteTable_RequireRouteTarget === PAUSE TestAccAWSRouteTable_RequireRouteTarget === RUN TestAccAWSRouteTable_Route_ConfigMode === PAUSE TestAccAWSRouteTable_Route_ConfigMode === RUN TestAccAWSRouteTable_IPv4_To_TransitGateway === PAUSE TestAccAWSRouteTable_IPv4_To_TransitGateway === RUN TestAccAWSRouteTable_IPv4_To_VpcEndpoint === PAUSE TestAccAWSRouteTable_IPv4_To_VpcEndpoint === RUN TestAccAWSRouteTable_IPv4_To_CarrierGateway === PAUSE TestAccAWSRouteTable_IPv4_To_CarrierGateway === RUN TestAccAWSRouteTable_IPv4_To_LocalGateway === PAUSE TestAccAWSRouteTable_IPv4_To_LocalGateway === RUN TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection === PAUSE TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection === RUN TestAccAWSRouteTable_vgwRoutePropagation === PAUSE TestAccAWSRouteTable_vgwRoutePropagation === RUN TestAccAWSRouteTable_ConditionalCidrBlock === PAUSE TestAccAWSRouteTable_ConditionalCidrBlock === RUN TestAccAWSRouteTable_IPv4_To_NatGateway === PAUSE TestAccAWSRouteTable_IPv4_To_NatGateway === RUN TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached === PAUSE TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached === RUN TestAccAWSRouteTable_VpcMultipleCidrs === PAUSE TestAccAWSRouteTable_VpcMultipleCidrs === RUN TestAccAWSRouteTable_VpcClassicLink === PAUSE TestAccAWSRouteTable_VpcClassicLink === RUN TestAccAWSRouteTable_GatewayVpcEndpoint === PAUSE TestAccAWSRouteTable_GatewayVpcEndpoint === RUN TestAccAWSRouteTable_MultipleRoutes === PAUSE TestAccAWSRouteTable_MultipleRoutes === CONT TestAccAWSRouteTable_basic === CONT TestAccAWSRouteTable_IPv4_To_CarrierGateway --- PASS: TestAccAWSRouteTable_basic (23.03s) === CONT TestAccAWSRouteTable_MultipleRoutes --- PASS: TestAccAWSRouteTable_IPv4_To_CarrierGateway (27.07s) === CONT TestAccAWSRouteTable_GatewayVpcEndpoint --- PASS: TestAccAWSRouteTable_GatewayVpcEndpoint (38.36s) === CONT TestAccAWSRouteTable_VpcClassicLink --- PASS: TestAccAWSRouteTable_VpcClassicLink (23.18s) === CONT TestAccAWSRouteTable_VpcMultipleCidrs --- PASS: TestAccAWSRouteTable_VpcMultipleCidrs (44.45s) === CONT TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached --- PASS: TestAccAWSRouteTable_IPv6_To_NetworkInterface_Unattached (64.43s) === CONT TestAccAWSRouteTable_IPv4_To_NatGateway --- PASS: TestAccAWSRouteTable_MultipleRoutes (174.60s) === CONT TestAccAWSRouteTable_ConditionalCidrBlock --- PASS: TestAccAWSRouteTable_ConditionalCidrBlock (54.34s) === CONT TestAccAWSRouteTable_vgwRoutePropagation --- PASS: TestAccAWSRouteTable_vgwRoutePropagation (78.89s) === CONT TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection --- PASS: TestAccAWSRouteTable_IPv4_To_VpcPeeringConnection (26.74s) === CONT TestAccAWSRouteTable_IPv4_To_LocalGateway data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found === CONT TestAccAWSRouteTable_tags --- SKIP: TestAccAWSRouteTable_IPv4_To_LocalGateway (0.60s) --- PASS: TestAccAWSRouteTable_tags (68.15s) === CONT TestAccAWSRouteTable_IPv4_To_VpcEndpoint --- PASS: TestAccAWSRouteTable_IPv4_To_NatGateway (237.14s) === CONT TestAccAWSRouteTable_IPv4_To_TransitGateway --- PASS: TestAccAWSRouteTable_IPv4_To_VpcEndpoint (287.82s) === CONT TestAccAWSRouteTable_Route_ConfigMode --- PASS: TestAccAWSRouteTable_Route_ConfigMode (70.96s) === CONT TestAccAWSRouteTable_RequireRouteTarget --- PASS: TestAccAWSRouteTable_RequireRouteTarget (12.27s) === CONT TestAccAWSRouteTable_RequireRouteDestination --- PASS: TestAccAWSRouteTable_IPv4_To_TransitGateway (402.33s) === CONT TestAccAWSRouteTable_IPv4_To_InternetGateway --- PASS: TestAccAWSRouteTable_IPv4_To_InternetGateway (63.20s) === CONT TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway === CONT TestAccAWSRouteTable_IPv4_To_Instance --- PASS: TestAccAWSRouteTable_IPv6_To_EgressOnlyInternetGateway (47.99s) --- PASS: TestAccAWSRouteTable_IPv4_To_Instance (123.37s) === CONT TestAccAWSRouteTable_disappears_SubnetAssociation --- PASS: TestAccAWSRouteTable_disappears_SubnetAssociation (25.30s) === CONT TestAccAWSRouteTable_disappears --- PASS: TestAccAWSRouteTable_disappears (20.39s) --- PASS: TestAccAWSRouteTable_RequireRouteDestination (324.41s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 1121.930s
Configuration menu - View commit details
-
Copy full SHA for 5770269 - Browse repository at this point
Copy the full SHA 5770269View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b4fba4 - Browse repository at this point
Copy the full SHA 0b4fba4View commit details -
Error checking Terraform Provider documentation: 2 errors occurred: * website/docs/r/default_route_table.html.markdown: error checking file contents: example section code block language (hcl) should be: ```terraform * website/docs/r/route_table.html.markdown: error checking file contents: example section code block language (hcl) should be: ```terraform
Configuration menu - View commit details
-
Copy full SHA for bfba3e9 - Browse repository at this point
Copy the full SHA bfba3e9View commit details -
tests/provider: Bootstrap d.IsNewResource() semgrep rule and fix some…
… A resources to start (#18346) * tests/provider: Bootstrap d.IsNewResource() semgrep rule and fix some A resources to start Reference: #16796 During resource creation, Terraform CLI expects either a properly applied state for the new resource or an error. To signal proper resource existence, the Terraform Plugin SDK uses an underlying resource identifier (set via `d.SetId(/* some value */)`). If for some reason the resource creation is returned without an error, but also without the resource identifier being set, Terraform CLI will return an error such as: ``` Error: Provider produced inconsistent result after apply When applying changes to aws_sns_topic_subscription.sqs, provider "registry.terraform.io/hashicorp/aws" produced an unexpected new value: Root resource was present, but now absent. This is a bug in the provider, which should be reported in the provider's own issue tracker. ``` A typical pattern in resource implementations in the `Create`/`CreateContext` function is to `return` the `Read`/`ReadContext` function at the end to fill in the Terraform State for all attributes. Another typical pattern in resource implementations in the `Read`/`ReadContext` function is to remove the resource from the Terraform State if the remote system returns an error or status that indicates the remote resource no longer exists by explicitly calling `d.SetId("")` and returning no error. If the remote system is not strongly read-after-write consistent (eventually consistent), this means the resource creation can return no error and also return no resource state. To prevent this type of Terraform CLI error, the resource implementation should also check against `d.IsNewResource()` before removing from the Terraform State and returning no error. If that check is `true`, then remote operation error (or one synthesized from the non-existent status) should be returned instead. While adding this check will not fix the resource implementation to handle the eventually consistent nature of the remote system, the error being returned will be less opaque for operators and code maintainers to troubleshoot. Previously: ``` aws/resource_aws_accessanalyzer_analyzer.go severity:warning rule:helper-schema-ResourceData-SetId-empty-without-IsNewResource-check: Calling `d.SetId("")` should ensure `!d.IsNewResource()` is checked first 115: d.SetId("") 116: return nil aws/resource_aws_acm_certificate_validation.go severity:warning rule:helper-schema-ResourceData-SetId-empty-without-IsNewResource-check: Calling `d.SetId("")` should ensure `!d.IsNewResource()` is checked first 181: d.SetId("") 182: return nil aws/resource_aws_acmpca_certificate.go severity:warning rule:helper-schema-ResourceData-SetId-empty-without-IsNewResource-check: Calling `d.SetId("")` should ensure `!d.IsNewResource()` is checked first 175: d.SetId("") 176: return nil aws/resource_aws_acmpca_certificate_authority.go severity:warning rule:helper-schema-ResourceData-SetId-empty-without-IsNewResource-check: Calling `d.SetId("")` should ensure `!d.IsNewResource()` is checked first 329: d.SetId("") 330: return nil -------------------------------------------------------------------------------- 339: d.SetId("") 340: return nil -------------------------------------------------------------------------------- 371: d.SetId("") 372: return nil -------------------------------------------------------------------------------- 398: d.SetId("") 399: return nil aws/resource_aws_ami.go severity:warning rule:helper-schema-ResourceData-SetId-empty-without-IsNewResource-check: Calling `d.SetId("")` should ensure `!d.IsNewResource()` is checked first 344: d.SetId("") 345: return nil -------------------------------------------------------------------------------- 361: d.SetId("") 362: return nil -------------------------------------------------------------------------------- 383: d.SetId("") 384: return nil aws/resource_aws_ami_launch_permission.go severity:warning rule:helper-schema-ResourceData-SetId-empty-without-IsNewResource-check: Calling `d.SetId("")` should ensure `!d.IsNewResource()` is checked first 81: d.SetId("") 82: return nil ``` Output from acceptance testing: ``` --- FAIL: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot (4.02s) # alternate testing account issue --- FAIL: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard (4.11s) # alternate testing account issue --- PASS: TestAccAWSAcmCertificateValidation_basic (92.89s) --- PASS: TestAccAWSAcmCertificateValidation_timeout (25.70s) --- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdns (101.67s) --- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail (20.07s) --- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot (92.99s) --- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard (63.68s) --- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan (88.87s) --- PASS: TestAccAwsAcmpcaCertificate_EndEntityCertificate (35.64s) --- PASS: TestAccAwsAcmpcaCertificate_RootCertificate (28.20s) --- PASS: TestAccAwsAcmpcaCertificate_SubordinateCertificate (38.12s) --- PASS: TestAccAwsAcmpcaCertificate_Validity_Absolute (34.39s) --- PASS: TestAccAwsAcmpcaCertificate_Validity_EndDate (35.95s) --- PASS: TestAccAwsAcmpcaCertificateAuthority_basic (22.75s) --- PASS: TestAccAwsAcmpcaCertificateAuthority_DeleteFromActiveState (24.35s) --- PASS: TestAccAwsAcmpcaCertificateAuthority_disappears (14.37s) --- PASS: TestAccAwsAcmpcaCertificateAuthority_Enabled (53.63s) --- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname (120.00s) --- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled (95.90s) --- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays (74.81s) --- PASS: TestAccAwsAcmpcaCertificateAuthority_Tags (62.46s) --- PASS: TestAccAWSAMI_basic (63.47s) --- PASS: TestAccAWSAMI_description (76.70s) --- PASS: TestAccAWSAMI_disappears (60.26s) --- PASS: TestAccAWSAMI_EphemeralBlockDevices (63.85s) --- PASS: TestAccAWSAMI_Gp3BlockDevice (46.78s) --- PASS: TestAccAWSAMI_tags (89.70s) --- PASS: TestAccAWSAMILaunchPermission_basic (337.22s) --- PASS: TestAccAWSAMILaunchPermission_Disappears_AMI (354.06s) --- PASS: TestAccAWSAMILaunchPermission_Disappears_LaunchPermission (336.05s) --- PASS: TestAccAWSAMILaunchPermission_Disappears_LaunchPermission_Public (334.96s) ``` * tests/provider: Simplify semgrep helper-schema-ResourceData-SetId-empty-without-IsNewResource-check exclude paths
Configuration menu - View commit details
-
Copy full SHA for fc0e23e - Browse repository at this point
Copy the full SHA fc0e23eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02a7717 - Browse repository at this point
Copy the full SHA 02a7717View commit details -
resource/aws_synthetics_canary: Handle asynchronous IAM eventual cons…
…istency error on creation (#18404) * resource/aws_synthetics_canary: Handle asynchronous IAM eventual consistency error on creation Reference: #18101 Previously: ``` === CONT TestAccAWSSyntheticsCanary_basic resource_aws_synthetics_canary_test.go:82: Step 1/3 error: Error running apply: exit status 1 Error: error waiting for Synthetics Canary (tf-acc-test-s9t49btk) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 8e3169db-124d-4c5a-ac0e-d9f382cf737f; Proxy: null) on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test": 92: resource "aws_synthetics_canary" "test" { --- FAIL: TestAccAWSSyntheticsCanary_basic (16.37s) === CONT TestAccAWSSyntheticsCanary_runtimeVersion resource_aws_synthetics_canary_test.go:156: Step 1/3 error: Error running apply: exit status 1 Error: error waiting for Synthetics Canary (tf-acc-test-nenvizbg) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: ffcb7edb-c77e-43f2-8a0a-1183e92f0f8c; Proxy: null) on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test": 92: resource "aws_synthetics_canary" "test" { --- FAIL: TestAccAWSSyntheticsCanary_runtimeVersion (16.85s) === CONT TestAccAWSSyntheticsCanary_startCanary_codeChanges resource_aws_synthetics_canary_test.go:239: Step 1/3 error: Error running apply: exit status 1 Error: error waiting for Synthetics Canary (tf-acc-test-7c9erovn) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 1c4bacd4-3134-4df3-8e82-2538e155b524; Proxy: null) on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test": 92: resource "aws_synthetics_canary" "test" { --- FAIL: TestAccAWSSyntheticsCanary_startCanary_codeChanges (16.92s) === CONT TestAccAWSSyntheticsCanary_startCanary resource_aws_synthetics_canary_test.go:190: Step 1/4 error: Error running apply: exit status 1 Error: error waiting for Synthetics Canary (tf-acc-test-gzn0ksyz) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: afa63236-ac58-4cec-9c93-67192216f734; Proxy: null) on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test": 92: resource "aws_synthetics_canary" "test" { --- FAIL: TestAccAWSSyntheticsCanary_startCanary (17.91s) === CONT TestAccAWSSyntheticsCanary_s3 resource_aws_synthetics_canary_test.go:281: Step 1/2 error: Error running apply: exit status 1 Error: error waiting for Synthetics Canary (tf-acc-test-rhjz4908) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: ea96e8db-b243-499e-b6e9-54e5d30c7604; Proxy: null) on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test": 92: resource "aws_synthetics_canary" "test" { --- FAIL: TestAccAWSSyntheticsCanary_s3 (16.68s) === CONT TestAccAWSSyntheticsCanary_runConfig resource_aws_synthetics_canary_test.go:326: Step 1/4 error: Error running apply: exit status 1 Error: error waiting for Synthetics Canary (tf-acc-test-qy4r4rep) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: aee1cc0e-6f2d-4f8d-8720-91aa25333dcc; Proxy: null) on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test": 92: resource "aws_synthetics_canary" "test" { --- FAIL: TestAccAWSSyntheticsCanary_runConfig (15.30s) === CONT TestAccAWSSyntheticsCanary_runConfigTracing resource_aws_synthetics_canary_test.go:373: Step 1/4 error: Error running apply: exit status 1 Error: error waiting for Synthetics Canary (tf-acc-test-44kmj0af) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 653d7e28-e3a6-4d5d-8da0-818cb7debb9a; Proxy: null) on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test": 92: resource "aws_synthetics_canary" "test" { --- FAIL: TestAccAWSSyntheticsCanary_runConfigTracing (14.80s) === CONT TestAccAWSSyntheticsCanary_vpc resource_aws_synthetics_canary_test.go:416: Step 1/4 error: Error running apply: exit status 1 Error: error waiting for Synthetics Canary (tf-acc-test-278kyhh1) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 9e377590-2ea9-42db-8340-f181964fd388; Proxy: null) on terraform_plugin_test.tf line 150, in resource "aws_synthetics_canary" "test": 150: resource "aws_synthetics_canary" "test" { --- FAIL: TestAccAWSSyntheticsCanary_vpc (15.25s) === CONT TestAccAWSSyntheticsCanary_tags resource_aws_synthetics_canary_test.go:466: Step 1/4 error: Error running apply: exit status 1 Error: error waiting for Synthetics Canary (tf-acc-test-8thffpcs) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 60d2ea31-fdcb-4c4e-85ec-eecda075d58c; Proxy: null) on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test": 92: resource "aws_synthetics_canary" "test" { --- FAIL: TestAccAWSSyntheticsCanary_tags (15.32s) === CONT TestAccAWSSyntheticsCanary_disappears resource_aws_synthetics_canary_test.go:513: Step 1/1 error: Error running apply: exit status 1 Error: error waiting for Synthetics Canary (tf-acc-test-yelzrxeu) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 398f9321-06ea-4019-ba08-37594ec32f04; Proxy: null) on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test": 92: resource "aws_synthetics_canary" "test" { --- FAIL: TestAccAWSSyntheticsCanary_disappears (15.34s) ``` Output from acceptance testing: ``` --- PASS: TestAccAWSSyntheticsCanary_basic (105.78s) --- PASS: TestAccAWSSyntheticsCanary_disappears (59.55s) --- PASS: TestAccAWSSyntheticsCanary_runConfig (114.95s) --- PASS: TestAccAWSSyntheticsCanary_runConfigTracing (94.08s) --- PASS: TestAccAWSSyntheticsCanary_runtimeVersion (89.12s) --- PASS: TestAccAWSSyntheticsCanary_s3 (72.90s) --- PASS: TestAccAWSSyntheticsCanary_startCanary (124.81s) --- PASS: TestAccAWSSyntheticsCanary_startCanary_codeChanges (111.66s) --- PASS: TestAccAWSSyntheticsCanary_tags (115.10s) --- PASS: TestAccAWSSyntheticsCanary_vpc (678.91s) ``` * Update CHANGELOG for #18404
Configuration menu - View commit details
-
Copy full SHA for cfebb8d - Browse repository at this point
Copy the full SHA cfebb8dView commit details -
Update CHANGELOG.md for #18404
changelogbot committedMar 26, 2021 Configuration menu - View commit details
-
Copy full SHA for 3361f55 - Browse repository at this point
Copy the full SHA 3361f55View commit details -
Merge pull request #16979 from ewbankkit/f-r/aws_route_table-wavelength
r/aws_route_table: AWS Wavelength support and 'arn' attribute
Configuration menu - View commit details
-
Copy full SHA for 0994f68 - Browse repository at this point
Copy the full SHA 0994f68View commit details -
service/iam: Policy tagging support and add policy_id attribute (#18276)
Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSDataSourceIAMPolicy_basic (20.45s) --- PASS: TestAccAWSIAMPolicy_basic (22.11s) --- PASS: TestAccAWSIAMPolicy_description (21.92s) --- PASS: TestAccAWSIAMPolicy_disappears (18.51s) --- PASS: TestAccAWSIAMPolicy_namePrefix (22.36s) --- PASS: TestAccAWSIAMPolicy_path (22.27s) --- PASS: TestAccAWSIAMPolicy_policy (29.66s) --- PASS: TestAccAWSIAMPolicy_tags (36.52s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSDataSourceIAMPolicy_basic (25.35s) --- PASS: TestAccAWSIAMPolicy_basic (27.37s) --- PASS: TestAccAWSIAMPolicy_description (27.37s) --- PASS: TestAccAWSIAMPolicy_disappears (21.46s) --- PASS: TestAccAWSIAMPolicy_namePrefix (27.86s) --- PASS: TestAccAWSIAMPolicy_path (27.19s) --- PASS: TestAccAWSIAMPolicy_policy (41.21s) --- PASS: TestAccAWSIAMPolicy_tags (53.53s) ```
Configuration menu - View commit details
-
Copy full SHA for 3a08c22 - Browse repository at this point
Copy the full SHA 3a08c22View commit details -
resource/aws_ssm_parameter: Tag on create + validations (#17830)
Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSSSMParameter_disappears (35.77s) --- PASS: TestAccAWSSSMParameter_fullPath (51.23s) --- PASS: TestAccAWSSSMParameter_basic (51.86s) --- PASS: TestAccAWSSSMParameter_secure (52.09s) --- PASS: TestAccAWSSSMParameter_DataType_AwsEc2Image (58.46s) --- PASS: TestAccAWSSSMParameter_secure_with_key (60.49s) --- PASS: TestAccAWSSSMParameter_overwrite (77.69s) --- PASS: TestAccAWSSSMParameter_changeNameForcesNew (82.64s) --- PASS: TestAccAWSSSMParameter_updateDescription (82.84s) --- PASS: TestAccAWSSSMParameter_updateType (83.08s) --- PASS: TestAccAWSSSMParameter_secure_keyUpdate (85.13s) --- PASS: TestAccAWSSSMParameter_Tier_IntelligentTieringToStandard (93.66s) --- PASS: TestAccAWSSSMParameter_tags (94.47s) --- PASS: TestAccAWSSSMParameter_Tier (96.68s) --- PASS: TestAccAWSSSMParameter_Tier_IntelligentTieringToAdvanced (98.75s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSSSMParameter_disappears (40.39s) --- PASS: TestAccAWSSSMParameter_fullPath (59.78s) --- PASS: TestAccAWSSSMParameter_secure (59.78s) --- PASS: TestAccAWSSSMParameter_DataType_AwsEc2Image (59.81s) --- PASS: TestAccAWSSSMParameter_secure_with_key (59.87s) --- PASS: TestAccAWSSSMParameter_basic (59.88s) --- PASS: TestAccAWSSSMParameter_changeNameForcesNew (77.00s) --- PASS: TestAccAWSSSMParameter_updateDescription (83.65s) --- PASS: TestAccAWSSSMParameter_overwrite (84.29s) --- PASS: TestAccAWSSSMParameter_updateType (84.34s) --- PASS: TestAccAWSSSMParameter_secure_keyUpdate (85.81s) --- PASS: TestAccAWSSSMParameter_Tier_IntelligentTieringToStandard (97.59s) --- PASS: TestAccAWSSSMParameter_tags (100.37s) --- PASS: TestAccAWSSSMParameter_Tier (100.40s) --- PASS: TestAccAWSSSMParameter_Tier_IntelligentTieringToAdvanced (103.42s) ```
Configuration menu - View commit details
-
Copy full SHA for 7a8be07 - Browse repository at this point
Copy the full SHA 7a8be07View commit details -
build(deps): Bump github.com/aws/aws-sdk-go from 1.38.0 to 1.38.6 (#1…
…8424) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.38.0 to 1.38.6. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.38.0...v1.38.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for cf2b196 - Browse repository at this point
Copy the full SHA cf2b196View commit details -
Update CHANGELOG.md for #18424
changelogbot committedMar 26, 2021 Configuration menu - View commit details
-
Copy full SHA for e74a201 - Browse repository at this point
Copy the full SHA e74a201View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5fb25d - Browse repository at this point
Copy the full SHA b5fb25dView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc9dae2 - Browse repository at this point
Copy the full SHA dc9dae2View commit details -
build(deps): bump github/issue-labeler from v2.2 to v2.3 (#18322)
Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from v2.2 to v2.3. - [Release notes](https://github.com/github/issue-labeler/releases) - [Commits](github/issue-labeler@v2.2...a326d12) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 344e9bc - Browse repository at this point
Copy the full SHA 344e9bcView commit details -
resource/aws_efs_file_system: Add attributes and refactor to use wait…
…er package (#17969) Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (15.26s) --- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (29.48s) --- PASS: TestAccAWSEFSFileSystem_disappears (37.95s) --- PASS: TestAccAWSEFSFileSystem_kmsKey (54.93s) --- PASS: TestAccAWSEFSFileSystem_ThroughputMode (65.88s) --- PASS: TestAccAWSEFSFileSystem_basic (83.23s) --- PASS: TestAccAWSEFSFileSystem_pagedTags (85.76s) --- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (94.41s) --- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_removal (96.71s) --- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_update (107.04s) --- PASS: TestAccAWSEFSFileSystem_tags (142.76s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (19.51s) --- PASS: TestAccAWSEFSFileSystem_pagedTags (58.12s) --- PASS: TestAccAWSEFSFileSystem_kmsKey (64.15s) --- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (67.15s) --- PASS: TestAccAWSEFSFileSystem_disappears (85.41s) --- PASS: TestAccAWSEFSFileSystem_basic (95.51s) --- PASS: TestAccAWSEFSFileSystem_ThroughputMode (101.41s) --- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (103.19s) --- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_update (105.87s) --- PASS: TestAccAWSEFSFileSystem_tags (149.67s) --- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_removal (151.51s) ```
Configuration menu - View commit details
-
Copy full SHA for 79998b1 - Browse repository at this point
Copy the full SHA 79998b1View commit details -
Merge pull request #18341 from hashicorp/b-security-org-admin-account…
…-resource-retry resource/securityhub_organization_admin_account: retry on ResourceConflictException during creation
Configuration menu - View commit details
-
Copy full SHA for c5f8702 - Browse repository at this point
Copy the full SHA c5f8702View commit details -
Update CHANGELOG.md for #18341
changelogbot committedMar 26, 2021 Configuration menu - View commit details
-
Copy full SHA for 18cac7d - Browse repository at this point
Copy the full SHA 18cac7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bcad46f - Browse repository at this point
Copy the full SHA bcad46fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3956780 - Browse repository at this point
Copy the full SHA 3956780View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3d2438 - Browse repository at this point
Copy the full SHA a3d2438View commit details -
Configuration menu - View commit details
-
Copy full SHA for b443562 - Browse repository at this point
Copy the full SHA b443562View commit details -
d/aws_route: AWS Wavelength support.
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_ -timeout 120m === RUN TestAccAWSRouteDataSource_basic === PAUSE TestAccAWSRouteDataSource_basic === RUN TestAccAWSRouteDataSource_TransitGatewayID === PAUSE TestAccAWSRouteDataSource_TransitGatewayID === RUN TestAccAWSRouteDataSource_IPv6DestinationCidr === PAUSE TestAccAWSRouteDataSource_IPv6DestinationCidr === RUN TestAccAWSRouteDataSource_LocalGatewayID === PAUSE TestAccAWSRouteDataSource_LocalGatewayID === CONT TestAccAWSRouteDataSource_basic === CONT TestAccAWSRouteDataSource_LocalGatewayID data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found --- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (2.00s) === CONT TestAccAWSRouteDataSource_IPv6DestinationCidr --- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (24.28s) === CONT TestAccAWSRouteDataSource_TransitGatewayID --- PASS: TestAccAWSRouteDataSource_basic (328.90s) --- PASS: TestAccAWSRouteDataSource_TransitGatewayID (305.22s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 331.596s
Configuration menu - View commit details
-
Copy full SHA for f119734 - Browse repository at this point
Copy the full SHA f119734View commit details -
d/aws_route: Add 'TestAccAWSRouteDataSource_CarrierGatewayID'.
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_CarrierGatewayID' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_CarrierGatewayID -timeout 120m === RUN TestAccAWSRouteDataSource_CarrierGatewayID === PAUSE TestAccAWSRouteDataSource_CarrierGatewayID === CONT TestAccAWSRouteDataSource_CarrierGatewayID --- PASS: TestAccAWSRouteDataSource_CarrierGatewayID (25.26s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 25.394s
Configuration menu - View commit details
-
Copy full SHA for cf55b56 - Browse repository at this point
Copy the full SHA cf55b56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b7a446 - Browse repository at this point
Copy the full SHA 8b7a446View commit details -
Configuration menu - View commit details
-
Copy full SHA for 790d401 - Browse repository at this point
Copy the full SHA 790d401View commit details -
Configuration menu - View commit details
-
Copy full SHA for c679cff - Browse repository at this point
Copy the full SHA c679cffView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5ec59f - Browse repository at this point
Copy the full SHA f5ec59fView commit details -
Merge pull request #16963 from ewbankkit/d-aws_route-wavelength
d/aws_route: AWS Wavelength support
Configuration menu - View commit details
-
Copy full SHA for d76c0dc - Browse repository at this point
Copy the full SHA d76c0dcView commit details
Commits on Mar 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for db5984d - Browse repository at this point
Copy the full SHA db5984dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e7468b - Browse repository at this point
Copy the full SHA 3e7468bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 628497f - Browse repository at this point
Copy the full SHA 628497fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c39042 - Browse repository at this point
Copy the full SHA 5c39042View commit details -
Configuration menu - View commit details
-
Copy full SHA for d941b58 - Browse repository at this point
Copy the full SHA d941b58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4246861 - Browse repository at this point
Copy the full SHA 4246861View commit details -
Merge pull request #16936 from shuheiktgw/ecs_service_deployment_circ…
…uit_breaker resource/aws_ecs_service: Add support for deployment circuit breaker
Configuration menu - View commit details
-
Copy full SHA for d0fb8dd - Browse repository at this point
Copy the full SHA d0fb8ddView commit details