Fix undefined var error when editing name if ace is not installed. #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeliciousJaffa
changed the title
Kexanone
approved these changes
May 19, 2018
CreepPork
added
fix
Kexanone
pushed a commit
that referenced
this pull request
Jul 6, 2018
* Update readme paths * update links in readme (part 2) * Readme: Get rid of Heroku webhooks. * Update README.md * Small fixes (#293) * Remove duplicate IDC * Missing localization * Remote control module still used vanilla function * Rename stringtable key for delta distribution * Hint module is now shown as Advanced Hint (#294) * Hint module is now shown as Advanced Hint * Swapped the category * Add fr/de translations * Reorganize and fix Adv Hint (#308) * use ace_common_fnc_setName (#305) * Fix for the Damage Building Module (#304) * Use remoteExecCall instead of broadcasting the entire function * Specify the target * Fix undefined var error if ace is not installed. (#311) * Added DeliciousJaffa (#317) * Replace nonsensical default value (#320) * Revised CAS modules (#319) * Fix targeting and fire flares * Address review comments + additional launch CM params * Fix launch CM * extraordinary important optimization * Add change log for 1.0.3 * Small features (#321) * Add artillery precision option * Add artillery precision option (resolves #133) * Revise paradrop: Drops below 150 => HALO (resolves #112) * Add spaces for readability * Correct change log (#322) * Reorganize Tools (#323) * move priv key folder to Achilles and ignore it * Reorganize Tools * New mintty-tmux session launcher * Revised AddonBuilder batch script * AchillesConnectToServer * Update gitignore * Rename Tools folder and add bat extension to AchillesAddonBuilder * Fix travis tools path * Reintroduce the faction filter (#326) * Reintroduce the faction filter * Update changlog.md * Fix filter by uncommenting the required parts * HALO (#324) * Fix backpack inventory duplication * Improve paradrop accuracy * Add HALO option for reinforcements * Improved the fitted function for HALO * Fix error in function for HALO parameter * More frequent checking time for height, since 1 sec can make a lot of difference in height * Achilles_fnc_chute: Add default value for delay and reset chute deploy height to 100m * Reinforcement: Set aircraft to carless, restrict HALO for planes only * Add HALO option to teleport module * Address point in review * Address points in review (part 2) * update change log * Reinforcment: Fix CUP planes * Achilles_fnc_chute: change chute deployment height to 120m * Update changelog.md * Use proper syntax for link in changlog * Remove the extra space in the changelog * Change 1.0.3 to 1.1.0 (#327) * Fix locality issue for HALO option in the teleport module (#328) * Broadcast chute function and exec on local machine * Code optimization
Kexanone
pushed a commit
that referenced
this pull request
Aug 3, 2018
* Update readme paths * update links in readme (part 2) * Readme: Get rid of Heroku webhooks. * Update README.md * Small fixes (#293) * Remove duplicate IDC * Missing localization * Remote control module still used vanilla function * Rename stringtable key for delta distribution * Hint module is now shown as Advanced Hint (#294) * Hint module is now shown as Advanced Hint * Swapped the category * Add fr/de translations * Reorganize and fix Adv Hint (#308) * use ace_common_fnc_setName (#305) * Fix for the Damage Building Module (#304) * Use remoteExecCall instead of broadcasting the entire function * Specify the target * Fix undefined var error if ace is not installed. (#311) * Added DeliciousJaffa (#317) * Replace nonsensical default value (#320) * Revised CAS modules (#319) * Fix targeting and fire flares * Address review comments + additional launch CM params * Fix launch CM * extraordinary important optimization * Add change log for 1.0.3 * Small features (#321) * Add artillery precision option * Add artillery precision option (resolves #133) * Revise paradrop: Drops below 150 => HALO (resolves #112) * Add spaces for readability * Correct change log (#322) * Reorganize Tools (#323) * move priv key folder to Achilles and ignore it * Reorganize Tools * New mintty-tmux session launcher * Revised AddonBuilder batch script * AchillesConnectToServer * Update gitignore * Rename Tools folder and add bat extension to AchillesAddonBuilder * Fix travis tools path * Reintroduce the faction filter (#326) * Reintroduce the faction filter * Update changlog.md * Fix filter by uncommenting the required parts * HALO (#324) * Fix backpack inventory duplication * Improve paradrop accuracy * Add HALO option for reinforcements * Improved the fitted function for HALO * Fix error in function for HALO parameter * More frequent checking time for height, since 1 sec can make a lot of difference in height * Achilles_fnc_chute: Add default value for delay and reset chute deploy height to 100m * Reinforcement: Set aircraft to carless, restrict HALO for planes only * Add HALO option to teleport module * Address point in review * Address points in review (part 2) * update change log * Reinforcment: Fix CUP planes * Achilles_fnc_chute: change chute deployment height to 120m * Update changelog.md * Use proper syntax for link in changlog * Remove the extra space in the changelog * Change 1.0.3 to 1.1.0 (#327) * Fix locality issue for HALO option in the teleport module (#328) * Broadcast chute function and exec on local machine * Code optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Fixes changes for Changing unit name does not change unit name in ACE3 #300 in Get the Name Attribute Working for ACE3 #305