OKex: fix websockets endpoint #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge latest remote master
update supported exchange list
clean up usings
jjxtra
previously approved these changes
Mar 4, 2020
vslee
changed the title
|
@szmcdull, please rebase to resolve conflicts |
…uby#489) * HitBTC: allow OnGetDepositHistoryAsync() for all currencies - handles when currency param is null, allowing the return of all currencies w/o filtering - marked currency param as nullable in preparation for future C# 8 conversion on this file (even though it will throw one additional warning for now) * Update ExchangeHitbtcAPI.cs * Update ExchangeHitbtcAPI.cs
* Add orderbook option * Add call to fetch full orderbook from BL3P * Remove configureawait from On* overrides
* Change to netstandard20 * Add Roslyn analyzers * Move files to new structure * Add global.json with target to .netcore 3.0 * Move win forms dependencies to another package * Target net472 * Use new resource manager * Migrate example forms project to new csproj style with hvanbakel/CsprojToVs2017 * Fix azure pipelines
* Add script to publish console as single file * Remove script in favor of Azure pipelines and move .gitignore * Setup azure-pipelines * Set up CI with Azure Pipelines * Add PR build and fix cron (I hope) * Separate ci build from cd publish * Remove batch and fix artifact * Add build configuration
* attempt fix of Azure pipeline GH connection - change gitHubConnection to jjxtra from johnnyasantoss * Update azure-pipelines.yml
* Fix BL3P entry in the readme * Add alt to logo * Update README * VSCode stuff
- NDAX sometimes uses _ as a symbol separater and sometimes it does not - change the _marketSymbolToInstrumentIdMapping to store the symbol w/o the _ - then search both ways if needed
- found another Binance...
- allow the input of the seconds equivalent of 28, 30, 31 days - also keep the value for 49 days for backwards compatibility
- remove global.json (so we always use the latest .NET Core SDK for CLI commands)
- ExchangeSharp.Forms is just a sample project - we only publish a nuget from the main ExchangeSharp project
- not supported directly in Bittrex - throw an APIException redirecting users to alternate methods - resolves DigitalRuby#508
…Ruby#511) - added `int? limit` as a parameter - added/fixed GetRecentTradesAsync on multiple exchanges (Binance, HitBTC, Bitfinex and numerous others) - for GetRecentTradesAsync, the sort order will be Descending (ie newest trades first) - resolves DigitalRuby#510
…gitalRuby#513) - changed endpoint for GetRecentTradesAsync() - changed TS parsing to UnixNanoseconds for both - DRY both methods - fixes DigitalRuby#454
…Ruby#515) * Test and fix base ExhchangeAPI symbol functionality * Fix bitthumb and Kraken APIs
* Correct HelpText with examples with work * revert unintended change
- when the connection breaks, the MemoryStream is disposed, so a new one needs to be created - prev, it was only created once outside the loop - now, it will be created with every loop
* add BTSE public api * redorder
… some symbols, changed to long) (DigitalRuby#524)
|
KuCoin is unchanged. Now I understand it is because the file tree was changed |
vslee
changed the title
vslee
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the websocket port of okex according to latest document.
And merge kucoin ticker fix again. Don't know why it was reverted.