Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 4.13.0 into master #2736

Merged
merged 711 commits into from
Dec 22, 2020
Merged

Merge 4.13.0 into master #2736

merged 711 commits into from
Dec 22, 2020

Conversation

diegolmello
Copy link
Member

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

GOVINDDIXIT and others added 30 commits June 16, 2020 10:31
@GOVINDDIXIT
[NEW] Add fastlane to android module and configure CI (#2100)
089e4bf
@EzequielDeOliveira @diegolmello
[IMPROVEMENT] Use react-native-notifier for in-app notifications (#2139)
2632ef5 
Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com>

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@EzequielDeOliveira @diegolmello
[CHORE] Create DimensionsContext (#2098)
36b37eb 
Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com>

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@diegolmello
[FIX] Remove duplicated sCU condition (#2194)
8da50c2
@EzequielDeOliveira @diegolmello
[FIX] The auto translate toggle don't save right state (#2142)
5e48897 
Signed-off-by: Ezequiel De Oliveira <ezequiel1de1oliveira@gmail.com>

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@Fishbowler @diegolmello
[CHORE] Increase "content_hash_max_items" on Watchman (#2181)
bbe07fa 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[NEW] IFrame authentication (#2184)
a992c51 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[NEW] Send multiple attachments (#2162)
07e9bcb 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[NEW] Omnichannel Status Toggle (#2217)
ff74f6e 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[FIX] Typing when UI_Use_Real_Name is enabled (#2216)
8fe0615 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre
[REGRESSION] Logout failing after #2217 (#2222)
a5aba5f
@djorkaeffalexandre @diegolmello
[CHORE] Add wrapper to make Meteor methods calls over REST (#2104)
e34b7cb 
* [WIP] Use rest instead methodCall

* [WIP] Some method calls using wrapper

* [WIP] Wrap all necessary methodCalls

* fix

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[IMPROVEMENT] Mark thread as read on open (#2225)
4def17c 
* [IMPROVEMENT] Mark a thread as read

* Use methodCallWrapper

* Check server version

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre
[FIX] Read receipt icon on action sheet (#2237)
bf63014
@youssef-md @diegolmello
[FIX] Handle TypeErrors on navigationRef and draftMessage due to null…
68e9e14 
… properties (#2232)

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@diegolmello
[FIX] Android crashing when restoring from background (#2238)
a7e7d1f
@djorkaeffalexandre
[FIX] Send thread attachment (#2242)
6abfbf6
@djorkaeffalexandre @diegolmello
[FIX] Iframe auth Login Button (#2241)
c1f3f89 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[REGRESSION] Audio Recording (#2240)
f4118b6 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@regalstreak @diegolmello
[IMPROVEMENT] Expo-av audio recorder (#2195)
2ec2a52 
* [NEW] MessageBox: Expo-av audio recorder

* Refactor MessageBox to accommodate recording button even when recording
* Rename Recording.js -> RecordAudio.js as we could implement video recording in the future

* RecordAudio: Introduce cancel and send buttons

* RecordAudio: Introduce recorderBusy state, refactor MessageBox, remove useless SafeAreaView

* RecordAudio: Better audio quality 🎉, stop recording on unmount

* RecordAudio: Use FileSystem from expo-file-system instead of RNFetchBlob

* chore: flush out react-native-audio

* fix(MessageBox): bring back some missed styles during refactor

* refactor(RecordAudio): use class component

* refactor(RecordAudio): recorder busy to class property, styling changes

* recorder initialisation changes

* fix(RecordAudio): missing await in isRecordingPermissionGranted

* fix(RecordAudio): set isRecording = false on cancel/finish, refactor perms

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@diegolmello
[IMPROVEMENT] Unified header UX (#2234)
5834ab5 
* Change drawer icon

* Removed iOS variation

* Patch to react-navigation-header-buttons... easier to patch then to overwrite its behaviour :(

* Correctly position title

* Header subtitle

* Layout

* Alignment

* RoomView header

* Renamed RoomHeaderLeft to LeftButtons

* RoomView back button

* Search icon on RoomView

* Refactor

* Fix header on tablet

* Fix search messages close button on tablet

* Search key command

* Network status on RoomView header subtitle

* Update tests

* Scale content

* SearchBox cancel color
@diegolmello
Bump version to 4.9.0 (#2248)
7c52e6e
@youssef-md @diegolmello
[FIX] Check for UI_Use_Real_Name when sorting rooms (#2230)
20604c4 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre
[FIX] Emoji keyboard not showing custom and frequently used emojis on…
83fbb8c 
… Share Extension (#2251)
@djorkaeffalexandre @diegolmello
[FIX] Scroll to top crashing when ref is undefined (#2252)
362ef00 
* [FIX] Check if exists scroll ref

* Remove scrollTo

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[FIX] AttachmentView crashing during title decode (#2253)
5b3be4e 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[FIX] Command previews crashing when API returns an error (#2254)
e1153de 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[FIX] ThreadMessagesView throwing error when subscription wasn't found (
ef68f16 
#2255)

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[FIX] Register crashing when error data is undefined (#2256)
ea10693 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[FIX] Get active route returning undefined (#2257)
53cc823 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
djorkaeffalexandre and others added 28 commits November 30, 2020 14:00
@djorkaeffalexandre @diegolmello
[NEW] Support client certificates for SSL (two-way authentication) (A…
155fc04 
…ndroid) (#2624)

* wip: Android SSL Pinning

* Use own SSLPinningModule

* wip: Use Rocket.Chat own react-native

* wip: Fresco Images using custom OkHttpClient

* wip: react-native-webview onReceivedClientCertRequest

* feat: Save Images of a SSL Pinning protected server

* chore: SSLPinning package as a interface to iOS & Android implementations

* chore: update glide

* feat: load images under a client ssl certificate protected server

* chore: remove patch

* feat: Audio & Video under a SSL Client protected server

* fix: Unpin certificate when change server

* feat: Fast Image as a patch

* chore: update fast-image

* Fix merge

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@diegolmello
[NEW] Channel actions (#2644)
40490ea 
* room roles

* handle owner

* endpoints

* Leader and Moderator

* Remove user from room

* stash ignore

* Add subscription.ignored column

* ignore user

* Fix icons

* I18n

* Minor i18n fixes

* Direct Message and open action sheet after a normal tap

* Fix icon

* stash isIgnored

* isManualUnignored message

* Fix update

* Ignored

* Mute, moderator, leader, owner, remove from room

* ignore

* Tests

* pt-BR

* Update pods

* Apply requested changes

* Add RC version on requests
@djorkaeffalexandre @diegolmello
[NEW] Support RTL (#2656)
10ba9d5 
* wip: RTL (iOS)

* wip: RTL (Android)

* wip: reload bundle when change between RTL languages

* fix: Stack Animation on Android

* fix: update snapshot

* fix: Swipe Room Actions in RTL mode

* fix: snapshots

* Move isRTL to i18n

* Fix styling

* Update tests

* Update pods

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@zaphod534
[FIX] Initial users' status is not fetched (#2664)
b61727c
@diegolmello @djorkaeffalexandre
[FIX] Messages overlapping and emoji keyboard not opening (#2670)
7b4be8b 
* Replace keyboard libs for react-native-ui-lib

* Apply Jitsi branch

* Require keyboard on bundle

* Update ui-lib

* chore: update deps

Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
@djorkaeffalexandre @diegolmello
[CHORE] Force normalized params for 2FA (#2683)
3bc8161 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[FIX] Thread message flickering while thread parent isn't found (#2676)
13c3bc3 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[FIX] Light theme not working on Android with Dark Theme set (#2675)
06521d1 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@DanMke @vitorl-s
@frclba @djorkaeffalexandre @youssef-md @diegolmello
[FIX] App not prompting join code for password protected channels (#2514
13985cf 
)

* Adding joinCode parameter

Co-authored-by: Vitor Leal <vitor_leal2201@hotmail.com>
Co-authored-by: Fernando Aguilar <fernando.aguilar@hotmail.com.br>

* Insert join code input

Signed-off-by: Vitor.Leal <vitor_leal2201@hotmail.com>

* Add joinCode field on db

Signed-off-by: Vitor.Leal <vitor_leal2201@hotmail.com>

* Add label i18 pt-br and en-us

Signed-off-by: Vitor.Leal <vitor_leal2201@hotmail.com>

* Add insert join code text

Signed-off-by: Vitor.Leal <vitor_leal2201@hotmail.com>

* Fix atribute name

Signed-off-by: Vitor.Leal <vitor_leal2201@hotmail.com>

* Add join text

Signed-off-by: Vitor.Leal <vitor_leal2201@hotmail.com>

Co-authored-by: Daniel Maike <danmke@hotmail.com>
Co-authored-by: Fernando Aguilar <fernando.aguilar@hotmail.com.br>

* Fix attributes joinCode, joinCodeRequired and pass attribute param in navigation

Signed-off-by: Daniel Maike <danmke@hotmail.com>

Co-authored-by: Vitor Leal <vitor_leal2201@hotmail.com>

* Fixing attribute joinCodeRequired pass to goRoom

Signed-off-by: Daniel Maike <danmke@hotmail.com>

* Changed textinput style

Signed-off-by: Daniel Maike <danmke@hotmail.com>

Co-authored-by: Vitor Leal <vitor_leal2201@hotmail.com>

* Delete not necessary attribute

Signed-off-by: Daniel Maike <danmke@hotmail.com>

* Fixing input style

Co-authored-by: Vitor Leal <vitor_leal2201@hotmail.com>

* Undo unncessary changes

* use a join code modal

* tests: e2e tests to join protected channel

* fix: undo unnecessary change

* tests: cancel join code

* Remove some tests

* Minor fixes

Co-authored-by: Vitor Leal <vitor_leal2201@hotmail.com>
Co-authored-by: Fernando Aguilar <fernando.aguilar@hotmail.com.br>
Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
Co-authored-by: youssef-md <emaildeyoussefmuhamad@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@abalhamoud @diegolmello
[I18n] Add Arabic (#2537)
27e0ee0 
* Arabic language setup

* Added arabic translation

* Arabic translation Proofreading

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@David-Tsui @diegolmello
[I18N] Add missing zh_TW and zh_CN strings (#2680)
274f50c 
* feat(i18n): add some missing strings and improve some translation

* fix: add missing server version

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@dkoo761 @diegolmello
[IMPROVEMENT] Add username on status messages (#2553)
b0b9d62 
* 1689 - missing user name for status messages

* 1689 - missing user name for status messages. Fixed broken e2e test "should pin message".

* Minor tweak

* Remove center style

* Small refactor on User

* Remove toLowerCase

* Update tests

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[FIX] Filenames are incorrect in non-latin alphabets on upload (#2671)
2403eb3 
* fix: filename on react-native-image-crop-picker

* fix: use rn-fetch-blob to upload files

* fix: FileUpload as a service

* fix: cancel upload on iOS

* fix: file upload from share extension

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@grahamsmith @diegolmello
[IMPROVEMENT] Ease white labelling for Android (#2685)
2d6572d 
* improve white labelling for Android

* Move application ID to gradle properties

* Fix CI

* Point foss sufix to main app

* Use npx on android-whitelabel script

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@diegolmello @djorkaeffalexandre
[FIX] Chats order (#2688)
999883e 
* Persist highest value on subscription.roomUpdatedAt

* Update tests

Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
@diegolmello
[REGRESSION] Re-enable Jitsi Chat (#2687)
c9c8bde 
* Fix main jitsi

* Fix iOS

* Clear build.gradle cache

* Don't restore gradle

* cache is back

* Use master

* Point to react-native-jitsi-meet#master
@diegolmello @djorkaeffalexandre
[CHORE] Build official apps on CI (#2701)
cd76dd9 
* Duplicated target and changed Bridging Header

* Display name

* Unnecessary dumb swift file removed

* Buildable name

* Reorder Info.plist

* Rename Official target's bundle id

* Ignore .mobileprovision

* Fix provisioning of official app

* Starting signing

* stash fastfile

* starting official ci iOS

* Uncomment Fastfile keychain

* Fix CI config

* allowProvisioningUpdates

* Changing AppIcon and Splash Screen

* Remove unnecessary folder inside of Images.xcassets

* Reorder notificationservice and shareextension plists

* Fix signing

* Manual signing style for official

* Split official signing

* Update project provisioning

* Use ENV as profile

* Output match

* Keys

* TestFlight refactor

* Setting up android

* android-official-play-build job

* Start removing unnecessary fastlane tasks on Android

* Trying to refactor Android jobs

* android-env

* Remove foss build for now

* Fork

* Fix if conditions

* Fix push

* ios-build command

* Rename Android builds

* Upload dSYMs

* Refactoring workflow

* Reorder upload-to-testflight

* upload-to-google-play-beta command

* Fix ci

* Fix android fork build

* Fix keystore

* Fix options on fastlane android

* Fix keystore

* Check isOfficial on iOS

* Check isOfficial on db

* Remove unused imports

* Database names on Android

* Tag fix

* Minor fixes

* Set IS_OFFICIAL on CI

* Fix detox

* follow review suggestions

Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
@faziloub @diegolmello
[i18n] Update fr (#2697)
4c2381d 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@Cormoran96 @diegolmello
[i18n] Update fr (#2705)
f5b9dc6 
Typo

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[FIX] Empty space on Messagebox (#2704)
5d4e820 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@diegolmello
[FIX] Yarn android scripts (#2716)
20a00ee
@diegolmello
[CHORE] Rename Experimental iOS lane (#2717)
2f3a248 
* Move build_fork to the end

* Rename release to build_experimental
@diegolmello
[IMPROVEMENT] Use class variable instead of state for List's animated (…
a34807d 
…#2718)
@diegolmello
[FIX] Bottom sheet being hidden sometimes (#2722)
e64e278
@diegolmello
[IMPROVEMENT] Match background and text mention colors (#2723)
6a02623
@diegolmello
[FIX] App freezing if Markdown preview contains sequential empty spac…
7c09112 
…es (#2726)

* Remove sequential empty spaces from Markdown preview

* Use Markdown preview on RepliedThread
@diegolmello
[FIX] Official app without sharedUserId (#2734)
a385a7d
@diegolmello
Merge branch 'master' into beta
da7ee62
@diegolmello diegolmello merged commit 12bb23a into master Dec 22, 2020
@diegolmello diegolmello deleted the beta branch December 22, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.