Accounts team/accounts package ts migration/sprint 6 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…_changes Shaheer/sprint6 ts migration changes
…ace them with config file (binary-com#11575) * refactor: split files into respected folders and remove hard-coded variables * refactor: used aliases and added new Helper Alias
…d screens (binary-com#11684) * feat: add scetch of MT5ChangeInvestorPasswordScreens component * feat: change text size for emailSendContent * feat: change WalletButton size * feat: change some button styles * feat: complete scetch of change investor password screens
…-com#11687) * chore: removed responsive root * fix: fix issue where poa screen is not shown * chore: removed unrelated changes
…, even not all fields have been touched) (binary-com#11307) * chore: [COJ]|wall-2430, fix for trading assessment form * fix: required message is shown after chosing one option * fix: touched filed without error --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
…10711) * fix: ✅ updated testcases * fix: failing tests * refactor: code and ts fixes * fix: display of IDV error * chore: add duplication account error * refactor: added undefined check to response data * chore: review comments * chore: review comments * fix: ⬆️ upgraded SDK and handled language change * fix: ♻️ incorporated review comments * fix: ♻️ refactored code to remove useRef * fix: barriers test fix form master * fix: barriers test * chore: refactored object.freeze to as const * chore: optional chaining to document type * chore: update spec file for idv-form * test: update personal-details spec * chore: review comments * refactor: ♻️ incorporated hooks to handle business logic * refactor: css structure * fix: barriers test * fix: ⚰️ removed unwanted code * test: 🔥 removed mocked tokens * chore: 📝 Added documentation for UseNotificationEvent hook * fix: 💄 incorporated styling * fix: ♻️ incorporated review comments * refactor: rename properties * refactor: remove is_appstore from tests * fix: ♻️ incorporated review comments * refactor: styles refactor * fix: ⚡ reduced duplicate data * fix: incorporated review comments * fix: ♻️ incorporated review comments * chore: Trigger Build * fix: 🚚 modified path * chore: remove unused fila and variable, updated icons * revert: 🍻 removed icon changes * refactor: removed formatting * fix: removed assignment of default values * fix: 🐛 unable to select a new doc supporting country * fix: 🐛 resolved re-render issue * fix: ⚡ resolved message issue * refactor: 🚚 renamed varibales * fix: 🧪 failing testcase * fix: 🐛 resolved issues with failure messages * fix: 🐛 resolved issue with DIEL accounts * fix: 🐛 fixed issue for DIEL clients * fix: styling issues * fix: ts error for format-response * build: 📌 updated package-lock after updating onfido-sdk-ui * fix: 🚚 fixed path * fix: 🚚 fixed path * fix: 🐛 resolved styling bugs * fix: 🐛 resolved styling bugs * fix: ♻️ removed default values * fix: 🔥 incorporated new styles to fix icon size * fix: 🔥 incorporated new styles to fix icon size * fix: ✅ fixed failing testcase * fix: 💚 eslint issues * fix: ⚡ incorporated platform language change * fix: removed store * fix: layout styles * fix: style issues * fix: styles * fix: moved common styles to core * refactor: incorporated review comments * fix: 💄 updated styles * fix: 🐛 reverted code * fix: 🐛 reverted code * refactor: incorporated review comments * fix: 🐛 Onfido SDK language code conversion * fix: migrated hooks * revert: logic for generating code * chore: adding missing testcases * fix: recatored Onfido constants * fix: onfido screen css issues * fix: removed package-lock to resolve merge error * Merge branch 'master' into likhith/KYC-363/onfido-sdk-updation * chore: added package-lock * Merge branch 'master' into combined/wall-400/IDV-error-message-handled * chore: Trigger Build * fix: bug: /WEBREL-1358/personal-details page and poa page css issue * fix: layout button * fix: layout button * fix: mt5 next button not getting enabled * fix: resolved issue with button * fix: resolved issue with button * fix: resolved missing dropdown * fix: removed console * fix: incorporated review comments * feat: ✨ incorporated new images and merged checkbox feature * feat: ✨ incorporated new images and merged checkbox feature * refactor: split components * fix: idv failed document type * fix: removed duplicate import * fix: incorporated error message scenario * fix: styling as per new figma * fix: styling as per new figma * fix: spacing between fields * fix: spacing between fields * fix: spacing between fields * fix: incorporated new error code and styles as per new figma * fix: incorporated new error code and styles as per new figma * feat: incorporated idv-error codes * Merge branch 'master' into likhith/kyc-195/display-idv-error-messages * fix: reverted changes * Incorporate poi context (#55) * chore: incorporate POIContext to keep track of submission * chore: reset poi context state upon route change * refactor: added reset for all path * fix: changed testcases --------- Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> * fix: incorporated Onfido error messages * chore: removed dead code * fix: incorporated review comments * fix: incorporated review comments * fix: import paths * fix: Onfido error for failed selfie check * fix: incorporated missing status code * fix: button width * fix: Error text for Failure of IDV * fix: changed icon badge * fix: onfido check in POI * fix: failing testcase * fix: user flow for POI * fix: layout for Expired scenario in onfido * fix: styling of erro message * fix: code smells * chore: trigger rebuild * fix: issue with checkbox * fix: removed unused import * fix: added keyboard event * fix: resolved build failure * Merge branch 'master' into likhith/KYC-363/onfido-sdk-updation * fix: Onfido styles * fix: resolved code-smells * fix: resolved code smells * fix: code styling * fix: review comments --------- Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Shahzaib <shahzaib@deriv.com>
…y-com#11116) * fix: mobile - remove extra spacing below run button * fix: duration field validation error is not displayed when switching the duration type * fix: remove the text cursor on mobile as we have disabled the keyboard * fix: unable to see typed texts on the Quick Strategy Field * refactor: implementation of fix unable to see typed texts on the Quick Strategy Field * test: update test-cases of symbol component * test: add 1 test-case * chore: clean unnecessary imports * chore: minor changes * chore: return back other changes * chore: return back other changes * chore: add optional type * refactor: rewrite test cases for qs input and symbol select * fix: appearing stable icon of the symbol select * chore: remove unnecessary styles * chore: return back onchange method of qs-input * refactor: remove a few test cases without loosing coverage percentage * fix: appearence of the caret in symbol dropdown upon typing text
* feat: ✨ mt5 account creation manual flow * fix: ⚒️ sonarcloud bug * fix: 🧹 failing test * refactor: ⚙️ hide footer for manual upload first screen * fix: 🛠️ comments and cleaning-ups * revert: 🤸 icons file
* chore: update WalletPasswordField - updated WalletPasswordField by using third party lib - WalletPasswordField has new error message and new scoring system - updated HelperMessage by accepting variants - created hook for PasswordValidation * fix: improve hooks * fix: validaton on userInput and added type score * chore: resolve comments pt-1 - move regex values to constant file - seperate hook funtionality - resolve comments * chore: resolve comments pt.2 - make usePasswordValidation into a util function - make change accordingly based on the changes - remove usePasswordValidation hook * fix: updated package with a newer version * fix: remove english language package from the codebase * fix: resolve comments pt.1
…ary-com#10711)" (binary-com#11694) This reverts commit 855b87c.
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* chore: removed responsive root * fix: fix issue where poa screen is not shown * chore: removed unrelated changes * feat: added creation of mt5 accounts
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…-and-DxTrade (binary-com#11608) * refactor: hook to check if ctrader and dxtrade is allowed in current country of residence * chore: Update hook description as per code review Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com> * refactor: use modified_accesible_platform format * refactor: rename variable to use snake_case --------- Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com>
…ts_migration/sprint_6
shaheer-deriv
requested review from
matin-deriv,
maryia-deriv,
hirad-deriv,
vinu-deriv,
amina-deriv and
yashim-deriv
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.