Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor metrics TimeWindow #11638

Merged
merged 13 commits into from
Mar 1, 2023
Merged

Conversation

mytang0
Copy link
Member

@mytang0 mytang0 commented Feb 23, 2023

What is the purpose of the change

issue #11637

  1. Abstract sliding window
  2. Refactor TimeWindow Counter and Quantile

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@mytang0 mytang0 changed the title Refactor sliding window Refactor metrics TimeWindow Feb 23, 2023
@mytang0
Copy link
Member Author

mytang0 commented Feb 23, 2023

PTAL @songxiaosheng @Henrik-Yao

@songxiaosheng
Copy link
Member

PTAL @songxiaosheng @Henrik-Yao

please wait,thanks

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Merging #11638 (c8020d5) into 3.2 (32ada24) will increase coverage by 1.92%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11638      +/-   ##
============================================
+ Coverage     67.13%   69.06%   +1.92%     
  Complexity        2        2              
============================================
  Files          1614     1502     -112     
  Lines         65226    62717    -2509     
  Branches       9439     9226     -213     
============================================
- Hits          43790    43315     -475     
+ Misses        17159    15161    -1998     
+ Partials       4277     4241      -36     
Impacted Files Coverage Δ
...he/dubbo/metrics/aggregate/TimeWindowQuantile.java 84.21% <0.00%> (-15.79%) ⬇️
...che/dubbo/metrics/aggregate/TimeWindowCounter.java 87.50% <0.00%> (-12.50%) ⬇️
...router/condition/config/AppStateRouterFactory.java 88.88% <0.00%> (-11.12%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-6.90%) ⬇️
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0.00%> (-5.27%) ⬇️
...exchange/support/header/HeaderExchangeHandler.java 61.34% <0.00%> (-2.53%) ⬇️
...egistry/kubernetes/KubernetesServiceDiscovery.java 73.58% <0.00%> (-2.36%) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 91.83% <0.00%> (-2.05%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 77.04% <0.00%> (-1.64%) ⬇️
.../dubbo/registry/integration/RegistryDirectory.java 72.88% <0.00%> (ø)
... and 134 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mytang0
Copy link
Member Author

mytang0 commented Feb 24, 2023

Please take a review @AlbumenJ

* origin/3.2:
  sync reflect config (apache#11668)
  Fix qos command remote check (apache#11506)
  Fix license check
  Add 'label match' support for override and tag rules (apache#11094)
  Dubbo maven plugin with native (apache#11540)
  fix: fix observation spi config (apache#11660)
  Update .licenserc.yaml
  fix tri wrapper pack npe (apache#11656)
  remove duplicate flowcontroller listener (apache#11642)
  Metrics RT count optimization (apache#11628)
  Observability task: registration center (apache#11493)
  Migration bugfix & optimization (apache#11629)
  Fix service name mapping check failed (apache#11643)
  fix: executor (apache#11652)
  Fix license check
  fixed broken link readme.md (apache#11641)
@mytang0 mytang0 requested a review from AlbumenJ February 27, 2023 03:19
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* origin/3.2:
  Fix heartbeat failed if serialization changed (apache#11512)
  Update README.md
  Tag router problem fix (apache#11586)
  delete never thrown exception (apache#11674)
  ♻️refact metrics key and meter unit (apache#11661)
  feat: optimize code (apache#11671)
  Introduce getConfig QoS Command (apache#11664)
@mytang0 mytang0 requested a review from AlbumenJ February 27, 2023 16:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.6% 80.6% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 6d6e3a5 into apache:3.2 Mar 1, 2023
lcb11 pushed a commit to lcb11/dubbo that referenced this pull request Mar 31, 2023
* Add TimeUtils

* Abstract sliding window

* Refactor TimeWindow Counter and Quantile

* Add license header

* Fix sonar problem

* Fix sonar problem

* Fix sonar check bug

* Start the ticker on demand

* Fallback when ticker exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants